Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF

["Leif Lindholm" <leif.lindholm@linaro.org>]

Hi Shenglei,

I have now reviewed the patches that are mine to review.
Many thanks for this bit of cleanup/standardisation.

I would just like to raise one warning flag:
These patches have been submitted without the Contributed-under tag.
That means the series needs to either be held back until an overall
repository license change happens, or v2 needs to be submitted with
Contributed-under.

Best Regards,

Leif

On Wed, May 15, 2019 at 04:56:45PM +0800, Zhang, Shenglei wrote:
> We have plan to move all network related modules/libraries to
> NetworkPkg. So in order to make these changes happen smoothly,
> We update platforms' DSC/FDF to use Network's include segment files.
> 
> Shenglei Zhang (16):
>   Platform/OverdriveBoard: Update DSC/FDF to use NetworkPkg's fragment
>     file.
>   Platform/VExpressPkg: Update DSC/FDF to use NetworkPkg's include
>     fragment file.
>   Hisilicon/D03: Update DSC/FDF to use NetworkPkg's include fragment
>     file.
>   Hisilicon/D05: Update DSC/FDF to use NetworkPkg's include fragment
>     file.
>   Hisilicon/D06: Update DSC/FDF to use NetworkPkg's include fragment
>     file.
>   Hisilicon/HiKey: Update DSC/FDF to use NetworkPkg's include fragment
>     file.
>   Hisilicon/HiKey960: Update DSC/FDF to use NetworkPkg's include
>     fragment file.
>   Platform/CelloBoard: Update DSC/FDF to use NetworkPkg's include
>     fragment file.
>   Platform/DeveloperBox: Update DSC/FDF to use NetworkPkg's fragment
>     file.
>   Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg's
>     fragment file.
>   Platform/Overdrive1000Board: Update DSC/FDF to use NetworkPkg's
>     fragment file.
>   Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg's include
>     fragment file.
>   Platform/SgiPkg: Update FDF to use NetworkPkg's include fragment file.
>   Platform/RDKQemu: Update DSC to use NetworkPkg's include fragment
>     file.
>   Platform/Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg's
>     fragment file.
>   Platform/PurleyOpenBoardPkg: Update DSC/FDF to use NetworkPkg's
>     fragment file.
> 
>  .../AMD/OverdriveBoard/OverdriveBoard.dsc     | 29 +---------
>  .../AMD/OverdriveBoard/OverdriveBoard.fdf     | 23 +-------
>  Platform/ARM/SgiPkg/SgiPlatform.fdf           | 12 +---
>  .../ArmVExpress-networking.fdf.inc            | 12 +---
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc  | 26 +++------
>  Platform/Comcast/RDKQemu/RDKQemu.dsc          | 36 ++++--------
>  Platform/Hisilicon/D03/D03.dsc                | 26 ++++-----
>  Platform/Hisilicon/D03/D03.fdf                | 10 +---
>  Platform/Hisilicon/D05/D05.dsc                | 56 ++++++-------------
>  Platform/Hisilicon/D05/D05.fdf                | 23 +-------
>  Platform/Hisilicon/D06/D06.dsc                | 42 ++++----------
>  Platform/Hisilicon/D06/D06.fdf                | 27 +--------
>  Platform/Hisilicon/HiKey/HiKey.dsc            | 26 ++++-----
>  Platform/Hisilicon/HiKey/HiKey.fdf            | 10 +---
>  Platform/Hisilicon/HiKey960/HiKey960.dsc      | 25 ++++-----
>  Platform/Hisilicon/HiKey960/HiKey960.fdf      | 11 +---
>  .../Include/Dsc/CoreAdvancedDxeInclude.dsc    | 26 +--------
>  .../Include/Fdf/CoreAdvancedLateInclude.fdf   | 26 +--------
>  .../Include/Dsc/CoreCommonLib.dsc             | 11 ++--
>  .../BoardMtOlympus/PlatformPkg.dsc            |  6 ++
>  .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf   | 24 +-------
>  .../Vlv2TbltDevicePkg/PlatformPkgConfig.dsc   |  6 ++
>  .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf      | 24 +-------
>  .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc   | 43 +++-----------
>  .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc     | 39 ++-----------
>  .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc      | 42 ++------------
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc    | 28 +++-------
>  Platform/LeMaker/CelloBoard/CelloBoard.fdf    | 15 +----
>  .../Socionext/DeveloperBox/DeveloperBox.dsc   | 29 +++-------
>  .../Socionext/DeveloperBox/DeveloperBox.fdf   | 24 +-------
>  .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 35 +++---------
>  .../SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 21 +------
>  .../Overdrive1000Board/Overdrive1000Board.dsc | 27 +++------
>  .../Overdrive1000Board/Overdrive1000Board.fdf | 16 +-----
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 26 +++------
>  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf     | 12 +---
>  36 files changed, 178 insertions(+), 696 deletions(-)
> 
> -- 
> 2.18.0.windows.1
> 
> 
> 
>