From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=vl2eUS88; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Thu, 16 May 2019 13:30:17 -0700 Received: by mail-wr1-f68.google.com with SMTP id e15so4788254wrs.4 for ; Thu, 16 May 2019 13:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MXBTAzDBGLmI4IZECZXWdfcFnqzNXYZqale3GkuDN7k=; b=vl2eUS88rCaSfjYLDTvIgSXVjo7RKsCJjkQuDyOfZhJACtbP4BGSnUprOddyoNTi85 qJv7HKFdz8A86OuaeKnThGMitJGXcNhQrG9rNhgCgGmBaGYB4noShZpnxbh8nW2Dajis HoDdRLbXo9GqD4qCkt6x5kkH4pgty4t9Lzee42Rl1noGWMhPvM6ZDnkUd+4Mv5jtHWIL rrQ0/wt3ZSrF8X26sEOQqnEh19ykNBfvSH1LwNsN+xgHVhCeYZspWTTmSkQFy+wLeSSU MQe1dg5H9d00iSjtWM7MxfcdYPmotTwIk0OHmDbl0Nwemyn2iFyfsHX4aTIcMbSi8Xbe MjMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MXBTAzDBGLmI4IZECZXWdfcFnqzNXYZqale3GkuDN7k=; b=fQ2r9UifllhKXliJBOiRCnJ0W3FXOAPwXH8naOuiKQlji4aqeOhFRqtx60PDg5CBUM 4JprSjOeACG0MZtIxQMwndsttxjc8a/3TNfaY497BMO4yXdtg16SKz0Ur1ZLgIEioGMi m3DbOTuZCoRidUVn8Efi1vViRl1AggHPFCKl26Vn9b2mPc9JFDGlEqChYECQoL2k/blj Qpl5v903o5Ewz3KrOSa/ZoJ9Xy+8W6MDJYZuL/TkWMr0cA/0Ky5AAsB0t+UCTCdCzKun XTkMgG7MDpHKINYWIzXNCyNfnIp8cBCU/v/lV14IUW9/zTLachvWK2SVwtPAtJSa6SOd L6hQ== X-Gm-Message-State: APjAAAUbebtPHsr1nDoPlDYkpHQ9oP36CIX3XVUkolihwS82aTguDhYQ fBJRod+L5nUzPJPPDc6ER+h9iOPHz6k= X-Google-Smtp-Source: APXvYqwiKPT76zbHkWFRW7CU+MeTv/1OuvRYEiIOrUJy/9gWzIiQKVn4uk7lqW8DZV5zmQ3GWZRVsw== X-Received: by 2002:adf:8306:: with SMTP id 6mr19997830wrd.155.1558038614941; Thu, 16 May 2019 13:30:14 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z7sm4935587wme.26.2019.05.16.13.30.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 13:30:13 -0700 (PDT) Date: Thu, 16 May 2019 21:30:12 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF Message-ID: <20190516203012.um2iwhjhofqyylla@bivouac.eciton.net> References: <20190515085701.24724-1-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190515085701.24724-1-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Shenglei, I have now reviewed the patches that are mine to review. Many thanks for this bit of cleanup/standardisation. I would just like to raise one warning flag: These patches have been submitted without the Contributed-under tag. That means the series needs to either be held back until an overall repository license change happens, or v2 needs to be submitted with Contributed-under. Best Regards, Leif On Wed, May 15, 2019 at 04:56:45PM +0800, Zhang, Shenglei wrote: > We have plan to move all network related modules/libraries to > NetworkPkg. So in order to make these changes happen smoothly, > We update platforms' DSC/FDF to use Network's include segment files. > > Shenglei Zhang (16): > Platform/OverdriveBoard: Update DSC/FDF to use NetworkPkg's fragment > file. > Platform/VExpressPkg: Update DSC/FDF to use NetworkPkg's include > fragment file. > Hisilicon/D03: Update DSC/FDF to use NetworkPkg's include fragment > file. > Hisilicon/D05: Update DSC/FDF to use NetworkPkg's include fragment > file. > Hisilicon/D06: Update DSC/FDF to use NetworkPkg's include fragment > file. > Hisilicon/HiKey: Update DSC/FDF to use NetworkPkg's include fragment > file. > Hisilicon/HiKey960: Update DSC/FDF to use NetworkPkg's include > fragment file. > Platform/CelloBoard: Update DSC/FDF to use NetworkPkg's include > fragment file. > Platform/DeveloperBox: Update DSC/FDF to use NetworkPkg's fragment > file. > Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg's > fragment file. > Platform/Overdrive1000Board: Update DSC/FDF to use NetworkPkg's > fragment file. > Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg's include > fragment file. > Platform/SgiPkg: Update FDF to use NetworkPkg's include fragment file. > Platform/RDKQemu: Update DSC to use NetworkPkg's include fragment > file. > Platform/Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg's > fragment file. > Platform/PurleyOpenBoardPkg: Update DSC/FDF to use NetworkPkg's > fragment file. > > .../AMD/OverdriveBoard/OverdriveBoard.dsc | 29 +--------- > .../AMD/OverdriveBoard/OverdriveBoard.fdf | 23 +------- > Platform/ARM/SgiPkg/SgiPlatform.fdf | 12 +--- > .../ArmVExpress-networking.fdf.inc | 12 +--- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 26 +++------ > Platform/Comcast/RDKQemu/RDKQemu.dsc | 36 ++++-------- > Platform/Hisilicon/D03/D03.dsc | 26 ++++----- > Platform/Hisilicon/D03/D03.fdf | 10 +--- > Platform/Hisilicon/D05/D05.dsc | 56 ++++++------------- > Platform/Hisilicon/D05/D05.fdf | 23 +------- > Platform/Hisilicon/D06/D06.dsc | 42 ++++---------- > Platform/Hisilicon/D06/D06.fdf | 27 +-------- > Platform/Hisilicon/HiKey/HiKey.dsc | 26 ++++----- > Platform/Hisilicon/HiKey/HiKey.fdf | 10 +--- > Platform/Hisilicon/HiKey960/HiKey960.dsc | 25 ++++----- > Platform/Hisilicon/HiKey960/HiKey960.fdf | 11 +--- > .../Include/Dsc/CoreAdvancedDxeInclude.dsc | 26 +-------- > .../Include/Fdf/CoreAdvancedLateInclude.fdf | 26 +-------- > .../Include/Dsc/CoreCommonLib.dsc | 11 ++-- > .../BoardMtOlympus/PlatformPkg.dsc | 6 ++ > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 24 +------- > .../Vlv2TbltDevicePkg/PlatformPkgConfig.dsc | 6 ++ > .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 24 +------- > .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 43 +++----------- > .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 39 ++----------- > .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 42 ++------------ > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 28 +++------- > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 15 +---- > .../Socionext/DeveloperBox/DeveloperBox.dsc | 29 +++------- > .../Socionext/DeveloperBox/DeveloperBox.fdf | 24 +------- > .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 35 +++--------- > .../SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 21 +------ > .../Overdrive1000Board/Overdrive1000Board.dsc | 27 +++------ > .../Overdrive1000Board/Overdrive1000Board.fdf | 16 +----- > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 26 +++------ > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 12 +--- > 36 files changed, 178 insertions(+), 696 deletions(-) > > -- > 2.18.0.windows.1 > > > >