[PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[Ni, Ray]

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Maintainers.txt | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 7315241b6e..de0b6a284e 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -1,4 +1,4 @@
-EDK II Maintainers
+EDK II Maintainers
 ==================
 
 This file provides information about the primary maintainers for
@@ -185,11 +185,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
 M: Siyuan Fu <siyuan.fu@intel.com>
 M: Jiaxin Wu <jiaxin.wu@intel.com>
 
-Nt32Pkg
-W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
-M: Ray Ni <ray.ni@intel.com>
-M: Hao A Wu <hao.a.wu@intel.com>
-
 OvmfPkg
 W: http://www.tianocore.org/ovmf/
 M: Jordan Justen <jordan.l.justen@intel.com>
-- 
2.21.0.windows.1

Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[Liming Gao]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Ni, Ray
>Sent: Friday, May 17, 2019 12:58 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Andrew Fish <afish@apple.com>;
>Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>;
>Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is
>removed
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Ray Ni <ray.ni@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Andrew Fish <afish@apple.com>
>Cc: Laszlo Ersek <lersek@redhat.com>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>---
> Maintainers.txt | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/Maintainers.txt b/Maintainers.txt
>index 7315241b6e..de0b6a284e 100644
>--- a/Maintainers.txt
>+++ b/Maintainers.txt
>@@ -1,4 +1,4 @@
>-EDK II Maintainers
>+EDK II Maintainers
> ==================
>
> This file provides information about the primary maintainers for
>@@ -185,11 +185,6 @@ W:
>https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
> M: Siyuan Fu <siyuan.fu@intel.com>
> M: Jiaxin Wu <jiaxin.wu@intel.com>
>
>-Nt32Pkg
>-W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
>-M: Ray Ni <ray.ni@intel.com>
>-M: Hao A Wu <hao.a.wu@intel.com>
>-
> OvmfPkg
> W: http://www.tianocore.org/ovmf/
> M: Jordan Justen <jordan.l.justen@intel.com>
>--
>2.21.0.windows.1

Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[Leif Lindholm]

On Fri, May 17, 2019 at 12:57:35PM +0800, Ray Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Maintainers.txt | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7315241b6e..de0b6a284e 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,4 +1,4 @@
> -EDK II Maintainers
> +EDK II Maintainers
>  ==================
>  
>  This file provides information about the primary maintainers for
> @@ -185,11 +185,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
>  M: Siyuan Fu <siyuan.fu@intel.com>
>  M: Jiaxin Wu <jiaxin.wu@intel.com>
>  
> -Nt32Pkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
> -M: Ray Ni <ray.ni@intel.com>
> -M: Hao A Wu <hao.a.wu@intel.com>
> -
>  OvmfPkg
>  W: http://www.tianocore.org/ovmf/
>  M: Jordan Justen <jordan.l.justen@intel.com>
> -- 
> 2.21.0.windows.1
> 

Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[Ni, Ray]

Leif,
Thanks for your "Reviewed-by".
The Maintainers.txt change was pushed before I saw this mail.
Sorry that I missed your "Reviewed-by".

Thanks,
Ray

> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: Friday, May 17, 2019 4:44 PM
> To: Ni, Ray <ray.ni@intel.com>
> Cc: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Andrew
> Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after
> Nt32Pkg is removed
> 
> On Fri, May 17, 2019 at 12:57:35PM +0800, Ray Ni wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ray Ni <ray.ni@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> > ---
> >  Maintainers.txt | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt index
> > 7315241b6e..de0b6a284e 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -1,4 +1,4 @@
> > -EDK II Maintainers
> > +EDK II Maintainers
> >  ==================
> >
> >  This file provides information about the primary maintainers for @@
> > -185,11 +185,6 @@ W:
> > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
> >  M: Siyuan Fu <siyuan.fu@intel.com>
> >  M: Jiaxin Wu <jiaxin.wu@intel.com>
> >
> > -Nt32Pkg
> > -W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
> > -M: Ray Ni <ray.ni@intel.com>
> > -M: Hao A Wu <hao.a.wu@intel.com>
> > -
> >  OvmfPkg
> >  W: http://www.tianocore.org/ovmf/
> >  M: Jordan Justen <jordan.l.justen@intel.com>
> > --
> > 2.21.0.windows.1
> >

Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[Leif Lindholm]

No problem, I just wanted to make sure that if you were waiting for an
R-b from a steward, you had one.

Regards,

Leif

On Fri, May 17, 2019 at 09:00:43AM +0000, Ni, Ray wrote:
> Leif,
> Thanks for your "Reviewed-by".
> The Maintainers.txt change was pushed before I saw this mail.
> Sorry that I missed your "Reviewed-by".
> 
> Thanks,
> Ray
> 
> > -----Original Message-----
> > From: Leif Lindholm <leif.lindholm@linaro.org>
> > Sent: Friday, May 17, 2019 4:44 PM
> > To: Ni, Ray <ray.ni@intel.com>
> > Cc: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Andrew
> > Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>
> > Subject: Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after
> > Nt32Pkg is removed
> > 
> > On Fri, May 17, 2019 at 12:57:35PM +0800, Ray Ni wrote:
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Ray Ni <ray.ni@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Andrew Fish <afish@apple.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > 
> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > 
> > > ---
> > >  Maintainers.txt | 7 +------
> > >  1 file changed, 1 insertion(+), 6 deletions(-)
> > >
> > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > 7315241b6e..de0b6a284e 100644
> > > --- a/Maintainers.txt
> > > +++ b/Maintainers.txt
> > > @@ -1,4 +1,4 @@
> > > -EDK II Maintainers
> > > +EDK II Maintainers
> > >  ==================
> > >
> > >  This file provides information about the primary maintainers for @@
> > > -185,11 +185,6 @@ W:
> > > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
> > >  M: Siyuan Fu <siyuan.fu@intel.com>
> > >  M: Jiaxin Wu <jiaxin.wu@intel.com>
> > >
> > > -Nt32Pkg
> > > -W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
> > > -M: Ray Ni <ray.ni@intel.com>
> > > -M: Hao A Wu <hao.a.wu@intel.com>
> > > -
> > >  OvmfPkg
> > >  W: http://www.tianocore.org/ovmf/
> > >  M: Jordan Justen <jordan.l.justen@intel.com>
> > > --
> > > 2.21.0.windows.1
> > >

Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[Laszlo Ersek]

On 05/17/19 06:57, Ray Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7315241b6e..de0b6a284e 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,4 +1,4 @@
> -EDK II Maintainers
> +EDK II Maintainers

I'm commenting after the push, but:

why was the above line changed?

More precisely: *how* was it changed? (The diff doesn't indicate.)

... A-ha! Looking at the pushed commit
147e6e70f2be2d3fdebcb2bd366324a24634d562, I can tell. You added a BOM to
the beginning to the file.

Please send a new patch soon, to delete the BOM. (It's a bugfix so it is
suitable for the soft feature freeze.)

Thanks
Laszlo

>  ==================
>  
>  This file provides information about the primary maintainers for
> @@ -185,11 +185,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
>  M: Siyuan Fu <siyuan.fu@intel.com>
>  M: Jiaxin Wu <jiaxin.wu@intel.com>
>  
> -Nt32Pkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
> -M: Ray Ni <ray.ni@intel.com>
> -M: Hao A Wu <hao.a.wu@intel.com>
> -
>  OvmfPkg
>  W: http://www.tianocore.org/ovmf/
>  M: Jordan Justen <jordan.l.justen@intel.com>
> 

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

[Ni, Ray]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Friday, May 17, 2019 9:13 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Andrew Fish <afish@apple.com>;
> Leif Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Remove Nt32Pkg
> reference after Nt32Pkg is removed
> 
> On 05/17/19 06:57, Ray Ni wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ray Ni <ray.ni@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  Maintainers.txt | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt index
> > 7315241b6e..de0b6a284e 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -1,4 +1,4 @@
> > -EDK II Maintainers
> > +EDK II Maintainers
> 
> I'm commenting after the push, but:
> 
> why was the above line changed?
> 
> More precisely: *how* was it changed? (The diff doesn't indicate.)
> 
> ... A-ha! Looking at the pushed commit
> 147e6e70f2be2d3fdebcb2bd366324a24634d562, I can tell. You added a BOM
> to the beginning to the file.
> 
> Please send a new patch soon, to delete the BOM. (It's a bugfix so it is
> suitable for the soft feature freeze.)

I am a bit curious why I was that stupid to add a BOM in the beginning.
So I investigate further.
Root cause is below line contains a non-ASCII character that may cause
the editor I am using (not sure which one I used to edit the Maintainers.txt)
cleverly converts the file to UTF-8 with BOM.
R: Marc-André Lureau <marcandre.lureau@redhat.com>

I will submit another patch to convert the file to UTF-8 without BOM.

> 
> Thanks
> Laszlo
> 
> >  ==================
> >
> >  This file provides information about the primary maintainers for @@
> > -185,11 +185,6 @@ W:
> > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
> >  M: Siyuan Fu <siyuan.fu@intel.com>
> >  M: Jiaxin Wu <jiaxin.wu@intel.com>
> >
> > -Nt32Pkg
> > -W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
> > -M: Ray Ni <ray.ni@intel.com>
> > -M: Hao A Wu <hao.a.wu@intel.com>
> > -
> >  OvmfPkg
> >  W: http://www.tianocore.org/ovmf/
> >  M: Jordan Justen <jordan.l.justen@intel.com>
> >
> 
> 
>