public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Liming Gao <liming.gao@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [Patch 2/2] EmbeddedPkg: Update DSC to use NetworkPkg's include fragment file
Date: Fri, 17 May 2019 10:00:06 +0100	[thread overview]
Message-ID: <20190517090006.ko36fbne4vprai3w@bivouac.eciton.net> (raw)
In-Reply-To: <20190517085035.10772-3-liming.gao@intel.com>

On Fri, May 17, 2019 at 04:50:35PM +0800, Liming Gao wrote:
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> index b487337909..863bce3a19 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> @@ -96,7 +96,7 @@ [LibraryClasses.common]
>    SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
>  
>    # Networking Requirements
> -  NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> +  !include NetworkPkg/NetworkLibs.dsc.inc
>    HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>    UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
>  
> -- 
> 2.13.0.windows.1
> 

      reply	other threads:[~2019-05-17  9:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17  8:50 [Patch 0/2] Update Package DSC to use NetworkPkg's include fragment file Liming Gao
2019-05-17  8:50 ` [Patch 1/2] ShellPkg: Update " Liming Gao
2019-05-20  0:28   ` [edk2-devel] " Gao, Zhichao
2019-05-17  8:50 ` [Patch 2/2] EmbeddedPkg: " Liming Gao
2019-05-17  9:00   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517090006.ko36fbne4vprai3w@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox