From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=rI+RjWry; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Fri, 17 May 2019 09:03:02 -0700 Received: by mail-wr1-f65.google.com with SMTP id g12so7416085wro.8 for ; Fri, 17 May 2019 09:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yP1QR2z7ZRzszmX0pbmmBVIrBdglxldLqcb3cFeLv6c=; b=rI+RjWry6tkoiT/a7wiJYt6IrMMza2pCwzXzEBmG4NDguwgvwvF56gJq2JOjDV2z+U K5LDg7qw53v4Zgqx4O7qgDgc64BYVA03xkD8INAi7jSFseqyNLGj4LsYiqu4TGEOyjwD LJm7F0UA0QvR2aaNqZ76hBu6p6ZJ/uJCbBRYcmS4VnDyrPsp597yXHq76VkPCh3ceqV5 AIwdLpttchftgGbxDCML5pPCyEKha+IZkkP6NFbLmDNR2W/jTfxmvbn6lEbqBX4CyjjN zqat7/ILfftM9TaehlVK18PIsRWzarl0gB6pAbvZedmnR8wflx0Ohx8B6WlLXKwQ8tY+ rLSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yP1QR2z7ZRzszmX0pbmmBVIrBdglxldLqcb3cFeLv6c=; b=Jhnff6qbipgXKUXLYDAMgGy+wJDQUwRKJsIu2IYjTz1cr3c8pdcL2xUFen/dTXEsj4 N66PD4zYhfwuGBIDReVs9PbrkVSfM8Sd4ymH/VDt0SlCIpz3gR9rGF0JBLAGwhsVoV7p zwmNRT0MagRTUzHsfNf7bM9/zZ3u1H6IHVBfIOLIlbyBVcLW825ZeSxdNyOWW+aC9GFL /imxsacyo58hjtEMxGGRgJWL6jBaORoM2S790rNBlndbHNbEGPIARfv/i+gxPdHUTXAK bLDF/h6btbclGTHHuK35lYqdH8VI/Te/tcTzi917Nz9jqnF9IJYAORSmHD9dnuslLUzX JnFg== X-Gm-Message-State: APjAAAWwPCoyv6TY74zbIUtLm0l1MxExL6lvJuZYuPQF7E86ka/5fjgt /0bGRqAQIkDViOxn/VPdMFna2Q== X-Google-Smtp-Source: APXvYqxX5mY6ErSx1E0apxYmoNqItC+blbWl4nHGrDRt/lI9r1LgrPmMsDRIGASJ+t3icrV5L3Og0g== X-Received: by 2002:a5d:440a:: with SMTP id z10mr2519313wrq.157.1558108980311; Fri, 17 May 2019 09:03:00 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 130sm8595780wmd.15.2019.05.17.09.02.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 May 2019 09:02:58 -0700 (PDT) Date: Fri, 17 May 2019 17:02:57 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io , "Wu, Hao A" , Michael D Kinney Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 02/16] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg Message-ID: <20190517160257.7d4g2nj2gradcel7@bivouac.eciton.net> References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-5-hao.a.wu@intel.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 17, 2019 at 05:24:36PM +0200, Ard Biesheuvel wrote: > On Tue, 14 May 2019 at 04:08, Wu, Hao A wrote: > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 > > > > This commit will update the DSC file to consume the ReportStatusCodeLib > > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the > > one in IntelFrameworkModulePkg. > > > > Please note that, the DXE and Runtime ReportStatusCodeLib instances are > > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus, > > there is no functional impact for this commit. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Signed-off-by: Hao A Wu > > This platform does not have a status code router, so should we not > simply switch to BaseReportStatusCodeLibNull.inf here? Err, yeah, good point. Slight case of tunnel vision. / Leif > > --- > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > index 2d5d6f9977..8e8bb833ea 100644 > > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > @@ -163,7 +163,7 @@ > > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf > > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > # PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > > @@ -173,19 +173,19 @@ > > > > > > [LibraryClasses.common.DXE_DRIVER] > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > > > > [LibraryClasses.common.UEFI_APPLICATION] > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > > > > [LibraryClasses.common.UEFI_DRIVER] > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > @@ -193,7 +193,7 @@ > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > # PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > > PeCoffLib|BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf > > -- > > 2.12.0.windows.1 > > > > > > > >