From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Hao A Wu <hao.a.wu@intel.com>,
edk2-devel-groups-io <devel@edk2.groups.io>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-platforms][PATCH v1 14/16] Platform/LeMaker: Use ReportStatusCodeLib in MdeModulePkg
Date: Fri, 17 May 2019 17:04:21 +0100 [thread overview]
Message-ID: <20190517160421.memppzfzwlvz6rst@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu-8FYvHpeYL_-nZs3j5pQwR8KnTahJYvk9yJ7d1i74hOQ@mail.gmail.com>
On Fri, May 17, 2019 at 05:45:09PM +0200, Ard Biesheuvel wrote:
> On Tue, 14 May 2019 at 04:08, Hao A Wu <hao.a.wu@intel.com> wrote:
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
> >
> > This commit will update the DSC file to consume the ReportStatusCodeLib
> > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the
> > one in IntelFrameworkModulePkg.
> >
> > Please note that, the DXE and Runtime ReportStatusCodeLib instances are
> > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus,
> > there is no functional impact for this commit.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
>
> This platform does not have a status code router, so should we not
> simply switch to BaseReportStatusCodeLibNull.inf here?
Yeah.
/
Leif
> > ---
> > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> > index bb68763743..1eec89e088 100644
> > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> > @@ -194,12 +194,12 @@ DEFINE NUM_CORES = 4
> > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
> > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
> > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
> > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
> > PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
> >
> > [LibraryClasses.common.DXE_DRIVER]
> > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
> > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> > @@ -208,7 +208,7 @@ DEFINE NUM_CORES = 4
> > [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf
> > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> > !if $(TARGET) != RELEASE
> > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
> > @@ -221,7 +221,7 @@ DEFINE NUM_CORES = 4
> > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >
> > [LibraryClasses.common.UEFI_DRIVER]
> > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
> > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> > --
> > 2.12.0.windows.1
> >
next prev parent reply other threads:[~2019-05-17 16:04 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 2:08 [edk2-platforms][PATCH v1 00/16] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 01/16] Platform/AMD: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
2019-05-17 15:20 ` Ard Biesheuvel
2019-05-14 2:08 ` [PATCH 1/2] Platform/BeagleBoard: Use ReportStatusCodeLib " Wu, Hao A
2019-05-14 2:09 ` [edk2-devel] " Wu, Hao A
2019-05-14 15:13 ` Leif Lindholm
2019-05-15 0:30 ` [edk2-devel] " Wu, Hao A
2019-05-14 2:08 ` [PATCH 2/2] Platform/BeagleBoard: Drop the consume of PcdShellFile Wu, Hao A
2019-05-14 2:09 ` [edk2-devel] " Wu, Hao A
2019-05-14 15:13 ` Leif Lindholm
2019-05-17 15:25 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 02/16] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg Wu, Hao A
2019-05-15 19:44 ` [edk2-devel] " Leif Lindholm
2019-05-17 15:24 ` Ard Biesheuvel
2019-05-17 16:02 ` Leif Lindholm
2019-05-17 16:05 ` Ard Biesheuvel
2019-05-17 16:11 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 03/16] Platform/BeagleBoard: Drop the consume of PcdShellFile Wu, Hao A
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 04/16] Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
2019-05-17 15:26 ` [edk2-devel] " Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 05/16] Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib Wu, Hao A
2019-05-17 15:27 ` [edk2-devel] " Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 06/16] Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg Wu, Hao A
2019-05-15 19:47 ` Leif Lindholm
2019-05-17 15:33 ` Ard Biesheuvel
2019-05-20 8:49 ` [edk2-devel] " Wu, Hao A
2019-05-22 3:27 ` Ni, Ray
2019-05-27 12:11 ` ming.huang
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 07/16] Hisilicon/D06: Drop the consume of PcdShellFile Wu, Hao A
2019-05-17 15:34 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 08/16] Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
2019-05-17 15:37 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 09/16] Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) " Wu, Hao A
2019-05-15 19:48 ` [edk2-devel] " Leif Lindholm
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 10/16] Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) " Wu, Hao A
2019-05-17 15:41 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 11/16] Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency Wu, Hao A
2019-05-17 15:43 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 12/16] Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib Wu, Hao A
2019-05-17 15:43 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 13/16] Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
2019-05-17 15:44 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 14/16] Platform/LeMaker: Use ReportStatusCodeLib " Wu, Hao A
2019-05-15 19:51 ` Leif Lindholm
2019-05-17 15:45 ` Ard Biesheuvel
2019-05-17 16:04 ` Leif Lindholm [this message]
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 15/16] Platform/SoftIron: Use Lzma decompress lib " Wu, Hao A
2019-05-17 15:45 ` Ard Biesheuvel
2019-05-14 2:08 ` [edk2-platforms][PATCH v1 16/16] Platform/SoftIron: Use ReportStatusCodeLib " Wu, Hao A
2019-05-17 15:46 ` Ard Biesheuvel
2019-05-17 16:04 ` Leif Lindholm
2019-05-14 2:10 ` [edk2-devel] [edk2-platforms][PATCH v1 00/16] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
2019-05-15 20:01 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517160421.memppzfzwlvz6rst@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox