From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=laXGqTDL; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 17 May 2019 09:04:58 -0700 Received: by mail-wm1-f68.google.com with SMTP id 198so7441558wme.3 for ; Fri, 17 May 2019 09:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nvZwYmG1ZJERSIGenmLYrDA5aolPiKHlSe6jGh1KjXg=; b=laXGqTDLQvNkJ9kqSUXDXvBegcaCGuFBDSxHlhpmmoBCeX/3TxRCtX+YYfwO1rq5QK Y5b/OShfi6uNfQATGF6S9kKOCAUfwUPXIC9VkaJCvOTAp9y/PeXZicRr0HRHQHXpp6gh rchZ2CoS8S+T7guQfajrmSA2oJGhc+QkmDsleBygpTcschhxw3ILS5Khtnoi0JZmJQGh sz452S+v4ebgmVUKbI6Qq/x1xYzxsPF8/A1mEQyU1BLaC9k/HhU88t918R+D+d8LyrGf /S9Id7LcqI6CD0W8k2aH+a2uFgxfkXCDT3E0K0+zKULV+j/CkPB3VGFUebmBaDXpVsEd VCIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nvZwYmG1ZJERSIGenmLYrDA5aolPiKHlSe6jGh1KjXg=; b=Mz/IVcRfpanNl1i0fjW1drGzzeCpXPx+LR8WQeEQXVAJizze1M/OH0VXblr9LRHz5+ CM8EsNuDPDyKKjm+5eyTW3Cdty9ihJt+pmq+p2KC+dPh7TWq8H705oUdjDTA6icRZXiD 535NcrkuGArB5xTCpJK4e/h3aa1mbxIx7BUtwBfJ52TqsWftlK4PjKkN5PgQ0ZR75lLh pEXUDAirYtPgOlk3M9xqTRFq2rqVV4sFOO94QQcf9XPqw3evTwCnbjpDfAScRRjollUO W06Dqwq5C5cjXp1yQ/5L9/3kTLIo/57g45BeBbNSREi6gqbHw5ZnuoeZD8gIKZlVFu9A Pzyg== X-Gm-Message-State: APjAAAU1ThDpYQPn0Avd3WBKR87v1Qyz0mCzy3Uu2gAAxhx3FDrFNxh8 r7bCtqnOvxveAJYAoX+KtUB5qXAGyKw= X-Google-Smtp-Source: APXvYqzEYpUFV2fcPZRF7Qt8UX0jpTXLiXCGaaFgPPtZaP2Dkyez3ha7y0fipqk1k4D7RGixzdE/eg== X-Received: by 2002:a1c:e916:: with SMTP id q22mr2717401wmc.148.1558109096511; Fri, 17 May 2019 09:04:56 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h188sm14527225wmf.48.2019.05.17.09.04.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 May 2019 09:04:55 -0700 (PDT) Date: Fri, 17 May 2019 17:04:54 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: Hao A Wu , edk2-devel-groups-io , Michael D Kinney Subject: Re: [edk2-platforms][PATCH v1 16/16] Platform/SoftIron: Use ReportStatusCodeLib in MdeModulePkg Message-ID: <20190517160454.o4wwqfo5aig5zcel@bivouac.eciton.net> References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-19-hao.a.wu@intel.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 17, 2019 at 05:46:29PM +0200, Ard Biesheuvel wrote: > On Tue, 14 May 2019 at 04:09, Hao A Wu wrote: > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 > > > > This commit will update the DSC file to consume the ReportStatusCodeLib > > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the > > one in IntelFrameworkModulePkg. > > > > Please note that, the DXE and Runtime ReportStatusCodeLib instances are > > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus, > > there is no functional impact for this commit. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Signed-off-by: Hao A Wu > > This platform does not have a status code router, so should we not > simply switch to BaseReportStatusCodeLibNull.inf here? And again, yes. / Leif > > --- > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > index 6243d35ee6..a40cb6623f 100644 > > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > @@ -193,12 +193,12 @@ DEFINE NUM_CORES = 4 > > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf > > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > > PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf > > > > [LibraryClasses.common.DXE_DRIVER] > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > @@ -207,7 +207,7 @@ DEFINE NUM_CORES = 4 > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > !if $(TARGET) != RELEASE > > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > > @@ -220,7 +220,7 @@ DEFINE NUM_CORES = 4 > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > > > [LibraryClasses.common.UEFI_DRIVER] > > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > -- > > 2.12.0.windows.1 > >