* [edk2-platforms][PATCH v2 01/18] Platform/AMD: Use Lzma decompress lib in MdeModulePkg
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 02/18] Platform/BeagleBoard: Use ReportStatusCodeLib null instance Wu, Hao A
` (17 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the LzmaDecompressLib in
MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for this commit.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 5ba8e16a5a..46d2693c29 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -515,7 +515,7 @@ [Components.common]
MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
#
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 02/18] Platform/BeagleBoard: Use ReportStatusCodeLib null instance
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 01/18] Platform/AMD: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 03/18] Platform/BeagleBoard: Drop the consume of PcdShellFile Wu, Hao A
` (16 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Ard Biesheuvel, Leif Lindholm, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
Since there is no ReportStatusCodeRouter module used in the platform,
(The one implemented within EmbeddedPkg/Library/PrePiLib is never invoked)
this commit will update the DSC file to consume the ReportStatusCodeLib
null instance in MdePkg.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
index 2d5d6f9977..2c84891c98 100644
--- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -125,7 +125,7 @@ [LibraryClasses.common]
CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
# UiApp dependencies
- ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
+ ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf
FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
@@ -140,7 +140,6 @@ [LibraryClasses.common]
[LibraryClasses.common.SEC]
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
- ReportStatusCodeLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
@@ -157,13 +156,11 @@ [LibraryClasses.common.SEC]
[LibraryClasses.common.PEI_CORE]
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
- ReportStatusCodeLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
[LibraryClasses.common.DXE_CORE]
HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
# PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
@@ -173,19 +170,16 @@ [LibraryClasses.common.DXE_CORE]
[LibraryClasses.common.DXE_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
[LibraryClasses.common.UEFI_APPLICATION]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
[LibraryClasses.common.UEFI_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
@@ -193,7 +187,6 @@ [LibraryClasses.common.UEFI_DRIVER]
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
# PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
PeCoffLib|BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 03/18] Platform/BeagleBoard: Drop the consume of PcdShellFile
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 01/18] Platform/AMD: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 02/18] Platform/BeagleBoard: Use ReportStatusCodeLib null instance Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 04/18] Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
` (15 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
There is no module in the platform that will use
gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will
drop the consume of this PCD.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
index 2c84891c98..a32a924643 100644
--- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -327,9 +327,6 @@ [PcdsFixedAtBuild.common]
gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10
- # GUID of the UEFI Shell
- gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
-
# GUID of the UI app
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 04/18] Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (2 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 03/18] Platform/BeagleBoard: Drop the consume of PcdShellFile Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 05/18] Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib Wu, Hao A
` (14 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the LzmaDecompressLib in
MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for this commit.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/Hisilicon/D03/D03.dsc | 2 +-
Platform/Hisilicon/D05/D05.dsc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index 60b0d6393e..6309a0434c 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -310,7 +310,7 @@ [Components.common]
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
#
diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
index dc9e1407ba..51894d233b 100644
--- a/Platform/Hisilicon/D05/D05.dsc
+++ b/Platform/Hisilicon/D05/D05.dsc
@@ -446,7 +446,7 @@ [Components.common]
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
#
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 05/18] Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (3 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 04/18] Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg Wu, Hao A
` (13 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
Hisilicon platforms have already switched to the BDS driver in
MdeModulePkg by commit 5845a5cde9d6bd51d77067b2594654005887a434.
Thus, the consume of GenericBdsLib and PlatformBdsLib is no longer needed.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/Hisilicon/D03/D03.dsc | 2 --
Platform/Hisilicon/D05/D05.dsc | 2 --
Platform/Hisilicon/D06/D06.dsc | 1 -
3 files changed, 5 deletions(-)
diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index 6309a0434c..574636a059 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -59,8 +59,6 @@ [LibraryClasses.common]
OemAddressMapLib|Platform/Hisilicon/D03/Library/OemAddressMap2P/OemAddressMap2PHi1610.inf
PlatformSysCtrlLib|Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.inf
- GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
- PlatformBdsLib|Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
BmcConfigBootLib|Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
index 51894d233b..51e26681b2 100644
--- a/Platform/Hisilicon/D05/D05.dsc
+++ b/Platform/Hisilicon/D05/D05.dsc
@@ -73,8 +73,6 @@ [LibraryClasses.common]
OemAddressMapLib|Platform/Hisilicon/D05/Library/OemAddressMapD05/OemAddressMapD05.inf
PlatformSysCtrlLib|Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.inf
- GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
- PlatformBdsLib|Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
BmcConfigBootLib|Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
index 5387daf553..a4a813bec0 100644
--- a/Platform/Hisilicon/D06/D06.dsc
+++ b/Platform/Hisilicon/D06/D06.dsc
@@ -64,7 +64,6 @@ [LibraryClasses.common]
PlatformSysCtrlLib|Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
- GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
BmcConfigBootLib|Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (4 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 05/18] Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 07/18] Hisilicon/D06: Drop the consume of PcdShellFile Wu, Hao A
` (12 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Ard Biesheuvel, Leif Lindholm, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit adopts a similar approach to edk2 commit
a6d594c5fabd8da2273d2794826ec086cf9c3c04.
Currently, Hisilicon platforms use modules from under
"IntelFrameworkModulePkg/Universal/StatusCode/", which produce
EFI_PEI_PROGRESS_CODE_PPI and EFI_STATUS_CODE_PROTOCOL directly, and write
the status codes, as they are reported, to the serial port or to a memory
buffer. This is called "handling" the status codes.
MdeModulePkg offers a PEIM under
"MdeModulePkg/Universal/ReportStatusCodeRouter/Pei" that produces both
EFI_PEI_PROGRESS_CODE_PPI and EFI_PEI_RSC_HANDLER_PPI, and a runtime DXE
driver under "MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe"
that produces both EFI_STATUS_CODE_PROTOCOL and EFI_RSC_HANDLER_PROTOCOL.
MdeModulePkg also offers status code handler modules under
MdeModulePkg/Universal/StatusCodeHandler/ that depend on
EFI_PEI_RSC_HANDLER_PPI and EFI_RSC_HANDLER_PROTOCOL, respectively.
The StatusCodeHandler modules register themselves with
ReportStatusCodeRouter through EFI_PEI_RSC_HANDLER_PPI /
EFI_RSC_HANDLER_PROTOCOL. When another module reports a status code
through EFI_PEI_PROGRESS_CODE_PPI / EFI_STATUS_CODE_PROTOCOL, it reaches
the phase-matching ReportStatusCodeRouter module first, which in turn
passes the status code to the pre-registered, phase-matching
StatusCodeHandler module.
The status code handling in the StatusCodeHandler modules is identical to
the one currently provided by the IntelFrameworkModulePkg modules. Replace
the IntelFrameworkModulePkg modules with the MdeModulePkg ones, so we can
decrease our dependency on IntelFrameworkModulePkg.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
Platform/Hisilicon/D03/D03.dsc | 6 ++++--
Platform/Hisilicon/D05/D05.dsc | 6 ++++--
Platform/Hisilicon/D06/D06.dsc | 6 ++++--
Platform/Hisilicon/D03/D03.fdf | 6 ++++--
Platform/Hisilicon/D05/D05.fdf | 6 ++++--
Platform/Hisilicon/D06/D06.fdf | 6 ++++--
6 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index 574636a059..5e85069158 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -297,7 +297,8 @@ [Components.common]
Platform/Hisilicon/D03/MemoryInitPei/MemoryInitPeim.inf
ArmPkg/Drivers/CpuPei/CpuPei.inf
- IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf
+ MdeModulePkg/Universal/ReportStatusCodeRouter/Pei/ReportStatusCodeRouterPei.inf
+ MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf
MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
@@ -370,7 +371,8 @@ [Components.common]
ArmPkg/Drivers/TimerDxe/TimerDxe.inf
MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
- IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf
+ MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf
+ MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
#
#ACPI
#
diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
index 51e26681b2..ce58777cdd 100644
--- a/Platform/Hisilicon/D05/D05.dsc
+++ b/Platform/Hisilicon/D05/D05.dsc
@@ -433,7 +433,8 @@ [Components.common]
Platform/Hisilicon/D05/MemoryInitPei/MemoryInitPeim.inf
ArmPkg/Drivers/CpuPei/CpuPei.inf
- IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf
+ MdeModulePkg/Universal/ReportStatusCodeRouter/Pei/ReportStatusCodeRouterPei.inf
+ MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf
MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
@@ -503,7 +504,8 @@ [Components.common]
ArmPkg/Drivers/TimerDxe/TimerDxe.inf
MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
- IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf
+ MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf
+ MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
#
#ACPI
#
diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
index a4a813bec0..a2f2b911be 100644
--- a/Platform/Hisilicon/D06/D06.dsc
+++ b/Platform/Hisilicon/D06/D06.dsc
@@ -249,7 +249,8 @@ [Components.common]
ArmPlatformPkg/PlatformPei/PlatformPeim.inf
ArmPkg/Drivers/CpuPei/CpuPei.inf
- IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf
+ MdeModulePkg/Universal/ReportStatusCodeRouter/Pei/ReportStatusCodeRouterPei.inf
+ MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf
MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
@@ -311,7 +312,8 @@ [Components.common]
ArmPkg/Drivers/TimerDxe/TimerDxe.inf
MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
- IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf
+ MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf
+ MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
#
#ACPI
#
diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
index f5d0c66f63..327e1d0359 100644
--- a/Platform/Hisilicon/D03/D03.fdf
+++ b/Platform/Hisilicon/D03/D03.fdf
@@ -193,7 +193,8 @@ [FV.FvMain]
INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
INF FatPkg/EnhancedFatDxe/Fat.inf
INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
- INF IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf
+ INF MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf
+ INF MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
#
# Usb Support
@@ -323,7 +324,8 @@ [FV.FVMAIN_COMPACT]
INF Platform/Hisilicon/D03/MemoryInitPei/MemoryInitPeim.inf
INF ArmPkg/Drivers/CpuPei/CpuPei.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
- INF IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf
+ INF MdeModulePkg/Universal/ReportStatusCodeRouter/Pei/ReportStatusCodeRouterPei.inf
+ INF MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf
INF Platform/Hisilicon/D03/EarlyConfigPeim/EarlyConfigPeimD03.inf
INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf
index 812f7f2690..c9229a022f 100644
--- a/Platform/Hisilicon/D05/D05.fdf
+++ b/Platform/Hisilicon/D05/D05.fdf
@@ -197,7 +197,8 @@ [FV.FvMain]
INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
INF FatPkg/EnhancedFatDxe/Fat.inf
INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
- INF IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf
+ INF MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf
+ INF MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
#
# Usb Support
@@ -345,7 +346,8 @@ [FV.FVMAIN_COMPACT]
INF Platform/Hisilicon/D05/MemoryInitPei/MemoryInitPeim.inf
INF ArmPkg/Drivers/CpuPei/CpuPei.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
- INF IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf
+ INF MdeModulePkg/Universal/ReportStatusCodeRouter/Pei/ReportStatusCodeRouterPei.inf
+ INF MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf
INF Platform/Hisilicon/D05/EarlyConfigPeim/EarlyConfigPeimD05.inf
INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf
index 976b597647..cce2ee3775 100644
--- a/Platform/Hisilicon/D06/D06.fdf
+++ b/Platform/Hisilicon/D06/D06.fdf
@@ -198,7 +198,8 @@ [FV.FvMain]
INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
INF FatPkg/EnhancedFatDxe/Fat.inf
INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
- INF IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.inf
+ INF MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf
+ INF MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
#
# Usb Support
@@ -339,7 +340,8 @@ [FV.FVMAIN_COMPACT]
INF Platform/Hisilicon/D06/MemoryInitPei/MemoryInitPeim.inf
INF ArmPkg/Drivers/CpuPei/CpuPei.inf
INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
- INF IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf
+ INF MdeModulePkg/Universal/ReportStatusCodeRouter/Pei/ReportStatusCodeRouterPei.inf
+ INF MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf
INF Platform/Hisilicon/D06/EarlyConfigPeim/EarlyConfigPeimD06.inf
INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 07/18] Hisilicon/D06: Drop the consume of PcdShellFile
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (5 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 08/18] Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
` (11 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
After the drop of the consume of GenericBdsLib, there is no module that
will use gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This
commit will drop the consume of this PCD.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/Hisilicon/D06/D06.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
index a2f2b911be..b1a1943fce 100644
--- a/Platform/Hisilicon/D06/D06.dsc
+++ b/Platform/Hisilicon/D06/D06.dsc
@@ -181,7 +181,6 @@ [PcdsFixedAtBuild.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
- gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
gHisiTokenSpaceGuid.PcdSysControlBaseAddress|0x94010000
gHisiTokenSpaceGuid.PcdMailBoxAddress|0x0000FFF8
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 08/18] Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (6 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 07/18] Hisilicon/D06: Drop the consume of PcdShellFile Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 09/18] Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) " Wu, Hao A
` (10 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC.INC file to consume the LzmaDecompressLib
in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for this commit.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Silicon/Hisilicon/Hisilicon.dsc.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
index 7ce677b27e..c229274e3b 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -93,7 +93,7 @@ [LibraryClasses.common]
VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
- LzmaDecompressLib|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 09/18] Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (7 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 08/18] Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 10/18] Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) " Wu, Hao A
` (9 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Ard Biesheuvel, Leif Lindholm, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC.INC file to consume the
ReportStatusCodeLib (DXE phase instance) in MdeModulePkg, instead of using
the one in IntelFrameworkModulePkg.
Please note that, the difference between the 2 ReportStatusCodeLib are:
A. The MdeModulePkg one drops the support of
FRAMEWORK_EFI_RUNTIME_SERVICES;
B. The MdeModulePkg one adopts a fix to avoid using AllocatePool().
(edk2 commit c22f52c5e79b9782648576efb8382bb04da60b5b)
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
Silicon/Hisilicon/Hisilicon.dsc.inc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
index c229274e3b..d2d3e95d6a 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -164,13 +164,13 @@ [LibraryClasses.common.DXE_CORE]
HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
+ ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
[LibraryClasses.common.DXE_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
+ ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
@@ -187,7 +187,7 @@ [LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLICATION]
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
[LibraryClasses.common.UEFI_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
+ ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 10/18] Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in MdeModulePkg
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (8 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 09/18] Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) " Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 11/18] Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (8 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC.INC file to consume the DXE_RUNTIME_DRIVER
DebugLib instance in MdeModulePkg, instead of using the one in
IntelFrameworkModulePkg.
Please note that, the 2 DebugLib are almost identical. Thus, there is no
functional impact for this commit.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Silicon/Hisilicon/Hisilicon.dsc.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
index d2d3e95d6a..7bc965e973 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -199,7 +199,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
!ifndef CONFIG_NO_DEBUGLIB
- DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
!endif
!if $(TARGET) != RELEASE
DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 11/18] Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (9 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 10/18] Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) " Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 12/18] Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib Wu, Hao A
` (7 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
The below 3 Smbios drivers have dependency on IntelFramework[Module]Pkg:
* MemorySubClassDxe
* ProcessorSubClassDxe
* SmbiosMiscDxe
Their dependency is on the header file:
IntelFrameworkPkg/Include/FrameworkDxe.h
for definition 'STRING_REF'. This definition can be replaced by
'EFI_STRING_ID', which is defined within MdePkg.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.inf | 2 --
Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 1 -
Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 2 --
Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 1 -
Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 4 +---
Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 4 ++--
Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 4 ++--
Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 4 ++--
Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 2 +-
Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c | 4 ++--
10 files changed, 10 insertions(+), 18 deletions(-)
diff --git a/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.inf
index 973b917e3b..67b9af5a81 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.inf
+++ b/Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.inf
@@ -22,8 +22,6 @@ [Sources]
[Packages]
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
- IntelFrameworkPkg/IntelFrameworkPkg.dec
- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
Silicon/Hisilicon/HisiliconNonOsi.dec
Silicon/Hisilicon/HisiPkg.dec
diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
index 94a753a044..99eea93b79 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
+++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
@@ -24,7 +24,6 @@ [Packages]
ArmPkg/ArmPkg.dec
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
- IntelFrameworkPkg/IntelFrameworkPkg.dec
Silicon/Hisilicon/HisiliconNonOsi.dec
Silicon/Hisilicon/HisiPkg.dec
diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
index 002b462d51..9c795b5fd4 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
+++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
@@ -51,8 +51,6 @@ [Packages]
ArmPkg/ArmPkg.dec
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
- IntelFrameworkPkg/IntelFrameworkPkg.dec
- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
Silicon/Hisilicon/HisiliconNonOsi.dec
Silicon/Hisilicon/HisiPkg.dec
diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
index 416a6e88f1..4692eb7133 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
+++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
@@ -19,7 +19,6 @@ Based on files under Nt32Pkg/MiscSubClassPlatformDxe/
#ifndef _SMBIOS_MISC_DRIVER_H
#define _SMBIOS_MISC_DRIVER_H
-#include <FrameworkDxe.h>
#include <Protocol/Smbios.h>
#include <IndustryStandard/SmBios.h>
#include <Library/HiiLib.h>
diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
index 75af47b330..647632f15a 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
+++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
@@ -9,8 +9,6 @@
#include "ProcessorSubClass.h"
-#include <FrameworkDxe.h>
-
EFI_HII_HANDLE mHiiHandle;
EFI_SMBIOS_PROTOCOL *mSmbios;
@@ -481,7 +479,7 @@ AddSmbiosProcessorTypeTable (
PROCESSOR_CHARACTERISTICS_DATA ProcessorCharacteristics = {{0}};
CHAR16 *CpuVersion;
- STRING_REF TokenToUpdate;
+ EFI_STRING_ID TokenToUpdate;
UINT64 *ProcessorId;
Type4Record = NULL;
diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
index 78bc096004..b62ec1dd8f 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
+++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c
@@ -122,8 +122,8 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscBiosVendor)
CHAR16 *ReleaseDate;
CHAR16 *Char16String;
EFI_STATUS Status;
- STRING_REF TokenToUpdate;
- STRING_REF TokenToGet;
+ EFI_STRING_ID TokenToUpdate;
+ EFI_STRING_ID TokenToGet;
SMBIOS_TABLE_TYPE0 *SmbiosRecord;
EFI_SMBIOS_HANDLE SmbiosHandle;
SMBIOS_TABLE_TYPE0 *InputData;
diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
index 9f6c406543..f829b09d9c 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
+++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c
@@ -46,12 +46,12 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscSystemManufacturer)
EFI_STRING SerialNumber;
EFI_STRING SKUNumber;
EFI_STRING Family;
- STRING_REF TokenToGet;
+ EFI_STRING_ID TokenToGet;
EFI_SMBIOS_HANDLE SmbiosHandle;
SMBIOS_TABLE_TYPE1 *SmbiosRecord;
SMBIOS_TABLE_TYPE1 *InputData;
EFI_STATUS Status;
- STRING_REF TokenToUpdate;
+ EFI_STRING_ID TokenToUpdate;
CHAR16 *Product;
CHAR16 *pVersion;
diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
index 76fa1ccc7f..3834bf93f7 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
+++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c
@@ -48,13 +48,13 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscBaseBoardManufacturer)
EFI_STRING SerialNumber;
EFI_STRING AssetTag;
EFI_STRING ChassisLocation;
- STRING_REF TokenToGet;
+ EFI_STRING_ID TokenToGet;
EFI_SMBIOS_HANDLE SmbiosHandle;
SMBIOS_TABLE_TYPE2 *SmbiosRecord;
SMBIOS_TABLE_TYPE2 *InputData = NULL;
EFI_STATUS Status;
- STRING_REF TokenToUpdate;
+ EFI_STRING_ID TokenToUpdate;
//CHAR16 *ProductName;
//CHAR16 *pVersion;
//uniBIOS_y00216284_018_end 2015-1-13 09:08:22
diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
index 79795ad1e4..ec00e1cd10 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
+++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
@@ -61,7 +61,7 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscChassisManufacturer)
EFI_STRING SerialNumber;
EFI_STRING AssertTag;
EFI_STRING ChassisSkuNumber;
- STRING_REF TokenToGet;
+ EFI_STRING_ID TokenToGet;
EFI_SMBIOS_HANDLE SmbiosHandle;
SMBIOS_TABLE_TYPE3 *SmbiosRecord;
SMBIOS_TABLE_TYPE3 *InputData;
diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c
index e921155ad1..ca1a7a2c00 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c
+++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c
@@ -23,7 +23,7 @@ UpdateSlotDesignation (
IN SMBIOS_TABLE_TYPE9 *InputData
)
{
- STRING_REF TokenToUpdate;
+ EFI_STRING_ID TokenToUpdate;
CHAR16 *SlotDesignation;
UINTN DesignationStrLen;
@@ -134,7 +134,7 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscSystemSlotDesignation)
UINTN SlotDesignationStrLen;
EFI_STATUS Status;
EFI_STRING SlotDesignation;
- STRING_REF TokenToGet;
+ EFI_STRING_ID TokenToGet;
SMBIOS_TABLE_TYPE9 *SmbiosRecord;
EFI_SMBIOS_HANDLE SmbiosHandle;
SMBIOS_TABLE_TYPE9 *InputData = NULL;
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 12/18] Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (10 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 11/18] Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency Wu, Hao A
@ 2019-05-20 8:40 ` Wu, Hao A
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 13/18] Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
` (6 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:40 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
Hisilicon platforms have already switched to the BDS driver in
MdeModulePkg by commit 5845a5cde9d6bd51d77067b2594654005887a434.
Thus, the Hisilicon PlatformBdsLib is no longer needed. This commit will
remove this library instance implementation.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 77 --
Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h | 55 --
Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h | 21 -
Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 957 --------------------
Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c | 112 ---
5 files changed, 1222 deletions(-)
diff --git a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf b/Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
deleted file mode 100644
index 0aa50e51db..0000000000
--- a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
+++ /dev/null
@@ -1,77 +0,0 @@
-## @file
-# Implementation for PlatformBdsLib library class interfaces.
-#
-# Copyright (C) 2015, Red Hat, Inc.
-# Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
-# Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
-# Copyright (c) 2015, Hisilicon Limited. All rights reserved.
-# Copyright (c) 2015, Linaro Limited. All rights reserved.
-#
-# SPDX-License-Identifier: BSD-2-Clause-Patent
-#
-# Based on the files under ArmVirtPkg/Library/PlatformIntelBdsLib/
-#
-##
-
-[Defines]
- INF_VERSION = 0x00010005
- BASE_NAME = PlatformIntelBdsLib
- FILE_GUID = 46DF84EB-F603-4D39-99D8-E1E86B50BCC2
- MODULE_TYPE = DXE_DRIVER
- VERSION_STRING = 1.0
- LIBRARY_CLASS = PlatformBdsLib|DXE_DRIVER
-
-#
-# The following information is for reference only and not required by the build tools.
-#
-# VALID_ARCHITECTURES = ARM AARCH64
-#
-
-[Sources]
- IntelBdsPlatform.c
- IntelBdsPlatformCommon.c
-
-[Packages]
- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
- MdeModulePkg/MdeModulePkg.dec
- MdePkg/MdePkg.dec
- Silicon/Hisilicon/HisiPkg.dec
-
-[LibraryClasses]
- BaseLib
- BaseMemoryLib
- DebugLib
- DevicePathLib
- GenericBdsLib
- IpmiCmdLib
- MemoryAllocationLib
- PcdLib
- PrintLib
- UefiBootServicesTableLib
- UefiRuntimeServicesTableLib
- UefiLib
-
-[FixedPcd]
- gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile
- gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate
- gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits
- gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity
- gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits
-
-[Pcd]
- gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut
-
-[Guids]
- gEfiEndOfDxeEventGroupGuid
- gEfiEventReadyToBootGuid
- gEfiFileInfoGuid
- gEfiFileSystemInfoGuid
- gEfiFileSystemVolumeLabelInfoIdGuid
-
-[Protocols]
- gEfiDevicePathProtocolGuid
- gEfiDevicePathToTextProtocolGuid
- gEfiGraphicsOutputProtocolGuid
- gEfiLoadedImageProtocolGuid
- gEfiPciRootBridgeIoProtocolGuid
- gEfiSimpleFileSystemProtocolGuid
diff --git a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h b/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
deleted file mode 100644
index 3347acc48f..0000000000
--- a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
+++ /dev/null
@@ -1,55 +0,0 @@
-/** @file
- Head file for BDS Platform specific code
-
- Copyright (c) 2004 - 2008, Intel Corporation. All rights reserved.<BR>
- Copyright (c) 2015, Hisilicon Limited. All rights reserved.<BR>
- Copyright (c) 2015, Linaro Limited. All rights reserved.<BR>
-
- SPDX-License-Identifier: BSD-2-Clause-Patent
-
- Based on the files under ArmVirtPkg/Library/PlatformIntelBdsLib/
-
-**/
-
-#ifndef _INTEL_BDS_PLATFORM_H_
-#define _INTEL_BDS_PLATFORM_H_
-
-#include <Library/BaseLib.h>
-#include <Library/BaseMemoryLib.h>
-#include <Library/DebugLib.h>
-#include <Library/DevicePathLib.h>
-#include <Library/MemoryAllocationLib.h>
-#include <Library/UefiBootServicesTableLib.h>
-#include <Library/UefiRuntimeServicesTableLib.h>
-
-#include "IntelBdsPlatformCommon.h"
-
-VOID
-PlatformBdsEnterFrontPage (
- IN UINT16 TimeoutDefault,
- IN BOOLEAN ConnectAllHappened
- );
-
-/**
- Download the kernel, the initial ramdisk, and the kernel command line from
- QEMU's fw_cfg. Construct a minimal SimpleFileSystem that contains the two
- image files, and load and start the kernel from it.
-
- The kernel will be instructed via its command line to load the initrd from
- the same Simple FileSystem.
-
- @retval EFI_NOT_FOUND Kernel image was not found.
- @retval EFI_OUT_OF_RESOURCES Memory allocation failed.
- @retval EFI_PROTOCOL_ERROR Unterminated kernel command line.
-
- @return Error codes from any of the underlying
- functions. On success, the function doesn't
- return.
-**/
-EFI_STATUS
-EFIAPI
-TryRunningQemuKernel (
- VOID
- );
-
-#endif // _INTEL_BDS_PLATFORM_H
diff --git a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h b/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
deleted file mode 100644
index 02114eda29..0000000000
--- a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
+++ /dev/null
@@ -1,21 +0,0 @@
-/** @file
-*
-* Copyright (c) 2015, Hisilicon Limited. All rights reserved.
-* Copyright (c) 2015, Linaro Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
-**/
-
-#ifndef _HW_BDS_LIB_H_
-#define _HW_BDS_LIB_H_
-
-EFI_STATUS
-EFIAPI
-HwBdsLibRegisterAppBootOption (
- IN OUT LIST_ENTRY *BdsBootOptionList,
- IN GUID *FileGuid,
- IN CHAR16 *Description
- );
-
-#endif
diff --git a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c b/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
deleted file mode 100644
index 803148ebb3..0000000000
--- a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
+++ /dev/null
@@ -1,957 +0,0 @@
-/** @file
- Implementation for PlatformBdsLib library class interfaces.
-
- Copyright (C) 2015, Red Hat, Inc.
- Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
- Copyright (c) 2004 - 2008, Intel Corporation. All rights reserved.<BR>
- Copyright (c) 2015, Hisilicon Limited. All rights reserved.
- Copyright (c) 2015, Linaro Limited. All rights reserved.
-
- SPDX-License-Identifier: BSD-2-Clause-Patent
-
- Based on the files under ArmVirtPkg/Library/PlatformIntelBdsLib/
-
-**/
-
-#include <IndustryStandard/Pci22.h>
-#include <Library/DevicePathLib.h>
-#include <Library/GenericBdsLib.h>
-#include <Library/IpmiCmdLib.h>
-#include <Library/PcdLib.h>
-#include <Library/PlatformBdsLib.h>
-#include <Library/PrintLib.h>
-#include <Library/UefiLib.h>
-#include <Protocol/DevicePath.h>
-#include <Protocol/DevicePathToText.h>
-#include <Protocol/GraphicsOutput.h>
-#include <Protocol/PciIo.h>
-#include <Protocol/PciRootBridgeIo.h>
-#include <Guid/GlobalVariable.h>
-
-#include "IntelBdsPlatform.h"
-
-GUID gOemBootVaraibleGuid = {0xb7784577, 0x5aaf, 0x4557, {0xa1, 0x99,
- 0xd4, 0xa4, 0x2f, 0x45, 0x06, 0xf8} };
-
-//3CEF354A-3B7A-4519-AD70-72A134698311
-GUID gEblFileGuid = {0x3CEF354A, 0x3B7A, 0x4519, {0xAD, 0x70,
- 0x72, 0xA1, 0x34, 0x69, 0x83, 0x11} };
-
-// Need to keep the same with FlashStartOs.inf
-// 282cae50-940e-11e5-b7b8-774201c0f2d8
-GUID gFlashStartOsAppGuid = { 0x282cae50, 0x940e, 0x11e5, {0xb7, 0xb8,
- 0x77, 0x42, 0x01, 0xc0, 0xf2, 0xd8} };
-
-// Need to keep the same with EslStartOs.inf
-// 8880a72c-9411-11e5-b6f0-97310bc151d1
-GUID gEslStartOsAppGuid = { 0x8880a72c, 0x9411, 0x11e5, {0xb6, 0xf0,
- 0x97, 0x31, 0x0b, 0xc1, 0x51, 0xd1} };
-
-EFI_STATUS
-BdsDeleteAllInvalidEfiBootOption (
- VOID
- );
-
-#define DP_NODE_LEN(Type) { (UINT8)sizeof (Type), (UINT8)(sizeof (Type) >> 8) }
-
-
-#pragma pack (1)
-typedef struct {
- VENDOR_DEVICE_PATH SerialDxe;
- UART_DEVICE_PATH Uart;
- VENDOR_DEFINED_DEVICE_PATH Vt100;
- EFI_DEVICE_PATH_PROTOCOL End;
-} PLATFORM_SERIAL_CONSOLE;
-#pragma pack ()
-
-#define SERIAL_DXE_FILE_GUID { \
- 0xD3987D4B, 0x971A, 0x435F, \
- { 0x8C, 0xAF, 0x49, 0x67, 0xEB, 0x62, 0x72, 0x41 } \
- }
-
-STATIC PLATFORM_SERIAL_CONSOLE mSerialConsole = {
- //
- // VENDOR_DEVICE_PATH SerialDxe
- //
- {
- { HARDWARE_DEVICE_PATH, HW_VENDOR_DP, DP_NODE_LEN (VENDOR_DEVICE_PATH) },
- SERIAL_DXE_FILE_GUID
- },
-
- //
- // UART_DEVICE_PATH Uart
- //
- {
- { MESSAGING_DEVICE_PATH, MSG_UART_DP, DP_NODE_LEN (UART_DEVICE_PATH) },
- 0, // Reserved
- FixedPcdGet64 (PcdUartDefaultBaudRate), // BaudRate
- FixedPcdGet8 (PcdUartDefaultDataBits), // DataBits
- FixedPcdGet8 (PcdUartDefaultParity), // Parity
- FixedPcdGet8 (PcdUartDefaultStopBits) // StopBits
- },
-
- //
- // VENDOR_DEFINED_DEVICE_PATH Vt100
- //
- {
- {
- MESSAGING_DEVICE_PATH, MSG_VENDOR_DP,
- DP_NODE_LEN (VENDOR_DEFINED_DEVICE_PATH)
- },
- EFI_VT_100_GUID
- },
-
- //
- // EFI_DEVICE_PATH_PROTOCOL End
- //
- {
- END_DEVICE_PATH_TYPE, END_ENTIRE_DEVICE_PATH_SUBTYPE,
- DP_NODE_LEN (EFI_DEVICE_PATH_PROTOCOL)
- }
-};
-
-
-#pragma pack (1)
-typedef struct {
- USB_CLASS_DEVICE_PATH Keyboard;
- EFI_DEVICE_PATH_PROTOCOL End;
-} PLATFORM_USB_KEYBOARD;
-#pragma pack ()
-
-STATIC PLATFORM_USB_KEYBOARD mUsbKeyboard = {
- //
- // USB_CLASS_DEVICE_PATH Keyboard
- //
- {
- {
- MESSAGING_DEVICE_PATH, MSG_USB_CLASS_DP,
- DP_NODE_LEN (USB_CLASS_DEVICE_PATH)
- },
- 0xFFFF, // VendorId: any
- 0xFFFF, // ProductId: any
- 3, // DeviceClass: HID
- 1, // DeviceSubClass: boot
- 1 // DeviceProtocol: keyboard
- },
-
- //
- // EFI_DEVICE_PATH_PROTOCOL End
- //
- {
- END_DEVICE_PATH_TYPE, END_ENTIRE_DEVICE_PATH_SUBTYPE,
- DP_NODE_LEN (EFI_DEVICE_PATH_PROTOCOL)
- }
-};
-
-STATIC
-UINT16
-GetBBSTypeFromFileSysPath (
- IN CHAR16 *UsbPathTxt,
- IN CHAR16 *FileSysPathTxt,
- IN EFI_DEVICE_PATH_PROTOCOL *FileSysPath
- )
-{
- EFI_DEVICE_PATH_PROTOCOL *Node;
-
- if (StrnCmp (UsbPathTxt, FileSysPathTxt, StrLen (UsbPathTxt)) == 0) {
- Node = FileSysPath;
- while (!IsDevicePathEnd (Node)) {
- if ((DevicePathType (Node) == MEDIA_DEVICE_PATH) &&
- (DevicePathSubType (Node) == MEDIA_CDROM_DP)) {
- return BBS_TYPE_CDROM;
- }
- Node = NextDevicePathNode (Node);
- }
- }
-
- return BBS_TYPE_UNKNOWN;
-}
-
-STATIC
-UINT16
-GetBBSTypeFromUsbPath (
- IN CONST EFI_DEVICE_PATH_PROTOCOL *UsbPath
- )
-{
- EFI_STATUS Status;
- EFI_HANDLE *FileSystemHandles;
- UINTN NumberFileSystemHandles;
- UINTN Index;
- EFI_DEVICE_PATH_PROTOCOL *FileSysPath;
- EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *DevPathToText;
- CHAR16 *UsbPathTxt;
- CHAR16 *FileSysPathTxt;
- UINT16 Result;
-
- Status = gBS->LocateProtocol (&gEfiDevicePathToTextProtocolGuid, NULL, (VOID **) &DevPathToText);
- if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "Locate DevicePathToTextPro %r\n", Status));
- return BBS_TYPE_UNKNOWN;
- }
-
- Result = BBS_TYPE_UNKNOWN;
- UsbPathTxt = DevPathToText->ConvertDevicePathToText (UsbPath, TRUE, TRUE);
- if (UsbPathTxt == NULL) {
- return Result;
- }
-
- Status = gBS->LocateHandleBuffer (
- ByProtocol,
- &gEfiSimpleFileSystemProtocolGuid,
- NULL,
- &NumberFileSystemHandles,
- &FileSystemHandles
- );
- if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "Locate SimpleFileSystemProtocol error(%r)\n", Status));
- FreePool (UsbPathTxt);
- return BBS_TYPE_UNKNOWN;
- }
-
- for (Index = 0; Index < NumberFileSystemHandles; Index++) {
- FileSysPath = DevicePathFromHandle (FileSystemHandles[Index]);
- FileSysPathTxt = DevPathToText->ConvertDevicePathToText (FileSysPath, TRUE, TRUE);
-
- if (FileSysPathTxt == NULL) {
- continue;
- }
-
- Result = GetBBSTypeFromFileSysPath (UsbPathTxt, FileSysPathTxt, FileSysPath);
- FreePool (FileSysPathTxt);
-
- if (Result != BBS_TYPE_UNKNOWN) {
- break;
- }
- }
-
- if (NumberFileSystemHandles != 0) {
- FreePool (FileSystemHandles);
- }
-
- FreePool (UsbPathTxt);
-
- return Result;
-}
-
-STATIC
-UINT16
-GetBBSTypeFromMessagingDevicePath (
- IN EFI_DEVICE_PATH_PROTOCOL *DevicePath,
- IN EFI_DEVICE_PATH_PROTOCOL *Node
- )
-{
- VENDOR_DEVICE_PATH *Vendor;
- UINT16 Result;
-
- Result = BBS_TYPE_UNKNOWN;
-
- switch (DevicePathSubType (Node)) {
- case MSG_MAC_ADDR_DP:
- Result = BBS_TYPE_EMBEDDED_NETWORK;
- break;
-
- case MSG_USB_DP:
- Result = GetBBSTypeFromUsbPath (DevicePath);
- if (Result == BBS_TYPE_UNKNOWN) {
- Result = BBS_TYPE_USB;
- }
- break;
-
- case MSG_SATA_DP:
- Result = BBS_TYPE_HARDDRIVE;
- break;
-
- case MSG_VENDOR_DP:
- Vendor = (VENDOR_DEVICE_PATH *) (Node);
- if ((&Vendor->Guid) != NULL) {
- if (CompareGuid (&Vendor->Guid, &((EFI_GUID) DEVICE_PATH_MESSAGING_SAS))) {
- Result = BBS_TYPE_HARDDRIVE;
- }
- }
- break;
-
- default:
- Result = BBS_TYPE_UNKNOWN;
- break;
- }
-
- return Result;
-}
-
-STATIC
-UINT16
-GetBBSTypeByDevicePath (
- IN EFI_DEVICE_PATH_PROTOCOL *DevicePath
- )
-{
- EFI_DEVICE_PATH_PROTOCOL *Node;
- UINT16 Result;
-
- Result = BBS_TYPE_UNKNOWN;
- if (DevicePath == NULL) {
- return Result;
- }
-
- Node = DevicePath;
- while (!IsDevicePathEnd (Node)) {
- switch (DevicePathType (Node)) {
- case MEDIA_DEVICE_PATH:
- if (DevicePathSubType (Node) == MEDIA_CDROM_DP) {
- Result = BBS_TYPE_CDROM;
- }
- break;
-
- case MESSAGING_DEVICE_PATH:
- Result = GetBBSTypeFromMessagingDevicePath (DevicePath, Node);
- break;
-
- default:
- Result = BBS_TYPE_UNKNOWN;
- break;
- }
-
- if (Result != BBS_TYPE_UNKNOWN) {
- break;
- }
-
- Node = NextDevicePathNode (Node);
- }
-
- return Result;
-}
-
-STATIC
-EFI_STATUS
-GetBmcBootOptionsSetting (
- OUT IPMI_GET_BOOT_OPTION *BmcBootOpt
- )
-{
- EFI_STATUS Status;
-
- Status = IpmiCmdGetSysBootOptions (BmcBootOpt);
- if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "Get iBMC BootOpts %r!\n", Status));
- return Status;
- }
-
- if (BmcBootOpt->BootFlagsValid != BOOT_OPTION_BOOT_FLAG_VALID) {
- return EFI_NOT_FOUND;
- }
-
- if (BmcBootOpt->Persistent) {
- BmcBootOpt->BootFlagsValid = BOOT_OPTION_BOOT_FLAG_VALID;
- } else {
- BmcBootOpt->BootFlagsValid = BOOT_OPTION_BOOT_FLAG_INVALID;
- }
-
- Status = IpmiCmdSetSysBootOptions (BmcBootOpt);
- if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "Set iBMC BootOpts %r!\n", Status));
- }
-
- return Status;
-}
-
-STATIC
-VOID
-RestoreBootOrder (
- VOID
- )
-{
- EFI_STATUS Status;
- UINT16 *BootOrder;
- UINTN BootOrderSize;
-
- GetVariable2 (L"BootOrderBackup", &gOemBootVaraibleGuid, (VOID **) &BootOrder, &BootOrderSize);
- if (BootOrder == NULL) {
- return ;
- }
-
- Print (L"Restore BootOrder(%d).\n", BootOrderSize / sizeof (UINT16));
-
- Status = gRT->SetVariable (
- L"BootOrder",
- &gEfiGlobalVariableGuid,
- EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_NON_VOLATILE,
- BootOrderSize,
- BootOrder
- );
- if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "SetVariable BootOrder %r!\n", Status));
- }
-
- Status = gRT->SetVariable (
- L"BootOrderBackup",
- &gOemBootVaraibleGuid,
- EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE,
- 0,
- NULL
- );
- if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "SetVariable BootOrderBackup %r!\n", Status));
- }
-
- FreePool (BootOrder);
-
- return;
-}
-
-
-VOID
-RestoreBootOrderOnReadyToBoot (
- IN EFI_EVENT Event,
- IN VOID *Context
- )
-{
- // restore BootOrder variable in normal condition.
- RestoreBootOrder ();
-}
-
-STATIC
-VOID
-UpdateBootOrder (
- IN UINT16 *NewOrder,
- IN UINT16 *BootOrder,
- IN UINTN BootOrderSize
- )
-{
- EFI_STATUS Status;
- EFI_EVENT Event;
-
- Status = gRT->SetVariable (
- L"BootOrderBackup",
- &gOemBootVaraibleGuid,
- EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE,
- BootOrderSize,
- BootOrder
- );
- if (EFI_ERROR (Status)) {
- return;
- }
-
- Status = gRT->SetVariable (
- L"BootOrder",
- &gEfiGlobalVariableGuid,
- EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_NON_VOLATILE,
- BootOrderSize,
- NewOrder
- );
- if (EFI_ERROR (Status)) {
- return;
- }
-
- // Register notify function to restore BootOrder variable on ReadyToBoot Event.
- Status = gBS->CreateEventEx (
- EVT_NOTIFY_SIGNAL,
- TPL_CALLBACK,
- RestoreBootOrderOnReadyToBoot,
- NULL,
- &gEfiEventReadyToBootGuid,
- &Event
- );
- if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "Create ready to boot event %r!\n", Status));
- }
-
- return;
-}
-
-STATIC
-VOID
-SetBootOrder (
- IN UINT16 BootType
- )
-{
- UINT16 *NewOrder;
- UINT16 *RemainBoots;
- UINT16 *BootOrder;
- UINTN BootOrderSize;
- CHAR16 OptionName[sizeof ("Boot####")];
- UINTN Index;
- LIST_ENTRY BootOptionList;
- BDS_COMMON_OPTION *Option;
- UINTN SelectCnt;
- UINTN RemainCnt;
-
- InitializeListHead (&BootOptionList);
-
- GetEfiGlobalVariable2 (L"BootOrder", (VOID **) &BootOrder, &BootOrderSize);
- if (BootOrder == NULL) {
- return ;
- }
-
- NewOrder = AllocatePool (BootOrderSize);
- RemainBoots = AllocatePool (BootOrderSize);
- if ((NewOrder == NULL) || (RemainBoots == NULL)) {
- DEBUG ((DEBUG_ERROR, "Out of resources."));
- goto Exit;
- }
-
- SelectCnt = 0;
- RemainCnt = 0;
-
- for (Index = 0; Index < BootOrderSize / sizeof (UINT16); Index++) {
- UnicodeSPrint (OptionName, sizeof (OptionName), L"Boot%04x", BootOrder[Index]);
- Option = BdsLibVariableToOption (&BootOptionList, OptionName);
- if (Option == NULL) {
- DEBUG ((DEBUG_ERROR, "Boot%04x is invalid option!\n", BootOrder[Index]));
- continue;
- }
-
- if (GetBBSTypeByDevicePath (Option->DevicePath) == BootType) {
- NewOrder[SelectCnt++] = BootOrder[Index];
- } else {
- RemainBoots[RemainCnt++] = BootOrder[Index];
- }
- }
-
- if (SelectCnt != 0) {
- // append RemainBoots to NewOrder
- for (Index = 0; Index < RemainCnt; Index++) {
- NewOrder[SelectCnt + Index] = RemainBoots[Index];
- }
-
- if (CompareMem (NewOrder, BootOrder, BootOrderSize) != 0) {
- UpdateBootOrder (NewOrder, BootOrder, BootOrderSize);
- }
- }
-
-Exit:
- FreePool (BootOrder);
- if (NewOrder != NULL) {
- FreePool (NewOrder);
- }
- if (RemainBoots != NULL) {
- FreePool (RemainBoots);
- }
-
- return ;
-}
-
-STATIC
-VOID
-HandleBmcBootType (
- VOID
- )
-{
- EFI_STATUS Status;
- IPMI_GET_BOOT_OPTION BmcBootOpt;
- UINT16 BootType;
-
- Status = GetBmcBootOptionsSetting (&BmcBootOpt);
- if (EFI_ERROR (Status)) {
- return;
- }
-
- Print (L"Boot Type from BMC is %x\n", BmcBootOpt.BootDeviceSelector);
-
- switch (BmcBootOpt.BootDeviceSelector) {
- case ForcePxe:
- BootType = BBS_TYPE_EMBEDDED_NETWORK;
- break;
-
- case ForcePrimaryRemovableMedia:
- BootType = BBS_TYPE_USB;
- break;
-
- case ForceDefaultHardDisk:
- BootType = BBS_TYPE_HARDDRIVE;
- break;
-
- case ForceDefaultCD:
- BootType = BBS_TYPE_CDROM;
- break;
-
- default:
- return;
- }
-
- SetBootOrder (BootType);
-}
-
-//
-// BDS Platform Functions
-//
-/**
- Platform Bds init. Include the platform firmware vendor, revision
- and so crc check.
-
-**/
-VOID
-EFIAPI
-PlatformBdsInit (
- VOID
- )
-{
- //Signal EndofDxe Event
- EfiEventGroupSignal(&gEfiEndOfDxeEventGroupGuid);
-
- // restore BootOrder variable if previous BMC boot override attempt
- // left it in a modified state
- RestoreBootOrder ();
-}
-
-
-/**
- Check if the handle satisfies a particular condition.
-
- @param[in] Handle The handle to check.
- @param[in] ReportText A caller-allocated string passed in for reporting
- purposes. It must never be NULL.
-
- @retval TRUE The condition is satisfied.
- @retval FALSE Otherwise. This includes the case when the condition could not
- be fully evaluated due to an error.
-**/
-typedef
-BOOLEAN
-(EFIAPI *FILTER_FUNCTION) (
- IN EFI_HANDLE Handle,
- IN CONST CHAR16 *ReportText
- );
-
-
-/**
- Process a handle.
-
- @param[in] Handle The handle to process.
- @param[in] ReportText A caller-allocated string passed in for reporting
- purposes. It must never be NULL.
-**/
-typedef
-VOID
-(EFIAPI *CALLBACK_FUNCTION) (
- IN EFI_HANDLE Handle,
- IN CONST CHAR16 *ReportText
- );
-
-/**
- Locate all handles that carry the specified protocol, filter them with a
- callback function, and pass each handle that passes the filter to another
- callback.
-
- @param[in] ProtocolGuid The protocol to look for.
-
- @param[in] Filter The filter function to pass each handle to. If this
- parameter is NULL, then all handles are processed.
-
- @param[in] Process The callback function to pass each handle to that
- clears the filter.
-**/
-STATIC
-VOID
-FilterAndProcess (
- IN EFI_GUID *ProtocolGuid,
- IN FILTER_FUNCTION Filter OPTIONAL,
- IN CALLBACK_FUNCTION Process
- )
-{
- EFI_STATUS Status;
- EFI_HANDLE *Handles;
- UINTN NoHandles;
- UINTN Idx;
-
- Status = gBS->LocateHandleBuffer (ByProtocol, ProtocolGuid,
- NULL /* SearchKey */, &NoHandles, &Handles);
- if (EFI_ERROR (Status)) {
- //
- // This is not an error, just an informative condition.
- //
- DEBUG ((EFI_D_VERBOSE, "%a: %g: %r\n", __FUNCTION__, ProtocolGuid,
- Status));
- return;
- }
-
- ASSERT (NoHandles > 0);
- for (Idx = 0; Idx < NoHandles; ++Idx) {
- CHAR16 *DevicePathText;
- STATIC CHAR16 Fallback[] = L"<device path unavailable>";
-
- //
- // The ConvertDevicePathToText() function handles NULL input transparently.
- //
- DevicePathText = ConvertDevicePathToText (
- DevicePathFromHandle (Handles[Idx]),
- FALSE, // DisplayOnly
- FALSE // AllowShortcuts
- );
- if (DevicePathText == NULL) {
- DevicePathText = Fallback;
- }
-
- if (Filter == NULL || Filter (Handles[Idx], DevicePathText)) {
- Process (Handles[Idx], DevicePathText);
- }
-
- if (DevicePathText != Fallback) {
- FreePool (DevicePathText);
- }
- }
- gBS->FreePool (Handles);
-}
-
-
-/**
- This FILTER_FUNCTION checks if a handle corresponds to a PCI display device.
-**/
-STATIC
-BOOLEAN
-EFIAPI
-IsPciDisplay (
- IN EFI_HANDLE Handle,
- IN CONST CHAR16 *ReportText
- )
-{
- EFI_STATUS Status;
- EFI_PCI_IO_PROTOCOL *PciIo;
- PCI_TYPE00 Pci;
-
- Status = gBS->HandleProtocol (Handle, &gEfiPciIoProtocolGuid,
- (VOID**)&PciIo);
- if (EFI_ERROR (Status)) {
- //
- // This is not an error worth reporting.
- //
- return FALSE;
- }
-
- Status = PciIo->Pci.Read (PciIo, EfiPciIoWidthUint32, 0 /* Offset */,
- sizeof Pci / sizeof (UINT32), &Pci);
- if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_ERROR, "%a: %s: %r\n", __FUNCTION__, ReportText, Status));
- return FALSE;
- }
-
- return IS_PCI_DISPLAY (&Pci);
-}
-
-
-/**
- This CALLBACK_FUNCTION attempts to connect a handle non-recursively, asking
- the matching driver to produce all first-level child handles.
-**/
-STATIC
-VOID
-EFIAPI
-Connect (
- IN EFI_HANDLE Handle,
- IN CONST CHAR16 *ReportText
- )
-{
- EFI_STATUS Status;
-
- Status = gBS->ConnectController (
- Handle, // ControllerHandle
- NULL, // DriverImageHandle
- NULL, // RemainingDevicePath -- produce all children
- FALSE // Recursive
- );
- DEBUG ((EFI_ERROR (Status) ? EFI_D_ERROR : EFI_D_VERBOSE, "%a: %s: %r\n",
- __FUNCTION__, ReportText, Status));
-}
-
-
-/**
- This CALLBACK_FUNCTION retrieves the EFI_DEVICE_PATH_PROTOCOL from the
- handle, and adds it to ConOut and ErrOut.
-**/
-STATIC
-VOID
-EFIAPI
-AddOutput (
- IN EFI_HANDLE Handle,
- IN CONST CHAR16 *ReportText
- )
-{
- EFI_STATUS Status;
- EFI_DEVICE_PATH_PROTOCOL *DevicePath;
-
- DevicePath = DevicePathFromHandle (Handle);
- if (DevicePath == NULL) {
- DEBUG ((EFI_D_ERROR, "%a: %s: handle %p: device path not found\n",
- __FUNCTION__, ReportText, Handle));
- return;
- }
-
- Status = BdsLibUpdateConsoleVariable (L"ConOut", DevicePath, NULL);
- if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_ERROR, "%a: %s: adding to ConOut: %r\n", __FUNCTION__,
- ReportText, Status));
- return;
- }
-
- Status = BdsLibUpdateConsoleVariable (L"ErrOut", DevicePath, NULL);
- if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_ERROR, "%a: %s: adding to ErrOut: %r\n", __FUNCTION__,
- ReportText, Status));
- return;
- }
-
- DEBUG ((EFI_D_VERBOSE, "%a: %s: added to ConOut and ErrOut\n", __FUNCTION__,
- ReportText));
-}
-
-
-/**
- The function will execute with as the platform policy, current policy
- is driven by boot mode. IBV/OEM can customize this code for their specific
- policy action.
-
- @param DriverOptionList The header of the driver option link list
- @param BootOptionList The header of the boot option link list
- @param ProcessCapsules A pointer to ProcessCapsules()
- @param BaseMemoryTest A pointer to BaseMemoryTest()
-
-**/
-VOID
-EFIAPI
-PlatformBdsPolicyBehavior (
- IN LIST_ENTRY *DriverOptionList,
- IN LIST_ENTRY *BootOptionList,
- IN PROCESS_CAPSULES ProcessCapsules,
- IN BASEM_MEMORY_TEST BaseMemoryTest
- )
-{
- EFI_STATUS Status;
- //
- // Locate the PCI root bridges and make the PCI bus driver connect each,
- // non-recursively. This will produce a number of child handles with PciIo on
- // them.
- //
- FilterAndProcess (&gEfiPciRootBridgeIoProtocolGuid, NULL, Connect);
-
- //
- // Find all display class PCI devices (using the handles from the previous
- // step), and connect them non-recursively. This should produce a number of
- // child handles with GOPs on them.
- //
- FilterAndProcess (&gEfiPciIoProtocolGuid, IsPciDisplay, Connect);
-
- //
- // Now add the device path of all handles with GOP on them to ConOut and
- // ErrOut.
- //
- FilterAndProcess (&gEfiGraphicsOutputProtocolGuid, NULL, AddOutput);
-
- //
- // Add the hardcoded short-form USB keyboard device path to ConIn.
- //
- BdsLibUpdateConsoleVariable (L"ConIn",
- (EFI_DEVICE_PATH_PROTOCOL *)&mUsbKeyboard, NULL);
-
- //
- // Add the hardcoded serial console device path to ConIn, ConOut, ErrOut.
- //
- BdsLibUpdateConsoleVariable (L"ConIn",
- (EFI_DEVICE_PATH_PROTOCOL *)&mSerialConsole, NULL);
- BdsLibUpdateConsoleVariable (L"ConOut",
- (EFI_DEVICE_PATH_PROTOCOL *)&mSerialConsole, NULL);
- BdsLibUpdateConsoleVariable (L"ErrOut",
- (EFI_DEVICE_PATH_PROTOCOL *)&mSerialConsole, NULL);
-
- //
- // Connect the consoles based on the above variables.
- //
- BdsLibConnectAllDefaultConsoles ();
-
- //
- // Show the splash screen.
- //
- EnableQuietBoot (PcdGetPtr (PcdLogoFile));
-
- //
- // Connect the rest of the devices.
- //
- BdsLibConnectAll ();
-
- //
- // Add memory test to convert memory above 4GB to be tested
- //
- Status = BaseMemoryTest (QUICK);
- if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_ERROR, "[%a:%d] - Base memory test failed: %r\n", __FUNCTION__, __LINE__, Status));
- }
-
- //
- // Process QEMU's -kernel command line option. Note that the kernel booted
- // this way should receive ACPI tables, which is why we connect all devices
- // first (see above) -- PCI enumeration blocks ACPI table installation, if
- // there is a PCI host.
- //
- //TryRunningQemuKernel ();
-
- BdsLibEnumerateAllBootOption (BootOptionList);
-
- // Add Flash Start OS and ESL Start OS boot option
- (VOID) HwBdsLibRegisterAppBootOption (BootOptionList, &gFlashStartOsAppGuid, L"Flash Start OS");
- (VOID) HwBdsLibRegisterAppBootOption (BootOptionList, &gEslStartOsAppGuid, L"ESL Start OS");
-
- // Add EBL as boot option
- (VOID) HwBdsLibRegisterAppBootOption (BootOptionList, &gEblFileGuid, L"Embedded Boot Loader (EBL)");
-
- // Remove EFI Misc Device Boot Options
- BdsDeleteAllInvalidEfiBootOption ();
-
- //SetBootOrderFromQemu (BootOptionList);
- //
- // The BootOrder variable may have changed, reload the in-memory list with
- // it.
- //
- BdsLibBuildOptionFromVar (BootOptionList, L"BootOrder");
-
- //PlatformBdsEnterFrontPage (GetFrontPageTimeoutFromQemu(), TRUE);
- Print (L"Press Enter to boot OS immediately.\n");
- Print (L"Press any other key in %d seconds to stop automatical booting...\n", PcdGet16(PcdPlatformBootTimeOut));
- PlatformBdsEnterFrontPage (PcdGet16(PcdPlatformBootTimeOut), TRUE);
- HandleBmcBootType ();
-}
-
-/**
- Hook point after a boot attempt succeeds. We don't expect a boot option to
- return, so the UEFI 2.0 specification defines that you will default to an
- interactive mode and stop processing the BootOrder list in this case. This
- is also a platform implementation and can be customized by IBV/OEM.
-
- @param Option Pointer to Boot Option that succeeded to boot.
-
-**/
-VOID
-EFIAPI
-PlatformBdsBootSuccess (
- IN BDS_COMMON_OPTION *Option
- )
-{
-}
-
-/**
- Hook point after a boot attempt fails.
-
- @param Option Pointer to Boot Option that failed to boot.
- @param Status Status returned from failed boot.
- @param ExitData Exit data returned from failed boot.
- @param ExitDataSize Exit data size returned from failed boot.
-
-**/
-VOID
-EFIAPI
-PlatformBdsBootFail (
- IN BDS_COMMON_OPTION *Option,
- IN EFI_STATUS Status,
- IN CHAR16 *ExitData,
- IN UINTN ExitDataSize
- )
-{
-}
-
-/**
- This function locks platform flash that is not allowed to be updated during normal boot path.
- The flash layout is platform specific.
-**/
-VOID
-EFIAPI
-PlatformBdsLockNonUpdatableFlash (
- VOID
- )
-{
- return;
-}
diff --git a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c b/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
deleted file mode 100644
index 35996322ed..0000000000
--- a/Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
+++ /dev/null
@@ -1,112 +0,0 @@
-/** @file
-*
-* Copyright (c) 2015, Hisilicon Limited. All rights reserved.
-* Copyright (c) 2015, Linaro Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
-**/
-
-#include "IntelBdsPlatform.h"
-#include <Library/UefiLib.h>
-#include <Library/GenericBdsLib.h>
-#include <Protocol/FirmwareVolume2.h>
-
-VOID
-EFIAPI
-BdsLibBuildOptionFromApp (
- IN EFI_HANDLE Handle,
- IN OUT LIST_ENTRY *BdsBootOptionList,
- IN GUID *FileGuid,
- IN CHAR16 *Description
- )
-{
- EFI_DEVICE_PATH_PROTOCOL *DevicePath;
- MEDIA_FW_VOL_FILEPATH_DEVICE_PATH ShellNode;
-
- DevicePath = DevicePathFromHandle (Handle);
-
- //
- // Build the shell device path
- //
- EfiInitializeFwVolDevicepathNode (&ShellNode, FileGuid);
-
- DevicePath = AppendDevicePathNode (DevicePath, (EFI_DEVICE_PATH_PROTOCOL *) &ShellNode);
-
- //
- // Create and register the shell boot option
- //
- BdsLibRegisterNewOption (BdsBootOptionList, DevicePath, Description, L"BootOrder");
-
-}
-EFI_STATUS
-EFIAPI
-HwBdsLibRegisterAppBootOption (
- IN OUT LIST_ENTRY *BdsBootOptionList,
- IN GUID *FileGuid,
- IN CHAR16 *Description
- )
-{
- EFI_STATUS Status;
- UINTN Index;
- UINTN FvHandleCount;
- EFI_HANDLE *FvHandleBuffer;
- EFI_FV_FILETYPE Type;
- UINTN Size;
- EFI_FV_FILE_ATTRIBUTES Attributes;
- UINT32 AuthenticationStatus;
- EFI_FIRMWARE_VOLUME2_PROTOCOL *Fv;
- UINTN Count = 0;
-
- //
- // Check if we have on flash shell
- //
- gBS->LocateHandleBuffer (
- ByProtocol,
- &gEfiFirmwareVolume2ProtocolGuid,
- NULL,
- &FvHandleCount,
- &FvHandleBuffer
- );
- for (Index = 0; Index < FvHandleCount; Index++) {
- gBS->HandleProtocol (
- FvHandleBuffer[Index],
- &gEfiFirmwareVolume2ProtocolGuid,
- (VOID **) &Fv
- );
-
- Status = Fv->ReadFile (
- Fv,
- FileGuid,
- NULL,
- &Size,
- &Type,
- &Attributes,
- &AuthenticationStatus
- );
- if (EFI_ERROR (Status)) {
- //
- // Skip if no shell file in the FV
- //
- continue;
- }
- //
- // Build the shell boot option
- //
- BdsLibBuildOptionFromApp (FvHandleBuffer[Index], BdsBootOptionList,
- FileGuid, Description);
-
- Count++;
- }
-
- if (FvHandleCount != 0) {
- FreePool (FvHandleBuffer);
- }
-
- if (Count == 0) {
- return EFI_NOT_FOUND;
- }
-
- return EFI_SUCCESS;
-}
-
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 13/18] Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (11 preceding siblings ...)
2019-05-20 8:40 ` [edk2-platforms][PATCH v2 12/18] Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib Wu, Hao A
@ 2019-05-20 8:41 ` Wu, Hao A
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 14/18] Platform/LeMaker: Use ReportStatusCodeLib null instance Wu, Hao A
` (5 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:41 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the LzmaDecompressLib in
MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for this commit.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index 525276a2b0..d86e09008a 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -469,7 +469,7 @@ [Components.common]
MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
#
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 14/18] Platform/LeMaker: Use ReportStatusCodeLib null instance
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (12 preceding siblings ...)
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 13/18] Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
@ 2019-05-20 8:41 ` Wu, Hao A
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 15/18] Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
` (4 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:41 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Ard Biesheuvel, Leif Lindholm, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
Since there is no ReportStatusCodeRouter module used in the platform,
this commit will update the DSC file to consume the ReportStatusCodeLib
null instance in MdePkg.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index d86e09008a..394a213fd5 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -39,6 +39,7 @@ [LibraryClasses.common]
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
+ ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
@@ -163,7 +164,6 @@ [LibraryClasses.common.PEI_CORE]
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
- ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
@@ -176,7 +176,6 @@ [LibraryClasses.common.PEIM]
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
- ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
@@ -188,12 +187,10 @@ [LibraryClasses.common.DXE_CORE]
HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
[LibraryClasses.common.DXE_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
@@ -202,7 +199,6 @@ [LibraryClasses.common.DXE_DRIVER]
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
!if $(TARGET) != RELEASE
DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
@@ -212,10 +208,8 @@ [LibraryClasses.common.UEFI_APPLICATION]
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
- ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
[LibraryClasses.common.UEFI_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 15/18] Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (13 preceding siblings ...)
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 14/18] Platform/LeMaker: Use ReportStatusCodeLib null instance Wu, Hao A
@ 2019-05-20 8:41 ` Wu, Hao A
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 16/18] Platform/SoftIron: Use ReportStatusCodeLib null instance Wu, Hao A
` (3 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:41 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
This commit will update the DSC file to consume the LzmaDecompressLib in
MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
functional impact for this commit.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index d74ad479af..ba493ac8a3 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -455,7 +455,7 @@ [Components.common]
MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
#
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 16/18] Platform/SoftIron: Use ReportStatusCodeLib null instance
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (14 preceding siblings ...)
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 15/18] Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg Wu, Hao A
@ 2019-05-20 8:41 ` Wu, Hao A
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 17/18] Platform/RPi3: " Wu, Hao A
` (2 subsequent siblings)
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:41 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Ard Biesheuvel, Leif Lindholm, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
Since there is no ReportStatusCodeRouter module used in the platform,
this commit will update the DSC file to consume the ReportStatusCodeLib
null instance in MdePkg.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index ba493ac8a3..18b05e88a9 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -39,6 +39,7 @@ [LibraryClasses.common]
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
+ ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
@@ -161,7 +162,6 @@ [LibraryClasses.common.PEI_CORE]
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
- ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
@@ -175,7 +175,6 @@ [LibraryClasses.common.PEIM]
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
- ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
@@ -187,12 +186,10 @@ [LibraryClasses.common.DXE_CORE]
HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
[LibraryClasses.common.DXE_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
@@ -201,7 +198,6 @@ [LibraryClasses.common.DXE_DRIVER]
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
!if $(TARGET) != RELEASE
DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
@@ -211,10 +207,8 @@ [LibraryClasses.common.UEFI_APPLICATION]
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
- ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
[LibraryClasses.common.UEFI_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 17/18] Platform/RPi3: Use ReportStatusCodeLib null instance
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (15 preceding siblings ...)
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 16/18] Platform/SoftIron: Use ReportStatusCodeLib null instance Wu, Hao A
@ 2019-05-20 8:41 ` Wu, Hao A
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 18/18] Platform/RaspberryPi: Drop the consume of PcdShellFile Wu, Hao A
2019-05-27 2:43 ` [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:41 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Ard Biesheuvel, Leif Lindholm, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
Since there is no ReportStatusCodeRouter module used in the platform,
(The one implemented within EmbeddedPkg/Library/PrePiLib is never invoked)
this commit will update the DSC file to consume the ReportStatusCodeLib
null instance in MdePkg.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 53b87ba4e5..e958d71425 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -50,6 +50,7 @@ [LibraryClasses.common]
BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf
SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
+ ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
@@ -171,12 +172,10 @@ [LibraryClasses.common.DXE_CORE]
HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
[LibraryClasses.common.DXE_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
@@ -187,17 +186,14 @@ [LibraryClasses.common.UEFI_APPLICATION]
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
- ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
[LibraryClasses.common.UEFI_DRIVER]
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
EfiResetSystemLib|Platform/RaspberryPi/$(PLATFORM_NAME)/Library/ResetLib/ResetLib.inf
ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* [edk2-platforms][PATCH v2 18/18] Platform/RaspberryPi: Drop the consume of PcdShellFile
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (16 preceding siblings ...)
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 17/18] Platform/RPi3: " Wu, Hao A
@ 2019-05-20 8:41 ` Wu, Hao A
2019-05-27 2:43 ` [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
18 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-05-20 8:41 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Ard Biesheuvel, Leif Lindholm, Michael D Kinney
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
There is no module in the platform that will use
gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will
drop the consume of this PCD.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index e958d71425..af7ae0dafc 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -380,7 +380,6 @@ [PcdsFixedAtBuild.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
- gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"Raspberry Pi 3 64-bit UEFI"
gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency
2019-05-20 8:40 [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
` (17 preceding siblings ...)
2019-05-20 8:41 ` [edk2-platforms][PATCH v2 18/18] Platform/RaspberryPi: Drop the consume of PcdShellFile Wu, Hao A
@ 2019-05-27 2:43 ` Wu, Hao A
2019-06-10 5:13 ` Wu, Hao A
18 siblings, 1 reply; 25+ messages in thread
From: Wu, Hao A @ 2019-05-27 2:43 UTC (permalink / raw)
To: devel@edk2.groups.io, Ard Biesheuvel, Leif Lindholm
Cc: Kinney, Michael D, Andrew Fish, Laszlo Ersek, Ni, Ray,
guoheyi@huawei.com
Hello Ard and Leif,
Do you have comments on this series?
Also, for the below patch to Hisilicon platforms:
[PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
it is suggested to be verified on actual hardware:
https://edk2.groups.io/g/devel/topic/31614327#41188
However, it seems that there is no accessible hardware for such verification
at this moment. Do you think it is fine to push this change anyway?
(Also CCed the stewards here for comments.)
Best Regards,
Hao Wu
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Monday, May 20, 2019 4:41 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D
> Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> IntelFramework[Module]Pkg dependency
>
> The series is also available at:
> https://github.com/hwu25/edk2-
> platforms/commits/drop_intelframework_v2
>
> V2 changes:
> A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board, update
> their DSC file to consume the null ReportStatusCodeLib in MdePkg. The
> change is done since these platforms do not have a StatusCode Router
> module;
> B. Add the change for platform RaspberryPi/RPi3 to drop its dependency on
> the framework packages;
> C. Update the commit log message for patch
> 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg'
> to better reflect the commit impact.
>
>
> This series will drop the IntelFramework[Module]Pkg dependency for
> platforms within the edk2-platforms repo.
> packages.
>
> Tests done for the series:
> Platforms build verified with GCC5 toolchain:
> * Platform/AMD/OverdriveBoard
> * Platform/ARM/JunoPkg
> * Platform/ARM/SgiPkg
> * Platform/ARM/VExpressPkg
> * Platform/BeagleBoard
> * Platform/Hisilicon/D0x
> * Platform/Hisilicon/HiKey
> * Platform/Hisilicon/HiKey960
> * Platform/LeMaker/CelloBoard
> * Platform/Marvell/Armada70x0Db (only AARCH64)
> * Platform/Marvell/Armada80x0Db (only AARCH64)
> * Platform/RaspberryPi/RPi3
> * Platform/Socionext/DeveloperBox
> * Platform/Socionext/SynQuacerEvalBoard (only AARCH64)
> * Platform/SoftIron/Overdrive1000Board
> * Platform/SolidRun/Armada80x0McBin (only AARCH64)
>
> Platforms originally cannot be built via GCC5 toolchain (thus, not
> verified):
> * Platform/Comcast/RDKQemu (ARM, AARCH64)
> * Platform/Marvell/Armada70x0Db (ARM)
> * Platform/Marvell/Armada80x0Db (ARM)
> * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64)
> * Platform/SolidRun/Armada80x0McBin (ARM)
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> Hao A Wu (18):
> Platform/AMD: Use Lzma decompress lib in MdeModulePkg
> Platform/BeagleBoard: Use ReportStatusCodeLib null instance
> Platform/BeagleBoard: Drop the consume of PcdShellFile
> Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg
> Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib
> Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> Hisilicon/D06: Drop the consume of PcdShellFile
> Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg
> Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg
> Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in MdeModulePkg
> Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency
> Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib
> Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg
> Platform/LeMaker: Use ReportStatusCodeLib null instance
> Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg
> Platform/SoftIron: Use ReportStatusCodeLib null instance
> Platform/RPi3: Use ReportStatusCodeLib null instance
> Platform/RaspberryPi: Drop the consume of PcdShellFile
>
> Silicon/Hisilicon/Hisilicon.dsc.inc | 10 +-
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc |
> 2 +-
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> | 12 +-
> Platform/Hisilicon/D03/D03.dsc | 10 +-
> Platform/Hisilicon/D05/D05.dsc | 10 +-
> Platform/Hisilicon/D06/D06.dsc | 8 +-
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 10
> +-
> Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +-
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> | 10 +-
> Platform/Hisilicon/D03/D03.fdf | 6 +-
> Platform/Hisilicon/D05/D05.fdf | 6 +-
> Platform/Hisilicon/D06/D06.fdf | 6 +-
>
> Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.
> inf | 2 -
>
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDx
> e.inf | 1 -
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
> | 2 -
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> | 77 --
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
> | 1 -
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> | 55 --
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> | 21 -
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> | 4 +-
>
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFu
> nction.c | 4 +-
>
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManuf
> acturerFunction.c | 4 +-
>
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardMa
> nufacturerFunction.c | 4 +-
>
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufa
> cturerFunction.c | 2 +-
>
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDes
> ignationFunction.c | 4 +-
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> | 957 --------------------
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> | 112 ---
> 27 files changed, 48 insertions(+), 1299 deletions(-)
> delete mode 100644
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> delete mode 100644
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> delete mode 100644
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> delete mode 100644
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> delete mode 100644
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
>
> --
> 2.12.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency
2019-05-27 2:43 ` [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Wu, Hao A
@ 2019-06-10 5:13 ` Wu, Hao A
2019-06-10 15:12 ` Leif Lindholm
0 siblings, 1 reply; 25+ messages in thread
From: Wu, Hao A @ 2019-06-10 5:13 UTC (permalink / raw)
To: 'devel@edk2.groups.io', 'Ard Biesheuvel',
'Leif Lindholm'
Cc: ming.huang@linaro.org, Ni, Ray
Hello Ard and Leif,
I saw Ming Huang validated the patch (OS boot):
Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
https://edk2.groups.io/g/devel/message/41419
(Thanks a lot for the validation effort.)
Do you have remaining concerns for review this series?
Thanks in advance.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, May 27, 2019 10:43 AM
> To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm
> Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray;
> guoheyi@huawei.com
> Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> IntelFramework[Module]Pkg dependency
>
> Hello Ard and Leif,
>
> Do you have comments on this series?
>
> Also, for the below patch to Hisilicon platforms:
> [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in
> MdeModulePkg
>
> it is suggested to be verified on actual hardware:
> https://edk2.groups.io/g/devel/topic/31614327#41188
>
> However, it seems that there is no accessible hardware for such verification
> at this moment. Do you think it is fine to push this change anyway?
>
> (Also CCed the stewards here for comments.)
>
> Best Regards,
> Hao Wu
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wu, Hao A
> > Sent: Monday, May 20, 2019 4:41 PM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D
> > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > IntelFramework[Module]Pkg dependency
> >
> > The series is also available at:
> > https://github.com/hwu25/edk2-
> > platforms/commits/drop_intelframework_v2
> >
> > V2 changes:
> > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board, update
> > their DSC file to consume the null ReportStatusCodeLib in MdePkg. The
> > change is done since these platforms do not have a StatusCode Router
> > module;
> > B. Add the change for platform RaspberryPi/RPi3 to drop its dependency
> on
> > the framework packages;
> > C. Update the commit log message for patch
> > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg'
> > to better reflect the commit impact.
> >
> >
> > This series will drop the IntelFramework[Module]Pkg dependency for
> > platforms within the edk2-platforms repo.
> > packages.
> >
> > Tests done for the series:
> > Platforms build verified with GCC5 toolchain:
> > * Platform/AMD/OverdriveBoard
> > * Platform/ARM/JunoPkg
> > * Platform/ARM/SgiPkg
> > * Platform/ARM/VExpressPkg
> > * Platform/BeagleBoard
> > * Platform/Hisilicon/D0x
> > * Platform/Hisilicon/HiKey
> > * Platform/Hisilicon/HiKey960
> > * Platform/LeMaker/CelloBoard
> > * Platform/Marvell/Armada70x0Db (only AARCH64)
> > * Platform/Marvell/Armada80x0Db (only AARCH64)
> > * Platform/RaspberryPi/RPi3
> > * Platform/Socionext/DeveloperBox
> > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64)
> > * Platform/SoftIron/Overdrive1000Board
> > * Platform/SolidRun/Armada80x0McBin (only AARCH64)
> >
> > Platforms originally cannot be built via GCC5 toolchain (thus, not
> > verified):
> > * Platform/Comcast/RDKQemu (ARM, AARCH64)
> > * Platform/Marvell/Armada70x0Db (ARM)
> > * Platform/Marvell/Armada80x0Db (ARM)
> > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64)
> > * Platform/SolidRun/Armada80x0McBin (ARM)
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Hao A Wu (18):
> > Platform/AMD: Use Lzma decompress lib in MdeModulePkg
> > Platform/BeagleBoard: Use ReportStatusCodeLib null instance
> > Platform/BeagleBoard: Drop the consume of PcdShellFile
> > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg
> > Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib
> > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> > Hisilicon/D06: Drop the consume of PcdShellFile
> > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg
> > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg
> > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in
> MdeModulePkg
> > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency
> > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib
> > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg
> > Platform/LeMaker: Use ReportStatusCodeLib null instance
> > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg
> > Platform/SoftIron: Use ReportStatusCodeLib null instance
> > Platform/RPi3: Use ReportStatusCodeLib null instance
> > Platform/RaspberryPi: Drop the consume of PcdShellFile
> >
> > Silicon/Hisilicon/Hisilicon.dsc.inc | 10 +-
> > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> |
> > 2 +-
> > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > | 12 +-
> > Platform/Hisilicon/D03/D03.dsc | 10 +-
> > Platform/Hisilicon/D05/D05.dsc | 10 +-
> > Platform/Hisilicon/D06/D06.dsc | 8 +-
> > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 10
> > +-
> > Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +-
> > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> > | 10 +-
> > Platform/Hisilicon/D03/D03.fdf | 6 +-
> > Platform/Hisilicon/D05/D05.fdf | 6 +-
> > Platform/Hisilicon/D06/D06.fdf | 6 +-
> >
> >
> Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.
> > inf | 2 -
> >
> >
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDx
> > e.inf | 1 -
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
> > | 2 -
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > | 77 --
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
> > | 1 -
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > | 55 --
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > | 21 -
> >
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> > | 4 +-
> >
> >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFu
> > nction.c | 4 +-
> >
> >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManuf
> > acturerFunction.c | 4 +-
> >
> >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardMa
> > nufacturerFunction.c | 4 +-
> >
> >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufa
> > cturerFunction.c | 2 +-
> >
> >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDes
> > ignationFunction.c | 4 +-
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > | 957 --------------------
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > | 112 ---
> > 27 files changed, 48 insertions(+), 1299 deletions(-)
> > delete mode 100644
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > delete mode 100644
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > delete mode 100644
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > delete mode 100644
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > delete mode 100644
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> >
> > --
> > 2.12.0.windows.1
> >
> >
> >
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency
2019-06-10 5:13 ` Wu, Hao A
@ 2019-06-10 15:12 ` Leif Lindholm
2019-06-11 6:19 ` Wu, Hao A
0 siblings, 1 reply; 25+ messages in thread
From: Leif Lindholm @ 2019-06-10 15:12 UTC (permalink / raw)
To: Wu, Hao A
Cc: 'devel@edk2.groups.io', 'Ard Biesheuvel',
ming.huang@linaro.org, Ni, Ray
Hi Hao Wu,
Given Ming's confirmation regarding d06, I'm happy for this set to go
ahead. Also, we're just past the edk2 stable tag, so people should be
expecting some volatility :)
Acked-by: Leif Lindholm <leif.lindholm@linaro.org>
On Mon, Jun 10, 2019 at 05:13:42AM +0000, Wu, Hao A wrote:
> Hello Ard and Leif,
>
> I saw Ming Huang validated the patch (OS boot):
> Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
>
> https://edk2.groups.io/g/devel/message/41419
> (Thanks a lot for the validation effort.)
>
> Do you have remaining concerns for review this series?
> Thanks in advance.
>
> Best Regards,
> Hao Wu
>
>
> > -----Original Message-----
> > From: Wu, Hao A
> > Sent: Monday, May 27, 2019 10:43 AM
> > To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm
> > Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray;
> > guoheyi@huawei.com
> > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > IntelFramework[Module]Pkg dependency
> >
> > Hello Ard and Leif,
> >
> > Do you have comments on this series?
> >
> > Also, for the below patch to Hisilicon platforms:
> > [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in
> > MdeModulePkg
> >
> > it is suggested to be verified on actual hardware:
> > https://edk2.groups.io/g/devel/topic/31614327#41188
> >
> > However, it seems that there is no accessible hardware for such verification
> > at this moment. Do you think it is fine to push this change anyway?
> >
> > (Also CCed the stewards here for comments.)
> >
> > Best Regards,
> > Hao Wu
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > > Wu, Hao A
> > > Sent: Monday, May 20, 2019 4:41 PM
> > > To: devel@edk2.groups.io
> > > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D
> > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > > IntelFramework[Module]Pkg dependency
> > >
> > > The series is also available at:
> > > https://github.com/hwu25/edk2-
> > > platforms/commits/drop_intelframework_v2
> > >
> > > V2 changes:
> > > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board, update
> > > their DSC file to consume the null ReportStatusCodeLib in MdePkg. The
> > > change is done since these platforms do not have a StatusCode Router
> > > module;
> > > B. Add the change for platform RaspberryPi/RPi3 to drop its dependency
> > on
> > > the framework packages;
> > > C. Update the commit log message for patch
> > > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg'
> > > to better reflect the commit impact.
> > >
> > >
> > > This series will drop the IntelFramework[Module]Pkg dependency for
> > > platforms within the edk2-platforms repo.
> > > packages.
> > >
> > > Tests done for the series:
> > > Platforms build verified with GCC5 toolchain:
> > > * Platform/AMD/OverdriveBoard
> > > * Platform/ARM/JunoPkg
> > > * Platform/ARM/SgiPkg
> > > * Platform/ARM/VExpressPkg
> > > * Platform/BeagleBoard
> > > * Platform/Hisilicon/D0x
> > > * Platform/Hisilicon/HiKey
> > > * Platform/Hisilicon/HiKey960
> > > * Platform/LeMaker/CelloBoard
> > > * Platform/Marvell/Armada70x0Db (only AARCH64)
> > > * Platform/Marvell/Armada80x0Db (only AARCH64)
> > > * Platform/RaspberryPi/RPi3
> > > * Platform/Socionext/DeveloperBox
> > > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64)
> > > * Platform/SoftIron/Overdrive1000Board
> > > * Platform/SolidRun/Armada80x0McBin (only AARCH64)
> > >
> > > Platforms originally cannot be built via GCC5 toolchain (thus, not
> > > verified):
> > > * Platform/Comcast/RDKQemu (ARM, AARCH64)
> > > * Platform/Marvell/Armada70x0Db (ARM)
> > > * Platform/Marvell/Armada80x0Db (ARM)
> > > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64)
> > > * Platform/SolidRun/Armada80x0McBin (ARM)
> > >
> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > > Hao A Wu (18):
> > > Platform/AMD: Use Lzma decompress lib in MdeModulePkg
> > > Platform/BeagleBoard: Use ReportStatusCodeLib null instance
> > > Platform/BeagleBoard: Drop the consume of PcdShellFile
> > > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg
> > > Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib
> > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> > > Hisilicon/D06: Drop the consume of PcdShellFile
> > > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg
> > > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg
> > > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in
> > MdeModulePkg
> > > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency
> > > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib
> > > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg
> > > Platform/LeMaker: Use ReportStatusCodeLib null instance
> > > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg
> > > Platform/SoftIron: Use ReportStatusCodeLib null instance
> > > Platform/RPi3: Use ReportStatusCodeLib null instance
> > > Platform/RaspberryPi: Drop the consume of PcdShellFile
> > >
> > > Silicon/Hisilicon/Hisilicon.dsc.inc | 10 +-
> > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > |
> > > 2 +-
> > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > > | 12 +-
> > > Platform/Hisilicon/D03/D03.dsc | 10 +-
> > > Platform/Hisilicon/D05/D05.dsc | 10 +-
> > > Platform/Hisilicon/D06/D06.dsc | 8 +-
> > > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 10
> > > +-
> > > Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +-
> > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> > > | 10 +-
> > > Platform/Hisilicon/D03/D03.fdf | 6 +-
> > > Platform/Hisilicon/D05/D05.fdf | 6 +-
> > > Platform/Hisilicon/D06/D06.fdf | 6 +-
> > >
> > >
> > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.
> > > inf | 2 -
> > >
> > >
> > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDx
> > > e.inf | 1 -
> > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
> > > | 2 -
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > > | 77 --
> > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
> > > | 1 -
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > > | 55 --
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > > | 21 -
> > >
> > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> > > | 4 +-
> > >
> > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFu
> > > nction.c | 4 +-
> > >
> > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManuf
> > > acturerFunction.c | 4 +-
> > >
> > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardMa
> > > nufacturerFunction.c | 4 +-
> > >
> > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufa
> > > cturerFunction.c | 2 +-
> > >
> > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDes
> > > ignationFunction.c | 4 +-
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > > | 957 --------------------
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > > | 112 ---
> > > 27 files changed, 48 insertions(+), 1299 deletions(-)
> > > delete mode 100644
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > > delete mode 100644
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > > delete mode 100644
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > > delete mode 100644
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > > delete mode 100644
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > >
> > > --
> > > 2.12.0.windows.1
> > >
> > >
> > >
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency
2019-06-10 15:12 ` Leif Lindholm
@ 2019-06-11 6:19 ` Wu, Hao A
2019-06-11 9:38 ` Leif Lindholm
0 siblings, 1 reply; 25+ messages in thread
From: Wu, Hao A @ 2019-06-11 6:19 UTC (permalink / raw)
To: devel@edk2.groups.io, leif.lindholm@linaro.org
Cc: 'Ard Biesheuvel', ming.huang@linaro.org, Ni, Ray
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Monday, June 10, 2019 11:13 PM
> To: Wu, Hao A
> Cc: 'devel@edk2.groups.io'; 'Ard Biesheuvel'; ming.huang@linaro.org; Ni,
> Ray
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> IntelFramework[Module]Pkg dependency
>
> Hi Hao Wu,
>
> Given Ming's confirmation regarding d06, I'm happy for this set to go
> ahead. Also, we're just past the edk2 stable tag, so people should be
> expecting some volatility :)
>
> Acked-by: Leif Lindholm <leif.lindholm@linaro.org>
Thanks Leif,
Can I go ahead to push this series?
Or should I wait someone for additional review?
Best Regards,
Hao Wu
>
> On Mon, Jun 10, 2019 at 05:13:42AM +0000, Wu, Hao A wrote:
> > Hello Ard and Leif,
> >
> > I saw Ming Huang validated the patch (OS boot):
> > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> >
> > https://edk2.groups.io/g/devel/message/41419
> > (Thanks a lot for the validation effort.)
> >
> > Do you have remaining concerns for review this series?
> > Thanks in advance.
> >
> > Best Regards,
> > Hao Wu
> >
> >
> > > -----Original Message-----
> > > From: Wu, Hao A
> > > Sent: Monday, May 27, 2019 10:43 AM
> > > To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm
> > > Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray;
> > > guoheyi@huawei.com
> > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > > IntelFramework[Module]Pkg dependency
> > >
> > > Hello Ard and Leif,
> > >
> > > Do you have comments on this series?
> > >
> > > Also, for the below patch to Hisilicon platforms:
> > > [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in
> > > MdeModulePkg
> > >
> > > it is suggested to be verified on actual hardware:
> > > https://edk2.groups.io/g/devel/topic/31614327#41188
> > >
> > > However, it seems that there is no accessible hardware for such
> verification
> > > at this moment. Do you think it is fine to push this change anyway?
> > >
> > > (Also CCed the stewards here for comments.)
> > >
> > > Best Regards,
> > > Hao Wu
> > >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> Of
> > > > Wu, Hao A
> > > > Sent: Monday, May 20, 2019 4:41 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D
> > > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > > > IntelFramework[Module]Pkg dependency
> > > >
> > > > The series is also available at:
> > > > https://github.com/hwu25/edk2-
> > > > platforms/commits/drop_intelframework_v2
> > > >
> > > > V2 changes:
> > > > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board,
> update
> > > > their DSC file to consume the null ReportStatusCodeLib in MdePkg.
> The
> > > > change is done since these platforms do not have a StatusCode
> Router
> > > > module;
> > > > B. Add the change for platform RaspberryPi/RPi3 to drop its
> dependency
> > > on
> > > > the framework packages;
> > > > C. Update the commit log message for patch
> > > > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg'
> > > > to better reflect the commit impact.
> > > >
> > > >
> > > > This series will drop the IntelFramework[Module]Pkg dependency for
> > > > platforms within the edk2-platforms repo.
> > > > packages.
> > > >
> > > > Tests done for the series:
> > > > Platforms build verified with GCC5 toolchain:
> > > > * Platform/AMD/OverdriveBoard
> > > > * Platform/ARM/JunoPkg
> > > > * Platform/ARM/SgiPkg
> > > > * Platform/ARM/VExpressPkg
> > > > * Platform/BeagleBoard
> > > > * Platform/Hisilicon/D0x
> > > > * Platform/Hisilicon/HiKey
> > > > * Platform/Hisilicon/HiKey960
> > > > * Platform/LeMaker/CelloBoard
> > > > * Platform/Marvell/Armada70x0Db (only AARCH64)
> > > > * Platform/Marvell/Armada80x0Db (only AARCH64)
> > > > * Platform/RaspberryPi/RPi3
> > > > * Platform/Socionext/DeveloperBox
> > > > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64)
> > > > * Platform/SoftIron/Overdrive1000Board
> > > > * Platform/SolidRun/Armada80x0McBin (only AARCH64)
> > > >
> > > > Platforms originally cannot be built via GCC5 toolchain (thus, not
> > > > verified):
> > > > * Platform/Comcast/RDKQemu (ARM, AARCH64)
> > > > * Platform/Marvell/Armada70x0Db (ARM)
> > > > * Platform/Marvell/Armada80x0Db (ARM)
> > > > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64)
> > > > * Platform/SolidRun/Armada80x0McBin (ARM)
> > > >
> > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > >
> > > > Hao A Wu (18):
> > > > Platform/AMD: Use Lzma decompress lib in MdeModulePkg
> > > > Platform/BeagleBoard: Use ReportStatusCodeLib null instance
> > > > Platform/BeagleBoard: Drop the consume of PcdShellFile
> > > > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg
> > > > Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib
> > > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> > > > Hisilicon/D06: Drop the consume of PcdShellFile
> > > > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg
> > > > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg
> > > > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in
> > > MdeModulePkg
> > > > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg
> dependency
> > > > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon
> PlatformBdsLib
> > > > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg
> > > > Platform/LeMaker: Use ReportStatusCodeLib null instance
> > > > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg
> > > > Platform/SoftIron: Use ReportStatusCodeLib null instance
> > > > Platform/RPi3: Use ReportStatusCodeLib null instance
> > > > Platform/RaspberryPi: Drop the consume of PcdShellFile
> > > >
> > > > Silicon/Hisilicon/Hisilicon.dsc.inc | 10 +-
> > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > > |
> > > > 2 +-
> > > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > > > | 12 +-
> > > > Platform/Hisilicon/D03/D03.dsc | 10 +-
> > > > Platform/Hisilicon/D05/D05.dsc | 10 +-
> > > > Platform/Hisilicon/D06/D06.dsc | 8 +-
> > > > Platform/LeMaker/CelloBoard/CelloBoard.dsc |
> 10
> > > > +-
> > > > Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +-
> > > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> > > > | 10 +-
> > > > Platform/Hisilicon/D03/D03.fdf | 6 +-
> > > > Platform/Hisilicon/D05/D05.fdf | 6 +-
> > > > Platform/Hisilicon/D06/D06.fdf | 6 +-
> > > >
> > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDx
> e.
> > > > inf | 2 -
> > > >
> > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass
> Dx
> > > > e.inf | 1 -
> > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
> > > > | 2 -
> > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > > > | 77 --
> > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
> > > > | 1 -
> > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > > > | 55 --
> > > >
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > > > | 21 -
> > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.
> c
> > > > | 4 +-
> > > >
> > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorF
> u
> > > > nction.c | 4 +-
> > > >
> > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManu
> f
> > > > acturerFunction.c | 4 +-
> > > >
> > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardM
> a
> > > > nufacturerFunction.c | 4 +-
> > > >
> > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManu
> fa
> > > > cturerFunction.c | 2 +-
> > > >
> > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotD
> es
> > > > ignationFunction.c | 4 +-
> > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > > > | 957 --------------------
> > > >
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > > > | 112 ---
> > > > 27 files changed, 48 insertions(+), 1299 deletions(-)
> > > > delete mode 100644
> > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > > > delete mode 100644
> > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > > > delete mode 100644
> > > >
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > > > delete mode 100644
> > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > > > delete mode 100644
> > > >
> Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > > >
> > > > --
> > > > 2.12.0.windows.1
> > > >
> > > >
> > > >
> >
>
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency
2019-06-11 6:19 ` Wu, Hao A
@ 2019-06-11 9:38 ` Leif Lindholm
2019-06-12 0:21 ` Wu, Hao A
0 siblings, 1 reply; 25+ messages in thread
From: Leif Lindholm @ 2019-06-11 9:38 UTC (permalink / raw)
To: devel, hao.a.wu; +Cc: 'Ard Biesheuvel', ming.huang@linaro.org, Ni, Ray
On Tue, Jun 11, 2019 at 06:19:50AM +0000, Wu, Hao A wrote:
> Can I go ahead to push this series?
> Or should I wait someone for additional review?
Go for it.
My ACK applies to the series.
Best Regards,
Leif
> Best Regards,
> Hao Wu
>
> >
> > On Mon, Jun 10, 2019 at 05:13:42AM +0000, Wu, Hao A wrote:
> > > Hello Ard and Leif,
> > >
> > > I saw Ming Huang validated the patch (OS boot):
> > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> > >
> > > https://edk2.groups.io/g/devel/message/41419
> > > (Thanks a lot for the validation effort.)
> > >
> > > Do you have remaining concerns for review this series?
> > > Thanks in advance.
> > >
> > > Best Regards,
> > > Hao Wu
> > >
> > >
> > > > -----Original Message-----
> > > > From: Wu, Hao A
> > > > Sent: Monday, May 27, 2019 10:43 AM
> > > > To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm
> > > > Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray;
> > > > guoheyi@huawei.com
> > > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > > > IntelFramework[Module]Pkg dependency
> > > >
> > > > Hello Ard and Leif,
> > > >
> > > > Do you have comments on this series?
> > > >
> > > > Also, for the below patch to Hisilicon platforms:
> > > > [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in
> > > > MdeModulePkg
> > > >
> > > > it is suggested to be verified on actual hardware:
> > > > https://edk2.groups.io/g/devel/topic/31614327#41188
> > > >
> > > > However, it seems that there is no accessible hardware for such
> > verification
> > > > at this moment. Do you think it is fine to push this change anyway?
> > > >
> > > > (Also CCed the stewards here for comments.)
> > > >
> > > > Best Regards,
> > > > Hao Wu
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > Of
> > > > > Wu, Hao A
> > > > > Sent: Monday, May 20, 2019 4:41 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D
> > > > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > > > > IntelFramework[Module]Pkg dependency
> > > > >
> > > > > The series is also available at:
> > > > > https://github.com/hwu25/edk2-
> > > > > platforms/commits/drop_intelframework_v2
> > > > >
> > > > > V2 changes:
> > > > > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board,
> > update
> > > > > their DSC file to consume the null ReportStatusCodeLib in MdePkg.
> > The
> > > > > change is done since these platforms do not have a StatusCode
> > Router
> > > > > module;
> > > > > B. Add the change for platform RaspberryPi/RPi3 to drop its
> > dependency
> > > > on
> > > > > the framework packages;
> > > > > C. Update the commit log message for patch
> > > > > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg'
> > > > > to better reflect the commit impact.
> > > > >
> > > > >
> > > > > This series will drop the IntelFramework[Module]Pkg dependency for
> > > > > platforms within the edk2-platforms repo.
> > > > > packages.
> > > > >
> > > > > Tests done for the series:
> > > > > Platforms build verified with GCC5 toolchain:
> > > > > * Platform/AMD/OverdriveBoard
> > > > > * Platform/ARM/JunoPkg
> > > > > * Platform/ARM/SgiPkg
> > > > > * Platform/ARM/VExpressPkg
> > > > > * Platform/BeagleBoard
> > > > > * Platform/Hisilicon/D0x
> > > > > * Platform/Hisilicon/HiKey
> > > > > * Platform/Hisilicon/HiKey960
> > > > > * Platform/LeMaker/CelloBoard
> > > > > * Platform/Marvell/Armada70x0Db (only AARCH64)
> > > > > * Platform/Marvell/Armada80x0Db (only AARCH64)
> > > > > * Platform/RaspberryPi/RPi3
> > > > > * Platform/Socionext/DeveloperBox
> > > > > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64)
> > > > > * Platform/SoftIron/Overdrive1000Board
> > > > > * Platform/SolidRun/Armada80x0McBin (only AARCH64)
> > > > >
> > > > > Platforms originally cannot be built via GCC5 toolchain (thus, not
> > > > > verified):
> > > > > * Platform/Comcast/RDKQemu (ARM, AARCH64)
> > > > > * Platform/Marvell/Armada70x0Db (ARM)
> > > > > * Platform/Marvell/Armada80x0Db (ARM)
> > > > > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64)
> > > > > * Platform/SolidRun/Armada80x0McBin (ARM)
> > > > >
> > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > >
> > > > > Hao A Wu (18):
> > > > > Platform/AMD: Use Lzma decompress lib in MdeModulePkg
> > > > > Platform/BeagleBoard: Use ReportStatusCodeLib null instance
> > > > > Platform/BeagleBoard: Drop the consume of PcdShellFile
> > > > > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg
> > > > > Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib
> > > > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> > > > > Hisilicon/D06: Drop the consume of PcdShellFile
> > > > > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg
> > > > > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg
> > > > > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in
> > > > MdeModulePkg
> > > > > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg
> > dependency
> > > > > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon
> > PlatformBdsLib
> > > > > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg
> > > > > Platform/LeMaker: Use ReportStatusCodeLib null instance
> > > > > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg
> > > > > Platform/SoftIron: Use ReportStatusCodeLib null instance
> > > > > Platform/RPi3: Use ReportStatusCodeLib null instance
> > > > > Platform/RaspberryPi: Drop the consume of PcdShellFile
> > > > >
> > > > > Silicon/Hisilicon/Hisilicon.dsc.inc | 10 +-
> > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > > > |
> > > > > 2 +-
> > > > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > > > > | 12 +-
> > > > > Platform/Hisilicon/D03/D03.dsc | 10 +-
> > > > > Platform/Hisilicon/D05/D05.dsc | 10 +-
> > > > > Platform/Hisilicon/D06/D06.dsc | 8 +-
> > > > > Platform/LeMaker/CelloBoard/CelloBoard.dsc |
> > 10
> > > > > +-
> > > > > Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +-
> > > > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> > > > > | 10 +-
> > > > > Platform/Hisilicon/D03/D03.fdf | 6 +-
> > > > > Platform/Hisilicon/D05/D05.fdf | 6 +-
> > > > > Platform/Hisilicon/D06/D06.fdf | 6 +-
> > > > >
> > > > >
> > > >
> > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDx
> > e.
> > > > > inf | 2 -
> > > > >
> > > > >
> > > >
> > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass
> > Dx
> > > > > e.inf | 1 -
> > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
> > > > > | 2 -
> > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > > > > | 77 --
> > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
> > > > > | 1 -
> > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > > > > | 55 --
> > > > >
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > > > > | 21 -
> > > > >
> > > >
> > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.
> > c
> > > > > | 4 +-
> > > > >
> > > > >
> > > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorF
> > u
> > > > > nction.c | 4 +-
> > > > >
> > > > >
> > > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManu
> > f
> > > > > acturerFunction.c | 4 +-
> > > > >
> > > > >
> > > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardM
> > a
> > > > > nufacturerFunction.c | 4 +-
> > > > >
> > > > >
> > > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManu
> > fa
> > > > > cturerFunction.c | 2 +-
> > > > >
> > > > >
> > > >
> > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotD
> > es
> > > > > ignationFunction.c | 4 +-
> > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > > > > | 957 --------------------
> > > > >
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > > > > | 112 ---
> > > > > 27 files changed, 48 insertions(+), 1299 deletions(-)
> > > > > delete mode 100644
> > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > > > > delete mode 100644
> > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > > > > delete mode 100644
> > > > >
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > > > > delete mode 100644
> > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > > > > delete mode 100644
> > > > >
> > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > > > >
> > > > > --
> > > > > 2.12.0.windows.1
> > > > >
> > > > >
> > > > >
> > >
> >
> >
>
>
>
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency
2019-06-11 9:38 ` Leif Lindholm
@ 2019-06-12 0:21 ` Wu, Hao A
0 siblings, 0 replies; 25+ messages in thread
From: Wu, Hao A @ 2019-06-12 0:21 UTC (permalink / raw)
To: Leif Lindholm, devel@edk2.groups.io
Cc: 'Ard Biesheuvel', ming.huang@linaro.org, Ni, Ray
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Tuesday, June 11, 2019 5:39 PM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: 'Ard Biesheuvel'; ming.huang@linaro.org; Ni, Ray
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> IntelFramework[Module]Pkg dependency
>
> On Tue, Jun 11, 2019 at 06:19:50AM +0000, Wu, Hao A wrote:
> > Can I go ahead to push this series?
> > Or should I wait someone for additional review?
>
> Go for it.
> My ACK applies to the series.
Thanks.
Series pushed via commits 453c792abb..f87b5c8a6b.
Best Regards,
Hao Wu
>
> Best Regards,
>
> Leif
>
> > Best Regards,
> > Hao Wu
> >
> > >
> > > On Mon, Jun 10, 2019 at 05:13:42AM +0000, Wu, Hao A wrote:
> > > > Hello Ard and Leif,
> > > >
> > > > I saw Ming Huang validated the patch (OS boot):
> > > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> > > >
> > > > https://edk2.groups.io/g/devel/message/41419
> > > > (Thanks a lot for the validation effort.)
> > > >
> > > > Do you have remaining concerns for review this series?
> > > > Thanks in advance.
> > > >
> > > > Best Regards,
> > > > Hao Wu
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Wu, Hao A
> > > > > Sent: Monday, May 27, 2019 10:43 AM
> > > > > To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm
> > > > > Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray;
> > > > > guoheyi@huawei.com
> > > > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > > > > IntelFramework[Module]Pkg dependency
> > > > >
> > > > > Hello Ard and Leif,
> > > > >
> > > > > Do you have comments on this series?
> > > > >
> > > > > Also, for the below patch to Hisilicon platforms:
> > > > > [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in
> > > > > MdeModulePkg
> > > > >
> > > > > it is suggested to be verified on actual hardware:
> > > > > https://edk2.groups.io/g/devel/topic/31614327#41188
> > > > >
> > > > > However, it seems that there is no accessible hardware for such
> > > verification
> > > > > at this moment. Do you think it is fine to push this change anyway?
> > > > >
> > > > > (Also CCed the stewards here for comments.)
> > > > >
> > > > > Best Regards,
> > > > > Hao Wu
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> Behalf
> > > Of
> > > > > > Wu, Hao A
> > > > > > Sent: Monday, May 20, 2019 4:41 PM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D
> > > > > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop
> > > > > > IntelFramework[Module]Pkg dependency
> > > > > >
> > > > > > The series is also available at:
> > > > > > https://github.com/hwu25/edk2-
> > > > > > platforms/commits/drop_intelframework_v2
> > > > > >
> > > > > > V2 changes:
> > > > > > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board,
> > > update
> > > > > > their DSC file to consume the null ReportStatusCodeLib in MdePkg.
> > > The
> > > > > > change is done since these platforms do not have a StatusCode
> > > Router
> > > > > > module;
> > > > > > B. Add the change for platform RaspberryPi/RPi3 to drop its
> > > dependency
> > > > > on
> > > > > > the framework packages;
> > > > > > C. Update the commit log message for patch
> > > > > > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in
> MdeModulePkg'
> > > > > > to better reflect the commit impact.
> > > > > >
> > > > > >
> > > > > > This series will drop the IntelFramework[Module]Pkg dependency
> for
> > > > > > platforms within the edk2-platforms repo.
> > > > > > packages.
> > > > > >
> > > > > > Tests done for the series:
> > > > > > Platforms build verified with GCC5 toolchain:
> > > > > > * Platform/AMD/OverdriveBoard
> > > > > > * Platform/ARM/JunoPkg
> > > > > > * Platform/ARM/SgiPkg
> > > > > > * Platform/ARM/VExpressPkg
> > > > > > * Platform/BeagleBoard
> > > > > > * Platform/Hisilicon/D0x
> > > > > > * Platform/Hisilicon/HiKey
> > > > > > * Platform/Hisilicon/HiKey960
> > > > > > * Platform/LeMaker/CelloBoard
> > > > > > * Platform/Marvell/Armada70x0Db (only AARCH64)
> > > > > > * Platform/Marvell/Armada80x0Db (only AARCH64)
> > > > > > * Platform/RaspberryPi/RPi3
> > > > > > * Platform/Socionext/DeveloperBox
> > > > > > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64)
> > > > > > * Platform/SoftIron/Overdrive1000Board
> > > > > > * Platform/SolidRun/Armada80x0McBin (only AARCH64)
> > > > > >
> > > > > > Platforms originally cannot be built via GCC5 toolchain (thus, not
> > > > > > verified):
> > > > > > * Platform/Comcast/RDKQemu (ARM, AARCH64)
> > > > > > * Platform/Marvell/Armada70x0Db (ARM)
> > > > > > * Platform/Marvell/Armada80x0Db (ARM)
> > > > > > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64)
> > > > > > * Platform/SolidRun/Armada80x0McBin (ARM)
> > > > > >
> > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > >
> > > > > > Hao A Wu (18):
> > > > > > Platform/AMD: Use Lzma decompress lib in MdeModulePkg
> > > > > > Platform/BeagleBoard: Use ReportStatusCodeLib null instance
> > > > > > Platform/BeagleBoard: Drop the consume of PcdShellFile
> > > > > > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg
> > > > > > Hisilicon/D0x: Drop the consume of GenericBdsLib &
> PlatformBdsLib
> > > > > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
> > > > > > Hisilicon/D06: Drop the consume of PcdShellFile
> > > > > > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg
> > > > > > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg
> > > > > > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in
> > > > > MdeModulePkg
> > > > > > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg
> > > dependency
> > > > > > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon
> > > PlatformBdsLib
> > > > > > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg
> > > > > > Platform/LeMaker: Use ReportStatusCodeLib null instance
> > > > > > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg
> > > > > > Platform/SoftIron: Use ReportStatusCodeLib null instance
> > > > > > Platform/RPi3: Use ReportStatusCodeLib null instance
> > > > > > Platform/RaspberryPi: Drop the consume of PcdShellFile
> > > > > >
> > > > > > Silicon/Hisilicon/Hisilicon.dsc.inc | 10 +-
> > > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > > > > |
> > > > > > 2 +-
> > > > > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > > > > > | 12 +-
> > > > > > Platform/Hisilicon/D03/D03.dsc | 10
> +-
> > > > > > Platform/Hisilicon/D05/D05.dsc | 10
> +-
> > > > > > Platform/Hisilicon/D06/D06.dsc | 8 +-
> > > > > > Platform/LeMaker/CelloBoard/CelloBoard.dsc
> |
> > > 10
> > > > > > +-
> > > > > > Platform/RaspberryPi/RPi3/RPi3.dsc | 7
> +-
> > > > > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> > > > > > | 10 +-
> > > > > > Platform/Hisilicon/D03/D03.fdf | 6 +-
> > > > > > Platform/Hisilicon/D05/D05.fdf | 6 +-
> > > > > > Platform/Hisilicon/D06/D06.fdf | 6 +-
> > > > > >
> > > > > >
> > > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDx
> > > e.
> > > > > > inf | 2 -
> > > > > >
> > > > > >
> > > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass
> > > Dx
> > > > > > e.inf | 1 -
> > > > > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
> > > > > > | 2 -
> > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > > > > > | 77 --
> > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
> > > > > > | 1 -
> > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > > > > > | 55 --
> > > > > >
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > > > > > | 21 -
> > > > > >
> > > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.
> > > c
> > > > > > | 4 +-
> > > > > >
> > > > > >
> > > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorF
> > > u
> > > > > > nction.c | 4 +-
> > > > > >
> > > > > >
> > > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManu
> > > f
> > > > > > acturerFunction.c | 4 +-
> > > > > >
> > > > > >
> > > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardM
> > > a
> > > > > > nufacturerFunction.c | 4 +-
> > > > > >
> > > > > >
> > > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManu
> > > fa
> > > > > > cturerFunction.c | 2 +-
> > > > > >
> > > > > >
> > > > >
> > >
> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotD
> > > es
> > > > > > ignationFunction.c | 4 +-
> > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > > > > > | 957 --------------------
> > > > > >
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > > > > > | 112 ---
> > > > > > 27 files changed, 48 insertions(+), 1299 deletions(-)
> > > > > > delete mode 100644
> > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> > > > > > delete mode 100644
> > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h
> > > > > > delete mode 100644
> > > > > >
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h
> > > > > > delete mode 100644
> > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> > > > > > delete mode 100644
> > > > > >
> > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c
> > > > > >
> > > > > > --
> > > > > > 2.12.0.windows.1
> > > > > >
> > > > > >
> > > > > >
> > > >
> > >
> > >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 25+ messages in thread