[Patch 0/2] Add NetworkPkg/NetworkPkg.dec as the package dependency

[Patch 0/2] Add NetworkPkg/NetworkPkg.dec as the package dependency

[Liming Gao]

NetLib will be moved from MdeModulePkg and NetworkPkg.
So, the module that consumes NetLib need to depend on NetworkPkg.dec.

Liming Gao (2):
  ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency
  EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

 EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf                                    | 3 ++-
 ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf                 | 3 ++-
 ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf      | 3 ++-
 .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf      | 3 ++-
 .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf      | 3 ++-
 5 files changed, 10 insertions(+), 5 deletions(-)

-- 
2.13.0.windows.1

[Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

[Liming Gao]

NetLib will be moved from MdeModulePkg and NetworkPkg.
So, the module that consumes NetLib need to depend on NetworkPkg.dec.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
 ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf                 | 3 ++-
 ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf      | 3 ++-
 .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf      | 3 ++-
 .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf      | 3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
index 9d57e59c63..bc13c89a97 100644
--- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
+++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
@@ -1,7 +1,7 @@
 ##  @file
 # Provides Shell 'tftp' standalone application.
 #
-# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
+# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
 # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -31,6 +31,7 @@ [Packages]
   MdePkg/MdePkg.dec
   ShellPkg/ShellPkg.dec
   MdeModulePkg/MdeModulePkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   MemoryAllocationLib
diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
index f23445102a..b0c8e8f84b 100644
--- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
+++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
@@ -1,7 +1,7 @@
 ##  @file
 # Provides Shell 'tftp' dynamic command.
 #
-# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
+# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
 # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -32,6 +32,7 @@ [Packages]
   MdePkg/MdePkg.dec
   ShellPkg/ShellPkg.dec
   MdeModulePkg/MdeModulePkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   MemoryAllocationLib
diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
index 8054dc6f51..1e6ce63e3e 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
@@ -1,7 +1,7 @@
 ##  @file
 # Provides shell network1 functions
 #
-# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. <BR>
+# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -29,6 +29,7 @@ [Packages]
   MdePkg/MdePkg.dec
   ShellPkg/ShellPkg.dec
   MdeModulePkg/MdeModulePkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   MemoryAllocationLib
diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
index a9ca31a310..9ffcf85248 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
@@ -1,7 +1,7 @@
 ##  @file
 # Provides shell network2 functions
 #
-# Copyright (c) 2016, Intel Corporation. All rights reserved. <BR>
+# Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved. <BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -29,6 +29,7 @@ [Packages]
   MdePkg/MdePkg.dec
   ShellPkg/ShellPkg.dec
   MdeModulePkg/MdeModulePkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   MemoryAllocationLib
-- 
2.13.0.windows.1

[Patch 2/2] EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

[Liming Gao]

NetLib will be moved from MdeModulePkg and NetworkPkg.
So, the module that consumes NetLib need to depend on NetworkPkg.dec.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf b/EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf
index e570a4f79b..5b7d7fe60a 100644
--- a/EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf
+++ b/EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf
@@ -1,7 +1,7 @@
 #/** @file
 # Component name for module EmuSnpDxe
 #
-#  Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
 # Copyright (c) 2010, Apple, Inc. All rights reserved.<BR>
 #
 #    SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -33,6 +33,7 @@ [Packages]
   MdePkg/MdePkg.dec
   MdeModulePkg/MdeModulePkg.dec
   EmulatorPkg/EmulatorPkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   DevicePathLib
-- 
2.13.0.windows.1

Re: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

[Carsey, Jaben]

Netlib class definition and instance are both moving?

Are these modules using MdeModulePkg for a different lib or can we remove it?

> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, May 20, 2019 6:09 AM
> To: devel@edk2.groups.io
> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the
> package dependency
> Importance: High
> 
> NetLib will be moved from MdeModulePkg and NetworkPkg.
> So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> 
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf                 | 3
> ++-
> 
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.
> inf      | 3 ++-
>  .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> | 3 ++-
>  .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> | 3 ++-
>  4 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> index 9d57e59c63..bc13c89a97 100644
> --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> @@ -1,7 +1,7 @@
>  ##  @file
>  # Provides Shell 'tftp' standalone application.
>  #
> -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
> +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
>  # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -31,6 +31,7 @@ [Packages]
>    MdePkg/MdePkg.dec
>    ShellPkg/ShellPkg.dec
>    MdeModulePkg/MdeModulePkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    MemoryAllocationLib
> diff --git
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> d.inf
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> d.inf
> index f23445102a..b0c8e8f84b 100644
> ---
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> d.inf
> +++
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> d.inf
> @@ -1,7 +1,7 @@
>  ##  @file
>  # Provides Shell 'tftp' dynamic command.
>  #
> -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
> +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
>  # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -32,6 +32,7 @@ [Packages]
>    MdePkg/MdePkg.dec
>    ShellPkg/ShellPkg.dec
>    MdeModulePkg/MdeModulePkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    MemoryAllocationLib
> diff --git
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.inf
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.inf
> index 8054dc6f51..1e6ce63e3e 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.inf
> +++
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.inf
> @@ -1,7 +1,7 @@
>  ##  @file
>  # Provides shell network1 functions
>  #
> -# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. <BR>
> +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -29,6 +29,7 @@ [Packages]
>    MdePkg/MdePkg.dec
>    ShellPkg/ShellPkg.dec
>    MdeModulePkg/MdeModulePkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    MemoryAllocationLib
> diff --git
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.inf
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.inf
> index a9ca31a310..9ffcf85248 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.inf
> +++
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.inf
> @@ -1,7 +1,7 @@
>  ##  @file
>  # Provides shell network2 functions
>  #
> -# Copyright (c) 2016, Intel Corporation. All rights reserved. <BR>
> +# Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved. <BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -29,6 +29,7 @@ [Packages]
>    MdePkg/MdePkg.dec
>    ShellPkg/ShellPkg.dec
>    MdeModulePkg/MdeModulePkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    MemoryAllocationLib
> --
> 2.13.0.windows.1

Re: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

[Liming Gao]

Jaben:
  Yes. MdeModulePkg is still required. 

Thanks
Liming
> -----Original Message-----
> From: Carsey, Jaben
> Sent: Tuesday, May 21, 2019 12:35 AM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency
> 
> Netlib class definition and instance are both moving?
> 
> Are these modules using MdeModulePkg for a different lib or can we remove it?
> 
> > -----Original Message-----
> > From: Gao, Liming
> > Sent: Monday, May 20, 2019 6:09 AM
> > To: devel@edk2.groups.io
> > Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Carsey, Jaben <jaben.carsey@intel.com>
> > Subject: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the
> > package dependency
> > Importance: High
> >
> > NetLib will be moved from MdeModulePkg and NetworkPkg.
> > So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> >
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > ---
> >  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf                 | 3
> > ++-
> >
> > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.
> > inf      | 3 ++-
> >  .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> > | 3 ++-
> >  .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> > | 3 ++-
> >  4 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > index 9d57e59c63..bc13c89a97 100644
> > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > @@ -1,7 +1,7 @@
> >  ##  @file
> >  # Provides Shell 'tftp' standalone application.
> >  #
> > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
> >  # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> > @@ -31,6 +31,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    MemoryAllocationLib
> > diff --git
> > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > d.inf
> > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > d.inf
> > index f23445102a..b0c8e8f84b 100644
> > ---
> > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > d.inf
> > +++
> > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > d.inf
> > @@ -1,7 +1,7 @@
> >  ##  @file
> >  # Provides Shell 'tftp' dynamic command.
> >  #
> > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
> >  # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> > @@ -32,6 +32,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    MemoryAllocationLib
> > diff --git
> > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > mandsLib.inf
> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > mandsLib.inf
> > index 8054dc6f51..1e6ce63e3e 100644
> > ---
> > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > mandsLib.inf
> > +++
> > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > mandsLib.inf
> > @@ -1,7 +1,7 @@
> >  ##  @file
> >  # Provides shell network1 functions
> >  #
> > -# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. <BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> >  #
> > @@ -29,6 +29,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    MemoryAllocationLib
> > diff --git
> > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > mandsLib.inf
> > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > mandsLib.inf
> > index a9ca31a310..9ffcf85248 100644
> > ---
> > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > mandsLib.inf
> > +++
> > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > mandsLib.inf
> > @@ -1,7 +1,7 @@
> >  ##  @file
> >  # Provides shell network2 functions
> >  #
> > -# Copyright (c) 2016, Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved. <BR>
> >  #
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> >  #
> > @@ -29,6 +29,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    MemoryAllocationLib
> > --
> > 2.13.0.windows.1

Re: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

[Gao, Zhichao]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, May 21, 2019 9:06 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; devel@edk2.groups.io
> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the
> package dependency
> 
> Jaben:
>   Yes. MdeModulePkg is still required.
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: Carsey, Jaben
> > Sent: Tuesday, May 21, 2019 12:35 AM
> > To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
> > Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as
> > the package dependency
> >
> > Netlib class definition and instance are both moving?
> >
> > Are these modules using MdeModulePkg for a different lib or can we
> remove it?
> >
> > > -----Original Message-----
> > > From: Gao, Liming
> > > Sent: Monday, May 20, 2019 6:09 AM
> > > To: devel@edk2.groups.io
> > > Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray
> > > <ray.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> > > Subject: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the
> > > package dependency
> > > Importance: High
> > >
> > > NetLib will be moved from MdeModulePkg and NetworkPkg.
> > > So, the module that consumes NetLib need to depend on
> NetworkPkg.dec.
> > >
> > > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > > ---
> > >  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> | 3
> > > ++-
> > >
> > >
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.
> > > inf      | 3 ++-
> > >  .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.in
> f
> > > | 3 ++-
> > >  .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.in
> f
> > > | 3 ++-
> > >  4 files changed, 8 insertions(+), 4 deletions(-)
> > >
> > > diff --git
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > > index 9d57e59c63..bc13c89a97 100644
> > > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > > @@ -1,7 +1,7 @@
> > >  ##  @file
> > >  # Provides Shell 'tftp' standalone application.
> > >  #
> > > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights
> > > reserved. <BR>
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > > +reserved. <BR>
> > >  # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>  #  #
> > > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -31,6 +31,7 @@
> > > [Packages]
> > >    MdePkg/MdePkg.dec
> > >    ShellPkg/ShellPkg.dec
> > >    MdeModulePkg/MdeModulePkg.dec
> > > +  NetworkPkg/NetworkPkg.dec
> > >
> > >  [LibraryClasses]
> > >    MemoryAllocationLib
> > > diff --git
> > >
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > > d.inf
> > >
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > > d.inf
> > > index f23445102a..b0c8e8f84b 100644
> > > ---
> > >
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > > d.inf
> > > +++
> > >
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > > d.inf
> > > @@ -1,7 +1,7 @@
> > >  ##  @file
> > >  # Provides Shell 'tftp' dynamic command.
> > >  #
> > > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights
> > > reserved. <BR>
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > > +reserved. <BR>
> > >  # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR>  #  #
> > > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -32,6 +32,7 @@
> > > [Packages]
> > >    MdePkg/MdePkg.dec
> > >    ShellPkg/ShellPkg.dec
> > >    MdeModulePkg/MdeModulePkg.dec
> > > +  NetworkPkg/NetworkPkg.dec
> > >
> > >  [LibraryClasses]
> > >    MemoryAllocationLib
> > > diff --git
> > >
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > > mandsLib.inf
> > >
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > > mandsLib.inf
> > > index 8054dc6f51..1e6ce63e3e 100644
> > > ---
> > >
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > > mandsLib.inf
> > > +++
> > >
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > > mandsLib.inf
> > > @@ -1,7 +1,7 @@
> > >  ##  @file
> > >  # Provides shell network1 functions  # -# Copyright (c) 2010 -
> > > 2018, Intel Corporation. All rights reserved. <BR>
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > > +reserved. <BR>
> > >  #
> > >  #  SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -29,6 +29,7
> > > @@ [Packages]
> > >    MdePkg/MdePkg.dec
> > >    ShellPkg/ShellPkg.dec
> > >    MdeModulePkg/MdeModulePkg.dec
> > > +  NetworkPkg/NetworkPkg.dec
> > >
> > >  [LibraryClasses]
> > >    MemoryAllocationLib
> > > diff --git
> > >
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > > mandsLib.inf
> > >
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > > mandsLib.inf
> > > index a9ca31a310..9ffcf85248 100644
> > > ---
> > >
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > > mandsLib.inf
> > > +++
> > >
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > > mandsLib.inf
> > > @@ -1,7 +1,7 @@
> > >  ##  @file
> > >  # Provides shell network2 functions  # -# Copyright (c) 2016, Intel
> > > Corporation. All rights reserved. <BR>
> > > +# Copyright (c) 2016 - 2019, Intel Corporation. All rights
> > > +reserved. <BR>
> > >  #
> > >  #  SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -29,6 +29,7
> > > @@ [Packages]
> > >    MdePkg/MdePkg.dec
> > >    ShellPkg/ShellPkg.dec
> > >    MdeModulePkg/MdeModulePkg.dec
> > > +  NetworkPkg/NetworkPkg.dec
> > >
> > >  [LibraryClasses]
> > >    MemoryAllocationLib
> > > --
> > > 2.13.0.windows.1

FW: [edk2-devel] [Patch 2/2] EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

[Liming Gao]

Forward to edk2 mail list

-----Original Message-----
From: Ni, Ray 
Sent: Tuesday, May 21, 2019 10:29 AM
To: Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2-devel] [Patch 2/2] EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency

Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Liming Gao
> > Sent: Monday, May 20, 2019 9:09 PM
> > To: devel@edk2.groups.io
> > Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> > <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [edk2-devel] [Patch 2/2] EmulatorPkg: Add
> > NetworkPkg/NetworkPkg.dec as the package dependency
> >
> > NetLib will be moved from MdeModulePkg and NetworkPkg.
> > So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> >
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > ---
> >  EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf
> > b/EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf
> > index e570a4f79b..5b7d7fe60a 100644
> > --- a/EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf
> > +++ b/EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf
> > @@ -1,7 +1,7 @@
> >  #/** @file
> >  # Component name for module EmuSnpDxe  # -#  Copyright (c) 2018,
> > Intel Corporation. All rights reserved.<BR>
> > +#  Copyright (c) 2018 - 2019, Intel Corporation. All rights
> > +reserved.<BR>
> >  # Copyright (c) 2010, Apple, Inc. All rights reserved.<BR>  #
> >  #    SPDX-License-Identifier: BSD-2-Clause-Patent
> > @@ -33,6 +33,7 @@ [Packages]
> >    MdePkg/MdePkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> >    EmulatorPkg/EmulatorPkg.dec
> > +  NetworkPkg/NetworkPkg.dec
> >
> >  [LibraryClasses]
> >    DevicePathLib
> > --
> > 2.13.0.windows.1
> >
> >
> >