From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=tsQdtFf0; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Mon, 20 May 2019 07:51:30 -0700 Received: by mail-wr1-f67.google.com with SMTP id e15so14968788wrs.4 for ; Mon, 20 May 2019 07:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z852UTafoI/q+Tg6EzyDlaRExNKrKLHMk/t0E+XrkSw=; b=tsQdtFf0zr8NsNYUNUgdnEF5BQXAkjLhaQTfdYYw4TEMY6oHEXCJcx5eZ60H/gzth/ Ahx4lxsRIIWCAadtU3ztFfNA2DnZ+ivGbbz95vftEqgI3IldaQCWQBmDVRrgfrgtw/wm sV8iwigInl2zp5DeztM0scAtM9tLAJRzESPR7OHrnaOdODAG/eFEYyQ2iIBad0jrJefT cZgusyQvD0CyUv8VjMb2GKwb4vJjzMcxF3TBkaqZR6Gg2niQxnQ14s+hwF5wGbty1IYU sBK50kFTSmdS8JNdvUJI63zI20rwFLw0ZrsXTu07z2GZhazIPF1pZnuzivvdoq0cyB27 tNrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z852UTafoI/q+Tg6EzyDlaRExNKrKLHMk/t0E+XrkSw=; b=Qcig8yPc8Ao5sivju3nYrqlDB1jqTZNjDUF3i3ndppORJszl597tFQ9jBCtpypMCtZ Arq9YXGh/xlpE90xJSLbGzvESDPZSWdZ55ogr7oRnETdLj0m4j6sF3BOaBVwyJuzpLTQ lF7il4g7dRZ3+wflY4uNebJs2mdDfjUuheiV45W2xdR64SlkSkMu0zR+wsMuUcTdBKEF L5B4CdglUUGKjIqVtwUMPqqV4g35ork6/2KMvuV+xFkgBq6JzvljDxnwdehq2MArQfpY dRLHO4aiCP217kXrmS2LgnGAvmImoMlEDUS8z+m89EkDsjIKATvR+s0Bf4JD1+NdYeSW VzKA== X-Gm-Message-State: APjAAAX6Hj+VI9GyWBaiIz4wL4nYVMg0M6jjAuWFBijIfv97sbSHtw60 mRjkJFij/2K7TKKL5V/ItgGvXw== X-Google-Smtp-Source: APXvYqzDnlTLVl9Qs2nPjW6FyeMRDvSU0oqgTpQLbr3xmqtBQE7ElHiys+sktVNEA4LncGALQ3e4Hg== X-Received: by 2002:a5d:4cc4:: with SMTP id c4mr34090342wrt.164.1558363889066; Mon, 20 May 2019 07:51:29 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x2sm5458795wrs.39.2019.05.20.07.51.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 07:51:28 -0700 (PDT) Date: Mon, 20 May 2019 15:51:26 +0100 From: "Leif Lindholm" To: Liming Gao Cc: devel@edk2.groups.io, Ard Biesheuvel , Michael D Kinney Subject: Re: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency Message-ID: <20190520145126.uxuxpplf2eaaei6n@bivouac.eciton.net> References: <20190520130949.20412-1-liming.gao@intel.com> <20190520130949.20412-2-liming.gao@intel.com> MIME-Version: 1.0 In-Reply-To: <20190520130949.20412-2-liming.gao@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 20, 2019 at 09:09:47PM +0800, Liming Gao wrote: > NetLib will be moved from MdeModulePkg and NetworkPkg. > So, the module that consumes NetLib need to depend on NetworkPkg.dec. > > Signed-off-by: Liming Gao > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Platform/ARM/Library/BdsLib/BdsLib.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/Library/BdsLib/BdsLib.inf b/Platform/ARM/Library/BdsLib/BdsLib.inf > index 12995cf174..6b95ec943b 100644 > --- a/Platform/ARM/Library/BdsLib/BdsLib.inf > +++ b/Platform/ARM/Library/BdsLib/BdsLib.inf > @@ -23,6 +23,7 @@ > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/ARM.dec > + NetworkPkg/NetworkPkg.dec If you move that insertion up one line to get it alphabetically sorted: Reviewed-by: Leif Lindholm > > [LibraryClasses] > ArmLib > -- > 2.13.0.windows.1 >