From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=mSIgFKuC; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Mon, 20 May 2019 07:52:44 -0700 Received: by mail-wr1-f66.google.com with SMTP id r7so14917732wrr.13 for ; Mon, 20 May 2019 07:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q2tG1ooAbHNqFY/vsjlNPNG1JHzU4BA9ASUIYgG5hpU=; b=mSIgFKuCNdbXld5mKUkd4Fy0LEs4igXcSlXfMznmmiuXRwHPsk2j2+6U5SZkY6kRPf Fe7lWnZjmvGqtap2ZlH20iTYmTYoG7cLziFH/DYNT522YGMuySoem9bTXW6amAkEOiD7 793tsH31cfZofZx054De1Wdo/ryTPE7LhX3UrJrA+bzGoOrpBmiOOennlSIBzRPed+VS 1henfNMfQ+u8WUqWoWdGoD9XkjgCwEhzHNa7NfPtDSoMrRtS1R2Xyi4ZM0Jinfs0Hh30 kJemSz2Ypy5lLupT3iMaTW9aeBvZT5MAAy43xoXTGinT6U5SclkYFwH0oqdx2si3puao K5eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q2tG1ooAbHNqFY/vsjlNPNG1JHzU4BA9ASUIYgG5hpU=; b=PXGxbyYI2aWVS4D5HXrn8tvUxFfxZMo+tAqjaOCZFMvv3iFL0rfDZZ/0qETz7k+SQx fu05nGknVrsWVcweWDm0aVXJF/JnGB1AcsoFI5zN77eLEdGm+Lhc6ZVbajwrshBCBigt z/ohCxbv7mWgTTG1tWYUN/E49dxJGv3fiz7k/ErlQ1/jVLAYJDr714vHHvJ3ZfemfBKL ZRX8YJguXmSgUv3uXFcZ8mhgLzzonJyNddB+N/pujUUoXDhDw54+81Cv8w5mwRnLmNCG OPLFXnNb6Y1PBsnxOvLm+qNZ6FqxelJvqAY4CeifKPKDlP6ESxJYQUe7Res2JjvKR74L L/3w== X-Gm-Message-State: APjAAAU1St4OJBapCTFCyLQ/Vt/PaYwhwebHKToM7NKKEzA/3Cp4Hbvd oBfcP02F0DVOQAShHaKa9eeD8Q== X-Google-Smtp-Source: APXvYqyt0fZL3td0/PIm0aNMnoUKhKPlMLc9gLsAYqB78+HIaoeAp+VrwFjCixYrGKaImQEvEA4ftQ== X-Received: by 2002:adf:f741:: with SMTP id z1mr323117wrp.14.1558363963064; Mon, 20 May 2019 07:52:43 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id i17sm18422398wrr.46.2019.05.20.07.52.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 07:52:41 -0700 (PDT) Date: Mon, 20 May 2019 15:52:40 +0100 From: "Leif Lindholm" To: Liming Gao Cc: devel@edk2.groups.io, Ard Biesheuvel , Michael D Kinney Subject: Re: [Patch edk2-platform 3/3] Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec as the package dependency Message-ID: <20190520145240.2cc4hnzqhdvzbh6k@bivouac.eciton.net> References: <20190520130949.20412-1-liming.gao@intel.com> <20190520130949.20412-4-liming.gao@intel.com> MIME-Version: 1.0 In-Reply-To: <20190520130949.20412-4-liming.gao@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 20, 2019 at 09:09:49PM +0800, Liming Gao wrote: > NetLib will be moved from MdeModulePkg and NetworkPkg. > So, the module that consumes NetLib need to depend on NetworkPkg.dec. > > Signed-off-by: Liming Gao > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf > index 73aa4133b6..ea63f73ded 100644 > --- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf > +++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf > @@ -48,6 +48,7 @@ > MdeModulePkg/MdeModulePkg.dec > ArmPkg/ArmPkg.dec > Silicon/Marvell/Marvell.dec > + NetworkPkg/NetworkPkg.dec If you move this one too up one line: Reviewed-by: Leif Lindholm > > [LibraryClasses] > DmaLib > -- > 2.13.0.windows.1 >