From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=XnCa0rWP; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Tue, 21 May 2019 04:59:26 -0700 Received: by mail-wm1-f66.google.com with SMTP id y3so2704531wmm.2 for ; Tue, 21 May 2019 04:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+KwqVsVg9M2tG7wtw0SxjOHjXuGEEz5NAe6NJ8pAzjY=; b=XnCa0rWPTh2uvTABblPTFpXvq6Rys4CLd0rJQRW0erFAnYcmaHah6WJWqGXtVqEOZJ 1LCuqc3qZ07EapI1NgobujiJG9fbZQ2RxMlx43AFg/5l+B0PkkPZuNBysfzD00DClNGr YAyCx0cDNcOPx848yftvJfowISzPUfGqDW6P+UkSYE+Ba8PPzdsAkPnmIwLuuyRkqpLY wW1ojsDEnpXMjnOcTKR6IGuGV406sSdSiJATFaLlpbNgPmRFTK77GLP4XZDqcKnH1+G8 lHunJpGn4CRnfeIgDN40KiBc1bTc4bS3Jw0x2QzcerFRHNaEQvqu+El8rySfhF8smJsL l/cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+KwqVsVg9M2tG7wtw0SxjOHjXuGEEz5NAe6NJ8pAzjY=; b=ZAPRnKEw/cGaDjYPxu5J+hupES/7KlNYADhhuJjD9zwA32VnMtp9LruAbCvqfQjmyz vIP9Cn1tQ8DrlIVdCOZgQ5D1oUThEfsS4LQ7BViOi6dm+UC52O++xWHl2dz4I0wXdHUF gp/eejyMZ4Xh+TTJi6PuKV3eAu4PAa0A6qBNdb2HujAH3uzpbsYBuq2vb0Pne95PhdPc 2tbSQz+GJ/i3mWbEiqqSiqWHCywpa5quT+CWLRxaB/Ajv3nSZ0pCqjSCGk2fxTFI6yDo /Hk8BLdoqRp4in4oQ/NuA2jtZuDiRip88zPJ85hBqmOrR+ix5SY3hU4+/PD2pQgxfFAO SiWQ== X-Gm-Message-State: APjAAAWvARreey2bZI6NBFjDyKgL46wDWc7Z07mSfSaZsI1k4Xkgve0A 48cCMBvqQP4/1Pa+Rtf2lQq3vA== X-Google-Smtp-Source: APXvYqwJ5YvfXYGiweF3orWRwVcjA9CCdZOiyDTUi7Z+qy66uDNCeCupGu5mbNqoWD1jiZ3fYToNsg== X-Received: by 2002:a1c:6c0a:: with SMTP id h10mr3251461wmc.135.1558439964713; Tue, 21 May 2019 04:59:24 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z74sm3883603wmc.2.2019.05.21.04.59.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 May 2019 04:59:23 -0700 (PDT) Date: Tue, 21 May 2019 12:59:22 +0100 From: "Leif Lindholm" To: Shenglei Zhang Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms V3 10/18] Platform/SynQuacerEvalBoard: Update DSC/FDF to use NetworkPkg DSC/FDF Message-ID: <20190521115922.i5ljs43ske7told6@bivouac.eciton.net> References: <20190520070729.30812-1-shenglei.zhang@intel.com> <20190520070729.30812-11-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190520070729.30812-11-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 20, 2019 at 03:07:21PM +0800, Shenglei Zhang wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > v2: Change Network.dsc.inc to Network.fdf.inc in SynQuacerEvalBoard.fdf. Any notes on changes go under the "---" line below. If you delete this revision comment before committing: Reviewed-by: Leif Lindholm > Cc: Leif Lindholm > Signed-off-by: Shenglei Zhang > --- > .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 35 +++++-------------- > .../SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 21 ++--------- > 2 files changed, 10 insertions(+), 46 deletions(-) > > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > index 189baa8659..ab1ab6f2de 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > @@ -22,6 +22,12 @@ > FLASH_DEFINITION = Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > BUILD_NUMBER = 1 > > + # > + # Network definition > + # > + DEFINE NETWORK_SNP_ENABLE = FALSE > + DEFINE NETWORK_TLS_ENABLE = FALSE > + > [BuildOptions] > RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 > > @@ -49,11 +55,6 @@ > > BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > > - # Networking Requirements > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > # ARM Architectural Libraries > CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf > @@ -113,9 +114,6 @@ > SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > > - HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > - > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > @@ -594,25 +592,8 @@ > # > # Networking stack > # > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - NetworkPkg/Ip6Dxe/Ip6Dxe.inf > - NetworkPkg/TcpDxe/TcpDxe.inf > - NetworkPkg/Udp6Dxe/Udp6Dxe.inf > - NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > - NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - NetworkPkg/IScsiDxe/IScsiDxe.inf > - NetworkPkg/DnsDxe/DnsDxe.inf > - NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > - NetworkPkg/HttpDxe/HttpDxe.inf > - NetworkPkg/HttpBootDxe/HttpBootDxe.inf > +!include NetworkPkg/Network.dsc.inc > + > Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf { > > DmaLib|EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > index 1c9795df3b..b1e0a53e61 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > @@ -186,25 +186,8 @@ READ_LOCK_STATUS = TRUE > # > # Networking stack > # > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf > - INF NetworkPkg/TcpDxe/TcpDxe.inf > - INF NetworkPkg/Udp6Dxe/Udp6Dxe.inf > - INF NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > - INF NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - INF NetworkPkg/IScsiDxe/IScsiDxe.inf > - INF NetworkPkg/DnsDxe/DnsDxe.inf > - INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > - INF NetworkPkg/HttpDxe/HttpDxe.inf > - INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf > +!include NetworkPkg/Network.fdf.inc > + > INF Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf > > # > -- > 2.18.0.windows.1 >