From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=E99z+3/s; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Wed, 22 May 2019 07:33:55 -0700 Received: by mail-wr1-f68.google.com with SMTP id d18so2583175wrs.5 for ; Wed, 22 May 2019 07:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eoXfnKlJuLNZBuQYoz33mRWTPTJ/JQdFaTuEzJQ0ing=; b=E99z+3/sKRGiBGtz06MaRJBL+om23PUPGlHYkVi6CJfqGCwohyGybNPcHCI6euEXXp EoXiKuT735Pl/Mn28CKy9VHyRnTSPl9mPQ6p9VL2OQhyv2gmyPuzO6VlXSjtFf8hqfl0 /3mk33VNBXi81saoCiE51HHv216rmpWd04vc9hID3kb4uPGSHVMgew3JBlFAXCZ+wsVH M1PhdOPw0SuNR8lwYM9VOL+kKE193n8NY5Bod8M/UKmmeIApD7pwn7o3EGQklvu8OAb+ Spm4T2TgGN6kaiZHSW0pNMHYVHb/WoQcn/x/zHp7dvTEEQVPuTNz7LbgWcGMScpns0vX 2d7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eoXfnKlJuLNZBuQYoz33mRWTPTJ/JQdFaTuEzJQ0ing=; b=KoscrTA1m5QYDLjV19u56c84+dZY213SEJ8NGUzCgPJufbwuJ18c337vJTR1EwHB4q zikj0E0RaXu5ARu3tkT9ydZtGkKonJbI5Dhz38kgYfFDz2qkPAHnrGfS28ZcLyGYCSVZ jjBVagv55KYnU258LkrwrOUZ+48szD6ZTuVaTXrDghxRqYKm/AY+pxAeZwo2EvWrmwXH q9xXFG8g5YGP9SRxUdOaRL15qQeOK1mhg3ppKL6ioE06Ba+QNn8R00xn/41JGkgy7wot auzV+4Lo7J49oWsvckGARtKrulaCQnrT0k0PdVCSqBcia8Y3sFA8LDxlpG2fW00330uQ +5gQ== X-Gm-Message-State: APjAAAUyA+Fis+EArmfK6XPRjl2KN+9ece7f6sW0FbW1w83nnTHY+ynK fsPYIjDW59FJ6byfMHvMFut8Wg== X-Google-Smtp-Source: APXvYqzgQ7iKg6u81bJ93FYgTKXRHgNNJFB7EpmbkdVPrTp0ycfFgIi34Qnn5AcDFA/bmIjMDg2H4A== X-Received: by 2002:adf:dcc4:: with SMTP id x4mr29457910wrm.107.1558535634076; Wed, 22 May 2019 07:33:54 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f16sm20717489wrx.58.2019.05.22.07.33.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 May 2019 07:33:52 -0700 (PDT) Date: Wed, 22 May 2019 15:33:51 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: Laszlo Ersek , "Wu, Hao A" , "devel@edk2.groups.io" , "Kinney, Michael D" , "afish@apple.com" Subject: Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules Message-ID: <20190522143350.66r5c7rkeezmy5dp@bivouac.eciton.net> References: <20190521152152.5868-1-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E44F390@SHSMSX104.ccr.corp.intel.com> <36bf48fa-64ef-34b9-ba03-491882524764@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E44F82B@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44F82B@SHSMSX104.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 22, 2019 at 11:41:03AM +0000, Gao, Liming wrote: > > -----Original Message----- > > From: Laszlo Ersek [mailto:lersek@redhat.com] > > Sent: Wednesday, May 22, 2019 5:11 PM > > To: Gao, Liming ; Wu, Hao A ; devel@edk2.groups.io > > Cc: leif.lindholm@linaro.org; Kinney, Michael D ; afish@apple.com > > Subject: Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules > > > > On 05/22/19 03:50, Gao, Liming wrote: > > > This is a bug. Because NetworkPkg dsc has included all network modules, the ones in MdeModule are duplicated. > > > > I'm not sure I'm convinced -- if this patch is not applied, what > > precisely is the functionality that breaks? What are the symptoms? > > > The problem is that NetworkPkg.dsc and MdeModulePkg.dsc both builds those network drivers. > I am OK to get more feedback from stewards. I think I agree with Laszlo, then. Unless it causes issues with the generated images, the fix can wait until after the stable tag. A very minor regression in build performance does not to me justify added churn during freeze period. Mike, Andrew, what's your take? Best Regards, Leif > > Either way, I'll let the other stewards decide about this. > > > > Thanks > > Laszlo > > > > > This change is to remove the duplicated one. > > > > > > Thanks > > > Liming > > >> -----Original Message----- > > >> From: Wu, Hao A > > >> Sent: Wednesday, May 22, 2019 9:44 AM > > >> To: devel@edk2.groups.io; Gao, Liming > > >> Subject: RE: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules > > >> > > >>> -----Original Message----- > > >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > >>> Liming Gao > > >>> Sent: Tuesday, May 21, 2019 11:22 PM > > >>> To: devel@edk2.groups.io > > >>> Cc: Wu, Hao A > > >>> Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc > > >>> to remove Network related modules > > >>> > > >>> Network related modules have been included in NetworkPkg.dsc. > > >>> They can be removed from MdeModulePkg.dsc. > > >>> > > >>> Signed-off-by: Liming Gao > > >>> Cc: Hao A Wu > > >>> --- > > >>> MdeModulePkg/MdeModulePkg.dsc | 19 ------------------- > > >>> 1 file changed, 19 deletions(-) > > >>> > > >>> diff --git a/MdeModulePkg/MdeModulePkg.dsc > > >>> b/MdeModulePkg/MdeModulePkg.dsc > > >>> index ac7111dea1..995fd805e1 100644 > > >>> --- a/MdeModulePkg/MdeModulePkg.dsc > > >>> +++ b/MdeModulePkg/MdeModulePkg.dsc > > >>> @@ -63,11 +63,6 @@ > > >>> # > > >>> UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > >>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > >>> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > > >>> - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > >>> - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > >>> - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > > >>> - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > >>> > > >>> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL > > >>> ib/DxeSecurityManagementLib.inf > > >>> > > >>> TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem > > >>> plate.inf > > >>> > > >>> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in > > >>> f > > >>> @@ -263,12 +258,8 @@ > > >>> > > >>> MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllo > > >>> cationProfileLib.inf > > >>> > > >>> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.i > > >>> nf > > >>> > > >>> MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32Guided > > >>> SectionExtractLib.inf > > >>> - MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > >>> - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > >>> - MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > > >>> MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > >>> MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf > > >>> - MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > >>> > > >>> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protoco > > >>> l.inf > > >>> > > >>> MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedS > > >>> ectionExtractLib.inf > > >>> MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > > >>> @@ -357,16 +348,6 @@ > > >>> MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > > >>> > > >>> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement > > >>> Dxe.inf > > >>> > > >>> - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > > >>> - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > >>> - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > > >>> - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > >>> - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > >>> - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > >>> - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > >>> - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > > >>> - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > >>> - > > >> > > >> Reviewed-by: Hao A Wu > > >> I will let the stewards to decide whether this can be pushed at this moment. > > >> > > >> Best Regards, > > >> Hao Wu > > >> > > >>> > > >>> MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmen > > >>> tPciCfg2Pei.inf > > >>> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > > >>> MdeModulePkg/Universal/PCD/Pei/Pcd.inf > > >>> -- > > >>> 2.13.0.windows.1 > > >>> > > >>> > > >>> > > > >