From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=AmMXAkPS; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Thu, 23 May 2019 07:14:32 -0700 Received: by mail-wm1-f67.google.com with SMTP id i3so6015716wml.4 for ; Thu, 23 May 2019 07:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VVKFeDfKKVAvE/1VsyqlYsyi6G7YYbp8SkxMIL+s8cs=; b=AmMXAkPSvJ4sctQnKnbdABNcAEpo38982vSzijdre+sxEC/Nt+5PXNZvM9mcIHgVdd gh25K+lKg1Urh07lVNzBWH8jZyQ39XptXxviHLJg/54cgQVPiI4BscPpZgEKzNuX3mTU HnmmW8MRXtDu0b+Ak13UK96WDFetPIcK62hTXRqjAGtKhIUoSy/aySaegLqYlEmWRgH+ Wdt5TmNHP/G5YGrDGHuBkvmBi9WV82/xTii6nSYaYbQ//6h/L0/6GZOF3xUdO8sYCzq+ uEo23IzrbtxBP0hCx0BMFreWTJAS+8YTy486PZICKVivcmJ1fD1ziMuw+j5EsZwMqP3J z8pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VVKFeDfKKVAvE/1VsyqlYsyi6G7YYbp8SkxMIL+s8cs=; b=pGo5zNK1vxomHYb1z30CkcEcaB954+tKUQAXy4yB7ZSXVTJoBL73KQIo0rbUY/+a1a 4ln7RtF41T7iKG9ynlgNWXrNVlo9NLJuEwobBgY7hvwa/rJAoGXZHNf1brx86vp0nyGW i1WhdnJuVM4qeG8r785247OqX/FvknDu6SS3mJfE1GYXAeJG1LfsRUlfZv6yLR+WuQIA 6j+tn6bJ+hHqL7fodaizTedzrz3RHOZ3uZi46nJyKZNGx+Nuq0QgHIrrxpe5+dHXvC1L Lu69JSkeTu2aG/Qr2slzIrSqltn7RaqqUAQ89CPyS3qDVkY2j3biegtq+FKuVrFH0s6T twjQ== X-Gm-Message-State: APjAAAWr4M0RKJC/wwPtIc2R4nPlaEKmVoYqLF+BWsvdlPkmlgVUHhPh 5TCFlVhHaAx3L338VWRfDJv4mQ== X-Google-Smtp-Source: APXvYqxpke7rUwIN1G73IogJCTgYhIjRc8nTQHJDT8UxE4i3l74gFtV//RokkJbT647IhHHZdb9+lw== X-Received: by 2002:a1c:2dd2:: with SMTP id t201mr11882930wmt.136.1558620870158; Thu, 23 May 2019 07:14:30 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v5sm57829966wra.83.2019.05.23.07.14.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 May 2019 07:14:28 -0700 (PDT) Date: Thu, 23 May 2019 15:14:27 +0100 From: "Leif Lindholm" To: Mark Kettenis Cc: Marcin Wojtas , devel@edk2.groups.io, ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com, Jici.Gao@arm.com, rebecca@bluestop.org Subject: Re: [edk2-platforms: PATCH v2 00/14] Armada7k8k PCIE support Message-ID: <20190523141426.rvuqh2nfe3vepm4p@bivouac.eciton.net> References: <1558366047-15994-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 23, 2019 at 03:27:47PM +0200, Mark Kettenis wrote: > > From: Marcin Wojtas > > Date: Mon, 20 May 2019 17:27:13 +0200 > > > > Hi, > > > > Thank you for thorough review of v1. I submit second > > version of the Armada7k8k PCIE support. I addressed > > all comments. There is no functional change to initial > > patchset, but mostly clean-up and improvements - please > > refer to the changelog below. > > > > The patches are available in the github: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/pcie-upstream-r20190520 > > > > I'm looking forward to your comments or remarks. > > > > Best regards, > > Marcin > > Tested this on my mcbin running OpenBSD. It incovers a small issue in > our kernel which I'm fixing. Otherwise this seems to work fine. > > So tested-by: Mark Kettenis if that matters. Always helpful, thanks. Out of interest, what was the issue? Could I still expect the 6.5 installer to run on this hardware/firmware combo? Regards, Leif > Cheers, > > Mark > > > Changelog: > > v1->v2: > > *All > > - s/PcieBaseAddress/PcieDbiAdress/ > > > > *2/14 > > - fix alignment in comment > > > > * 3/14 > > - add CONST** to library callback > > > > * 4/14 > > - add missing reset GPIO to McBin description > > > > * 5/15 > > - add CONST** to protocol callback > > > > * 6/14 > > - cleanup all casting in file > > - use MAX_UINTx macros > > - add Linaro copyright > > - use MmioWrite8 instead of volatile in PciExpressReadBuffer > > - correct commient in IgnoreBusDeviceFunction () > > - fix typo in commit message > > > > * 7/10 > > - correct line endings > > - use temporary variable for memory description in PciHostBridgeResourceConflict > > - use MAX_UINTx macros > > - add comments around stalls and MemoryFence in GPIO reset > > - keep the reset active for 150ms > > - assign translation values instead of asserting > > > > *8/14 > > - assign gArmTokenSpaceGuid.PcdPciIoTranslation value in .dsc > > > > * 9-11/14 > > - correct line endings > > - remove unused methods > > - extend commit messages with 32k shift description > > > > Ard Biesheuvel (1): > > Marvell/Armada7k8k: Add PciExpressLib implementation > > > > Marcin Wojtas (13): > > Marvell/Library: MvGpioLib: Extend GPIO pin description > > Marvell/Library: ArmadaSoCDescLib: Add PCIE information > > Marvell/Library: ArmadaBoardDescLib: Add PCIE information > > Marvell/Armada7k8k: Extend board description libraries with PCIE > > Marvell/Armada7k8k: MvBoardDesc: Extend protocol with PCIE support > > Marvell/Armada7k8k: Implement PciHostBridgeLib > > Marvell/Armada7k8k: Enable PCIE support > > Marvell/Armada80x0McBin: Enable ACPI PCIE support > > Marvell/Armada80x0Db: Enable ACPI PCIE support > > Marvell/Armada70x0Db: Enable ACPI PCIE support > > Marvell/Armada80x0McBin: DeviceTree: Use pci-host-generic driver > > Marvell/Armada7k8k: Remove duplication in .dsc files > > Marvell/Armada7k8: Add 'acpiview' shell command to build > > > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 19 +- > > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 +- > > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 +- > > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 4 +- > > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 5 + > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf | 1 + > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf | 1 + > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin.inf | 1 + > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.inf | 42 + > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf | 52 + > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Pcie.h | 26 + > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Pcie.h | 26 + > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Pcie.h | 26 + > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.h | 95 ++ > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 6 + > > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 46 + > > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 20 + > > Silicon/Marvell/Include/Library/MvGpioLib.h | 1 + > > Silicon/Marvell/Include/Protocol/BoardDesc.h | 22 + > > Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c | 48 + > > Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 4 + > > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c | 48 + > > Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 6 + > > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 54 + > > Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 1 + > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.c | 1531 ++++++++++++++++++++ > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.c | 265 ++++ > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.c | 345 +++++ > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 44 + > > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 86 ++ > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 108 ++ > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Mcfg.aslc | 47 + > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 108 ++ > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Mcfg.aslc | 47 + > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 108 ++ > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Mcfg.aslc | 47 + > > Silicon/Marvell/Armada7k8k/DeviceTree/armada-8040-mcbin.dts | 3 + > > 37 files changed, 3290 insertions(+), 11 deletions(-) > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.inf > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf > > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Pcie.h > > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Pcie.h > > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Pcie.h > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.h > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.c > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.c > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.c > > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Mcfg.aslc > > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Mcfg.aslc > > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Mcfg.aslc > > > > -- > > 2.7.4 > >