public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: devel@edk2.groups.io
Cc: Hao A Wu <hao.a.wu@intel.com>, Ray Ni <ray.ni@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v1 2/6] OvmfPkg/OvmfPkg.dec: Add PcdShellFile in OVMF DEC file
Date: Mon, 27 May 2019 13:19:18 +0800	[thread overview]
Message-ID: <20190527051922.5280-3-hao.a.wu@intel.com> (raw)
In-Reply-To: <20190527051922.5280-1-hao.a.wu@intel.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843

OVMF is currently using the PCD 'PcdShellFile' defined in
IntelFrameworkModulePkg.

This commit will add this PCD into the OVMF DEC file in order to drop
OVMF's dependency on IntelFrameworkModulePkg. The PCD token value 0x17 is
selected to fill the hole (seems the only one left) in OvmfPkg.

Please note that, instead of adding the PCD under section:
[PcdsFixedAtBuild, PcdsPatchableInModule]

as in IntelFrameworkModulePkg.dec file, it is added in section:
[PcdsFixedAtBuild]

in OvmfPkg.dec instead.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
 OvmfPkg/OvmfPkg.dec | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index 9640360f62..38a2d4763d 100644
--- a/OvmfPkg/OvmfPkg.dec
+++ b/OvmfPkg/OvmfPkg.dec
@@ -160,6 +160,9 @@ [PcdsFixedAtBuild]
   #  For the corresponding bits, 0 = Edge triggered and 1 = Level triggered.
   gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0000|UINT16|0x5
 
+  ## FFS filename to find the shell application.
+  gUefiOvmfPkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }|VOID*|0x17
+
   ## Indicates if BiosVideo driver will switch to 80x25 Text VGA Mode when
   #  exiting boot service.
   #   TRUE  - Switch to Text VGA Mode.
-- 
2.12.0.windows.1


  parent reply	other threads:[~2019-05-27  5:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  5:19 [PATCH v1 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency Wu, Hao A
2019-05-27  5:19 ` [PATCH v1 1/6] OvmfPkg/PlatformPei: Remove redundant reference of framework pkg DEC Wu, Hao A
2019-06-13 14:26   ` [edk2-devel] " Laszlo Ersek
2019-05-27  5:19 ` Wu, Hao A [this message]
2019-06-13 14:42   ` [edk2-devel] [PATCH v1 2/6] OvmfPkg/OvmfPkg.dec: Add PcdShellFile in OVMF DEC file Laszlo Ersek
2019-06-14  5:22     ` Wu, Hao A
2019-05-27  5:19 ` [PATCH v1 3/6] OvmfPkg/PlatformBootManagerLib: Use PcdShellFile defined in OvmfPkg Wu, Hao A
2019-05-27  5:19 ` [PATCH v1 4/6] OvmfPkg/DSC: Remove the consume of PcdShellFile in framework package Wu, Hao A
2019-05-27  5:19 ` [PATCH v1 5/6] OvmfPkg/IncompatiblePciDeviceSupportDxe: Drop framework pkg dependency Wu, Hao A
2019-06-13 14:43   ` [edk2-devel] " Laszlo Ersek
2019-05-27  5:19 ` [PATCH v1 6/6] OvmfPkg/Csm/CsmSupportLib: Drop IntelFrameworkPkg dependency Wu, Hao A
2019-06-13 14:45   ` [edk2-devel] " Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190527051922.5280-3-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox