From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ashraf.javeed@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Mon, 27 May 2019 03:25:07 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 03:25:05 -0700 X-ExtLoop1: 1 Received: from pidsbabios005.gar.corp.intel.com ([10.66.128.253]) by orsmga008.jf.intel.com with ESMTP; 27 May 2019 03:25:05 -0700 From: "Javeed, Ashraf" To: devel@edk2.groups.io Cc: Ashraf Javeed , Jian J Wang , Ray Ni Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system Date: Mon, 27 May 2019 15:53:56 +0530 Message-Id: <20190527102356.15164-1-ashraf.javeed@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit https://bugzilla.tianocore.org/show_bug.cgi?id=1796 Bug fixed in PciBusDxe\PciLib.c. Removed the redundant second call to PciSearchDevice sub-routine when the PCD for the Hot-Plug support is disabled. Signed-off-by: Ashraf Javeed Cc: Jian J Wang Cc: Ray Ni --- MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c index f0d9f45c4a..5b55fb5d3b 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c @@ -1114,24 +1114,7 @@ PciScanBus ( // // For PPB // - if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) { - // - // If Hot Plug is not supported, - // get the bridge information - // - Status = PciSearchDevice ( - Bridge, - &Pci, - StartBusNumber, - Device, - Func, - &PciDevice - ); - - if (EFI_ERROR (Status)) { - return Status; - } - } else { + if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) { // // If Hot Plug is supported, // Get the bridge information -- 2.21.0.windows.1