From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=EzOk5UXt; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Mon, 27 May 2019 13:51:58 -0700 Received: by mail-wr1-f65.google.com with SMTP id r7so17928410wrr.13 for ; Mon, 27 May 2019 13:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p3HvCWdvFpCP4Spq29Q6FNAMclr8mv6OCdKs1GFHt0k=; b=EzOk5UXt1WYrlmBSKWd/PDYe5JYNE4WODbIk5hmGM5GK87EE43/pbw8PlR6O1EZa3B c7IZrdEp0FmDP5TOuDhAa+NtA6w4RLPTxwPITz0ulSRrM07aLZIMY5wtPw2gfIN+eRk+ 1QBWnyti4kRgwmMA232FXWNR3jPGBQHb+hbiuqAXQvc4DdUVrgNXyF/teCInJzUypAF5 lCYu7QZ/uJONxC7+trd8t6aYcUg1Y2JAuwOvsQ10ldREP6xB5pkXRVtWP4ZRMLkqXM4b r6/zNB2YRp/3njKya0EilMMUNwrAM8LDLC8xon7TS0iCY/r5U+umVsmID96vUwYNYugY 4rjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p3HvCWdvFpCP4Spq29Q6FNAMclr8mv6OCdKs1GFHt0k=; b=HrzxaWE+qi0xEotDoiP8RuNsL8FRqHtpBUyHmVt1bRzMNfIBFW6eKagWpBaFMdso6N 5rrrOtuLbbeZ60rGof5+tBig+wX9lmJTAQfIH0f2jA4P97vRezLAYfj/CevAMWBrA3PD BaTtttuKxgTuToB6ftUw3M4o5xjVsbqaOz4KM/3Q8k0l/fWxbIh/Oqp/z4ej7XUssEEq VbdbFLLMGkyrbadCsgfBE6KUmQ0J32FdwLLlZMWyR3VUlQaPOc32tx5mvUTj6OgemEgp r161bl6hgTeZzMOA2KytPNr1/UIS3f/2ZkwmTCzCPrECh0sQ0NYEWo1oU/YQULR3qgtn iqnw== X-Gm-Message-State: APjAAAWXQQKsgf5ywZBnFhuQZQC4Bkmg8tleu0msWDczBHsylNLuW9Ty 5yQhPSBXB8yc3PlOtAajC2PDDMDS3lppjQ== X-Google-Smtp-Source: APXvYqxx6PLOJ1YDtNN5qI/s/pUulwSBbzNa1eI1AlxblFXINuD7feGrBtIIUq4Enss/h94b5QyT5w== X-Received: by 2002:adf:f38a:: with SMTP id m10mr28949332wro.81.1558990315747; Mon, 27 May 2019 13:51:55 -0700 (PDT) Return-Path: Received: from sudo.home ([2a01:cb1d:112:6f00:ccdd:dadc:1517:f416]) by smtp.gmail.com with ESMTPSA id n1sm894808wrx.39.2019.05.27.13.51.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 May 2019 13:51:55 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Laszlo Ersek , "Gao, Liming" , "Wang, Jian J" , Leif Lindholm , Michael D Kinney Subject: [PATCH v2 7/7] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S Date: Mon, 27 May 2019 22:51:41 +0200 Message-Id: <20190527205141.12344-8-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190527205141.12344-1-ard.biesheuvel@linaro.org> References: <20190527205141.12344-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clang 7 complains about the vmsr instruction in ArmV7Support.S, which is only available on cores that implement some flavour of VFP. So set the .fpu to NEON like we do in some other places. Signed-off-by: Ard Biesheuvel --- Note that the !clang alternative does not assembler for Clang-7 either so this is probably the most straightforward approach. ArmPkg/Library/ArmLib/Arm/ArmV7Support.S | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S b/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S index 16c56f72e973..b5a6b9ea487d 100644 --- a/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S +++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S @@ -262,6 +262,7 @@ ASM_FUNC(ArmEnableVFP) #ifndef __clang__ mcr p10,#0x7,r0,c8,c0,#0 #else + .fpu neon vmsr fpexc, r0 #endif bx lr -- 2.20.1