public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: devel@edk2.groups.io
Cc: Agyeman Prince <prince.agyeman@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Michael Kubacki <michael.a.kubacki@intel.com>
Subject: [PATCH] Platform/Intel: Add fspapi build parameter
Date: Tue, 28 May 2019 15:52:20 +0800	[thread overview]
Message-ID: <20190528075220.12576-1-chasel.chiu@intel.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1824

Going forward FSP Dispatch mode will be default in
KabylakeOpenBoardPkg and requires fspapi build parameter
to switch back to FSP API mode.
When --fspapi given to build python script it will set
gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection to
1, otherwise the PCD will be the default value defined
by each *BoardPkg.

Test: verified the PCD PcdFspModeSelection can be
      overridden by new build parameter.

Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 Platform/Intel/build_bios.py | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py
index 9effefc0c7..9f8d78f6e8 100644
--- a/Platform/Intel/build_bios.py
+++ b/Platform/Intel/build_bios.py
@@ -359,6 +359,11 @@ def build(config):
         command.append("-D")
         command.append("MAX_SOCKET=" + config["MAX_SOCKET"])
 
+    if config.get("API_MODE_FSP_WRAPPER_BUILD", "FALSE") == "TRUE":
+        #Override PCD to enable API mode FSP wrapper.
+        command.append("--pcd")
+        command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection=1")
+
     shell = True
     if os.name == "posix":
         shell = False
@@ -840,6 +845,9 @@ def get_cmd_config_arguments(arguments):
     if arguments.fsp is True:
         result["FSP_WRAPPER_BUILD"] = "TRUE"
 
+    if arguments.fspapi is True:
+        result["API_MODE_FSP_WRAPPER_BUILD"] = "TRUE"
+
     return result
 
 
@@ -910,9 +918,12 @@ def get_cmd_arguments(build_config):
     parser.add_argument("--performance", help="performance build enabled",
                         action='store_true', dest="performance")
 
-    parser.add_argument("--fsp", help="fsp build enabled",
+    parser.add_argument("--fsp", help="fsp wrapper build enabled",
                         action='store_true', dest="fsp")
 
+    parser.add_argument("--fspapi", help="API mode fsp wrapper build enabled",
+                        action='store_true', dest="fspapi")
+
     return parser.parse_args()
 
 
-- 
2.13.3.windows.1


             reply	other threads:[~2019-05-28  7:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  7:52 Chiu, Chasel [this message]
2019-05-29  0:45 ` [PATCH] Platform/Intel: Add fspapi build parameter Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528075220.12576-1-chasel.chiu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox