[PATCH] Platform/Intel: Add fspapi build parameter

[PATCH] Platform/Intel: Add fspapi build parameter

[Chiu, Chasel]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1824

Going forward FSP Dispatch mode will be default in
KabylakeOpenBoardPkg and requires fspapi build parameter
to switch back to FSP API mode.
When --fspapi given to build python script it will set
gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection to
1, otherwise the PCD will be the default value defined
by each *BoardPkg.

Test: verified the PCD PcdFspModeSelection can be
      overridden by new build parameter.

Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 Platform/Intel/build_bios.py | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py
index 9effefc0c7..9f8d78f6e8 100644
--- a/Platform/Intel/build_bios.py
+++ b/Platform/Intel/build_bios.py
@@ -359,6 +359,11 @@ def build(config):
         command.append("-D")
         command.append("MAX_SOCKET=" + config["MAX_SOCKET"])
 
+    if config.get("API_MODE_FSP_WRAPPER_BUILD", "FALSE") == "TRUE":
+        #Override PCD to enable API mode FSP wrapper.
+        command.append("--pcd")
+        command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection=1")
+
     shell = True
     if os.name == "posix":
         shell = False
@@ -840,6 +845,9 @@ def get_cmd_config_arguments(arguments):
     if arguments.fsp is True:
         result["FSP_WRAPPER_BUILD"] = "TRUE"
 
+    if arguments.fspapi is True:
+        result["API_MODE_FSP_WRAPPER_BUILD"] = "TRUE"
+
     return result
 
 
@@ -910,9 +918,12 @@ def get_cmd_arguments(build_config):
     parser.add_argument("--performance", help="performance build enabled",
                         action='store_true', dest="performance")
 
-    parser.add_argument("--fsp", help="fsp build enabled",
+    parser.add_argument("--fsp", help="fsp wrapper build enabled",
                         action='store_true', dest="fsp")
 
+    parser.add_argument("--fspapi", help="API mode fsp wrapper build enabled",
+                        action='store_true', dest="fspapi")
+
     return parser.parse_args()
 
 
-- 
2.13.3.windows.1

Re: [PATCH] Platform/Intel: Add fspapi build parameter

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Chiu, Chasel 
Sent: Tuesday, May 28, 2019 12:52 AM
To: devel@edk2.groups.io
Cc: Agyeman, Prince <prince.agyeman@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>
Subject: [PATCH] Platform/Intel: Add fspapi build parameter

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1824

Going forward FSP Dispatch mode will be default in KabylakeOpenBoardPkg and requires fspapi build parameter to switch back to FSP API mode.
When --fspapi given to build python script it will set gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection to 1, otherwise the PCD will be the default value defined by each *BoardPkg.

Test: verified the PCD PcdFspModeSelection can be
      overridden by new build parameter.

Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 Platform/Intel/build_bios.py | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index 9effefc0c7..9f8d78f6e8 100644
--- a/Platform/Intel/build_bios.py
+++ b/Platform/Intel/build_bios.py
@@ -359,6 +359,11 @@ def build(config):
         command.append("-D")
         command.append("MAX_SOCKET=" + config["MAX_SOCKET"])
 
+    if config.get("API_MODE_FSP_WRAPPER_BUILD", "FALSE") == "TRUE":
+        #Override PCD to enable API mode FSP wrapper.
+        command.append("--pcd")
+        
+ command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection=1"
+ )
+
     shell = True
     if os.name == "posix":
         shell = False
@@ -840,6 +845,9 @@ def get_cmd_config_arguments(arguments):
     if arguments.fsp is True:
         result["FSP_WRAPPER_BUILD"] = "TRUE"
 
+    if arguments.fspapi is True:
+        result["API_MODE_FSP_WRAPPER_BUILD"] = "TRUE"
+
     return result
 
 
@@ -910,9 +918,12 @@ def get_cmd_arguments(build_config):
     parser.add_argument("--performance", help="performance build enabled",
                         action='store_true', dest="performance")
 
-    parser.add_argument("--fsp", help="fsp build enabled",
+    parser.add_argument("--fsp", help="fsp wrapper build enabled",
                         action='store_true', dest="fsp")
 
+    parser.add_argument("--fspapi", help="API mode fsp wrapper build enabled",
+                        action='store_true', dest="fspapi")
+
     return parser.parse_args()
 
 
--
2.13.3.windows.1