From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=uQJf0JwJ; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Tue, 28 May 2019 10:58:18 -0700 Received: by mail-wr1-f67.google.com with SMTP id r7so21207067wrr.13 for ; Tue, 28 May 2019 10:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zXczEt4NVLZx9qv9l4QxyEfkiG3AXkwVdNP9CoBWNlY=; b=uQJf0JwJ41cMN9ao6gD4Ap9AP6qLY082NEy11WhIKpj2OQJ6irMruaCUCgNEiuhDjq s0yovHqaCBJpzphRz/IX5cASY6FZxrBgkJDJ/KJCszFwt/rGtORvdh5dPdZ+LjR/SbaJ PW1jA3o5FRFbNEGLdI+DIoKYMoaU0mPeGwIHDvmeiFB02j/zW2QSLtsbPVIh8Pg6qr6V tqyr/JCGrRUxLtbPYJ48XDRw1i0yeFfqAxmEHhIIvU7tqj8Z+iFe8DX9bcznCju15ee3 Be5o8v3oRuQpKVZNUt2w/U/T3a+FV6lr6syGWkKtaz+f9bTfm/mjbXyG4nT8vbFWLykK t9ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zXczEt4NVLZx9qv9l4QxyEfkiG3AXkwVdNP9CoBWNlY=; b=hhMTo4jJwnEHC6qjjwVqj8CWw5dOMZI07ii09oq5zO+nyzpmMuPdrkVbS6a1uzzO+i Jkvbq+Gh1O4G0+SuuMNdmZp4R2ziMt+bb6+u1GBqhOB95JEBUrnAuJtVlcDoDWi4uIA3 i07YdzgLB6yyki9bf341C8bAbV4iutV5rG+ad6D9HdHuN4CH8q2EKIKDbELIL39ikRUV /vzjYVgAEohRd7sPfbI2udR53RSe7Ucgw4mf4iOtSw3U6j5vDxD9aCEN5IgTfRFMyrU5 rEbY1KwPVQSeVwuOYMUMsDNCemKHSnhpTW/wm7QLksxXf/uOvgXQZKsn3V2IwDXxbJUc Vlqg== X-Gm-Message-State: APjAAAUbepGCskuHEJDC90FbA1oGgjNeiQW+VlHeKoOLPqqKf0MfHQKQ UN5MkEJ+ktB79KzsMSMHBhaXEoYSVcI= X-Google-Smtp-Source: APXvYqysnOSnhWoRl/9SXenG0yO5xhwCES0/FZtVG60hUTkpP8Ex0ffW/15oBhNUgY/HcA/TVHrzDQ== X-Received: by 2002:adf:cf03:: with SMTP id o3mr15712106wrj.5.1559066296270; Tue, 28 May 2019 10:58:16 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n4sm17648412wrp.61.2019.05.28.10.58.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 10:58:15 -0700 (PDT) Date: Tue, 28 May 2019 18:58:14 +0100 From: "Leif Lindholm" To: tien.hock.loh@intel.com Cc: devel@edk2.groups.io, thloh85@gmail.com, Ard Biesheuvel Subject: Re: [PATCH v2 4/7] EmbeddedPkg: Fix response check flag Message-ID: <20190528175814.q3amqqnknfbvcfbw@bivouac.eciton.net> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> <1558949428-190715-5-git-send-email-tien.hock.loh@intel.com> MIME-Version: 1.0 In-Reply-To: <1558949428-190715-5-git-send-email-tien.hock.loh@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 27, 2019 at 05:30:25PM +0800, tien.hock.loh@intel.com wrote: > From: "Tien Hock, Loh" > > Do not send CRC response check if the MMC command does not support CRC > response > > Signed-off-by: Tien Hock, Loh > Cc: Leif Lindholm > Cc: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c > index c44e310c04..e0068655ca 100644 > --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c > +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c > @@ -385,7 +385,7 @@ DwEmmcSendCommand ( > BIT_CMD_READ | BIT_CMD_WAIT_PRVDATA_COMPLETE; > break; > default: > - Cmd = BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC; > + Cmd = BIT_CMD_RESPONSE_EXPECT; > break; > } > > @@ -396,6 +396,10 @@ DwEmmcSendCommand ( > else > IsACmd = FALSE; > > + if (!(MmcCmd & MMC_CMD_NO_CRC_RESPONSE)) { > + Cmd |= BIT_CMD_CHECK_RESPONSE_CRC; > + } > + > if (IsPendingReadCommand (Cmd) || IsPendingWriteCommand (Cmd)) { > mDwEmmcCommand = Cmd; > mDwEmmcArgument = Argument; > -- > 2.19.0 >