public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: tien.hock.loh@intel.com
Cc: devel@edk2.groups.io, thloh85@gmail.com,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 5/7] EmbeddedPkg: Clear CTYPE on initialization
Date: Tue, 28 May 2019 18:58:37 +0100	[thread overview]
Message-ID: <20190528175837.s2kquktagnnw7c65@bivouac.eciton.net> (raw)
In-Reply-To: <1558949428-190715-6-git-send-email-tien.hock.loh@intel.com>

On Mon, May 27, 2019 at 05:30:26PM +0800, tien.hock.loh@intel.com wrote:
> From: "Tien Hock, Loh" <tien.hock.loh@intel.com>
> 
> Clear CTYPE on initialization. This is important if previous bootloader
> changes the CTYPE can cause the controller to not initialize correctly
> if CTYPE is not reset to 0
> 
> Signed-off-by: "Tien Hock, Loh" <tien.hock.loh@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
> index e0068655ca..c6c8e04917 100644
> --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
> +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
> @@ -205,6 +205,7 @@ DwEmmcNotifyState (
>      MmioWrite32 (DWEMMC_TMOUT, ~0);
>      MmioWrite32 (DWEMMC_IDINTEN, 0);
>      MmioWrite32 (DWEMMC_BMOD, DWEMMC_IDMAC_SWRESET);
> +    MmioWrite32 (DWEMMC_CTYPE, 0);
>  
>      MmioWrite32 (DWEMMC_BLKSIZ, DWEMMC_BLOCK_SIZE);
>      do {
> -- 
> 2.19.0
> 

  reply	other threads:[~2019-05-28 17:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  9:30 [PATCH v2 0/7] Fix some bugs with DwEmmc Loh, Tien Hock
2019-05-27  9:30 ` [PATCH v2 1/7] EmbeddedPkg: Add SD command support for DwEmmc Loh, Tien Hock
2019-05-28 17:37   ` Leif Lindholm
2019-05-27  9:30 ` [PATCH v2 2/7] EmbeddedPkg: Fix DwEmmc CMD8 support for SD Loh, Tien Hock
2019-05-28 17:45   ` Leif Lindholm
2019-05-27  9:30 ` [PATCH v2 3/7] EmbeddedPkg: Send command when MMC ask for response Loh, Tien Hock
2019-05-28 17:56   ` Leif Lindholm
2019-05-27  9:30 ` [PATCH v2 4/7] EmbeddedPkg: Fix response check flag Loh, Tien Hock
2019-05-28 17:58   ` Leif Lindholm
2019-05-27  9:30 ` [PATCH v2 5/7] EmbeddedPkg: Clear CTYPE on initialization Loh, Tien Hock
2019-05-28 17:58   ` Leif Lindholm [this message]
2019-05-27  9:30 ` [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling Loh, Tien Hock
2019-05-28 18:04   ` Leif Lindholm
2019-05-30  7:05     ` Haojian Zhuang
2019-05-30  7:56       ` Loh, Tien Hock
2019-06-11  2:40         ` Loh, Tien Hock
2019-06-11  9:08           ` Leif Lindholm
2019-06-11  9:12             ` Loh, Tien Hock
2019-07-12  5:40               ` Loh, Tien Hock
2019-05-27  9:30 ` [PATCH v2 7/7] EmbeddedPkg: Fix DwEmmc read/write size in preparing DMA size Loh, Tien Hock
2019-05-28 17:50   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528175837.s2kquktagnnw7c65@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox