From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=RPMZI3jQ; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Tue, 28 May 2019 10:58:41 -0700 Received: by mail-wr1-f68.google.com with SMTP id w13so12871208wru.11 for ; Tue, 28 May 2019 10:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1c7ifQ6cBMc6wW9D84HBQ3eQHSLN5deuhtAO95UN4FY=; b=RPMZI3jQxi9UH7iBsvYehiwn7wkIkE7823g4BwG5UULhtZf0NmTFsr5no5o3ArsPeM 4z/idmDRqyJhCP0wSl2DpA7dAiFFS+Eh59JhCKUvI8P38ctKwgUL6m6et+fb5+QLluEU m4GyopRRWVptKvuGxJFCw/VnpbaN0aFJa+qVb4xmKcdmZO7hX58IPkC0wT7CYGn0LVf6 1QDaifuLMoT0vtZ7a1NdP+BN2qibFP3XBd/Fu/YZVEittRjiODUOwYXw7OUb7LCqEP54 Y47TdfDPipSIiGMHfIu7fmlHj81cV79+hEqCPnHfaRucXHkRZaIgFdoBX754iu5oA4eC Uslg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1c7ifQ6cBMc6wW9D84HBQ3eQHSLN5deuhtAO95UN4FY=; b=QnidvWtAJBtxbRDguO+xd4D25Z6+m/SVyMePv7opXNnhaCvaXw8YryCLzeDyuK89bT pkl4CbRn8qZpxP5/0ZVN/D8lzrO/j78AykoHsUF5C/fW9rXovUcWKPJg1gR6o7NxF3Ca qXKVAIX4K73RZ/IOAXNQJzcklsAC3D7zrc9cfiu79dpV+F5G7ZAmt0O9OxKOJ5n+SX5K pybFc8tuFMbG9T79ZeuuIIlJRI3XCEbp/8uTSIUmc117rorVWPQTfUXpKc+C1Rcf+dlv dOizE1Jam5Avjm+LexDrHVbpNZCk8tJNTSsYBxKRcjXaYQpKnvVbmnkH26xrR2BBOEm7 Yu8g== X-Gm-Message-State: APjAAAV9NUPNcmgSgUxYImKxcaqJCHBaBLb+1hkUe4XuNBDGJaRE/zZt h+zim1EhfWSshXmtsaUnj4TR+w== X-Google-Smtp-Source: APXvYqwBPb86J6S+kUAhA5366whIq9dvj7tHxKLEJ+xcI7agInOPdhbPd6c95vyWqkycRcNKMIyzew== X-Received: by 2002:a5d:5108:: with SMTP id s8mr1513900wrt.341.1559066319670; Tue, 28 May 2019 10:58:39 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g185sm2455779wmf.30.2019.05.28.10.58.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 10:58:38 -0700 (PDT) Date: Tue, 28 May 2019 18:58:37 +0100 From: "Leif Lindholm" To: tien.hock.loh@intel.com Cc: devel@edk2.groups.io, thloh85@gmail.com, Ard Biesheuvel Subject: Re: [PATCH v2 5/7] EmbeddedPkg: Clear CTYPE on initialization Message-ID: <20190528175837.s2kquktagnnw7c65@bivouac.eciton.net> References: <1558949428-190715-1-git-send-email-tien.hock.loh@intel.com> <1558949428-190715-6-git-send-email-tien.hock.loh@intel.com> MIME-Version: 1.0 In-Reply-To: <1558949428-190715-6-git-send-email-tien.hock.loh@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 27, 2019 at 05:30:26PM +0800, tien.hock.loh@intel.com wrote: > From: "Tien Hock, Loh" > > Clear CTYPE on initialization. This is important if previous bootloader > changes the CTYPE can cause the controller to not initialize correctly > if CTYPE is not reset to 0 > > Signed-off-by: "Tien Hock, Loh" > Cc: Leif Lindholm > Cc: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c > index e0068655ca..c6c8e04917 100644 > --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c > +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c > @@ -205,6 +205,7 @@ DwEmmcNotifyState ( > MmioWrite32 (DWEMMC_TMOUT, ~0); > MmioWrite32 (DWEMMC_IDINTEN, 0); > MmioWrite32 (DWEMMC_BMOD, DWEMMC_IDMAC_SWRESET); > + MmioWrite32 (DWEMMC_CTYPE, 0); > > MmioWrite32 (DWEMMC_BLKSIZ, DWEMMC_BLOCK_SIZE); > do { > -- > 2.19.0 >