From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=JRi6X8NL; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Wed, 29 May 2019 04:09:04 -0700 Received: by mail-wr1-f68.google.com with SMTP id x4so1453399wrt.6 for ; Wed, 29 May 2019 04:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=H4iiSSSLLNjBHUw59uDL2wQQzeEph52Sw/9KZGRDzbg=; b=JRi6X8NLFwZtgYhD5O9fUe+DtVIm0SxM6Pc2ocJeAZc68H80SUZFnZQxMv0sORODlT +nwFrKUGe1v3R95HMHdOLA1Eb9CW/XOpjAZoSkYorCqYMaB3gbLlr+Mo3YFNKz0UntyB CQNIX2OHaDA+U+n3hO3EHNXz7Ri9/Zuv5+x3a/oY5EJESfNLsbYMJGkeg2ffZLgJjS7p r+vnh9q5RpUi3uTflqaS4gyylgXdUcIDjiycbtrraRVaVXtFqoborGnL1iWxhbK4uPs3 zSaLKEShWK/xRdBe06UfN/xr2w+mbFy35zrgj7DGpHXPaREKCbug9YwQqzAzfSO+UceL fdWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H4iiSSSLLNjBHUw59uDL2wQQzeEph52Sw/9KZGRDzbg=; b=ISxhJMOJjjx8m9SOQ9VU9AXuYCWirmZX5P7r8BH6fwAKyjmWZlDrRwlZTUmmEs1+1g myRfxxlIq3ONb1KL6/pgg10EUFY4myzV+wsMtHYqgCxQuKEbfnde9PkfqHg09lqyah79 mbodpYqAoIXxfaa1XYwPdOqYRTSnFo+WTadpIrSnMhRCcj3YEZ5hhqjwZNFUJ8qXj795 TnzqR5QlofY7cjZ53rXcrsctrT6R6MbIn/tLSrVuIAZughAbAv9Kkeopo2FDuyrS8rVg LZJE0SVPGhCwzg7GBUVxMapO2zAUSf4F5lO/Ymd+5633cGby7XdZcyOcR7fAcSY8uIlU Js0g== X-Gm-Message-State: APjAAAXDdW0a/jr41zjtyRdSem4XfYZ0/zEILX6V7ZlChRj8GgBsreu8 J9SuXphD5iLUkh/1WcO3kROZeTLr36k= X-Google-Smtp-Source: APXvYqxDCiGMuCjFhT4G2naNm2lavLyulCY+avnQEHLkT7WkrQEjwEskDc/G1FxJb9BEi/2Ly7v/XQ== X-Received: by 2002:adf:f00d:: with SMTP id j13mr2711871wro.178.1559128142510; Wed, 29 May 2019 04:09:02 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b12sm6156849wmg.27.2019.05.29.04.09.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 04:09:01 -0700 (PDT) Date: Wed, 29 May 2019 12:09:00 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, jeremy.linton@arm.com Cc: mw@semihalf.com, ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [PATCH] Marvell/Armada80x0McBin: Enable usb keyboard, nvme boot Message-ID: <20190529110900.auikhgb55w3uual4@bivouac.eciton.net> References: <20190528234313.28331-1-jeremy.linton@arm.com> MIME-Version: 1.0 In-Reply-To: <20190528234313.28331-1-jeremy.linton@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 28, 2019 at 06:43:13PM -0500, Jeremy Linton wrote: > Add a USB keyboard flag, which is needed when a graphical console > is enabled. Also add a nvme boot option for users that choose > that instead of sata or mmc. > > Contributed-under: TianoCore Contribution Agreement 1.1 Just a note in case you had missed: We are transitioning the licensing of edk2-platforms to https://spdx.org/licenses/BSD-2-Clause-Patent (As of yesterday) we have approval from Marvell to relicense these files, so future contributions won't need the Contributed-under. (This one does, though.) > Signed-off-by: Jeremy Linton Reviewed-by: Leif Lindholm However, the patch is garbled (lines broken and '=20' all over the place). Could you have a look at your email setup or point me at a (public) remote tree? (It's possible your mail server will stop playing silly if you strip the CRs - and SMTP eats those anyway, so I have a script to add them back in.) ((It's also possible it's groups.io that's messing things up - you could work around that by cc:ing me :)) / Leif > --- > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++ > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > index 27e52f5af5..89d617fde4 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > @@ -90,6 +90,7 @@ > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > + UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > > @@ -505,6 +506,7 @@ > MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > # SD/MMC > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf > @@ -516,6 +518,7 @@ > ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > > # Console packages > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > index 47e3bc4f82..f59cc1f263 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > @@ -151,6 +151,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > # SD/MMC > INF MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf > @@ -162,6 +163,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > INF ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf > INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > > # Multiple Console IO support > INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > -- > 2.13.7 > > > >