From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=whRu/LPA; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Wed, 29 May 2019 04:13:40 -0700 Received: by mail-wr1-f67.google.com with SMTP id h1so1475192wro.4 for ; Wed, 29 May 2019 04:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ICV1qcL6iLNvdDHRzN8jqQKcyPdaE30SP+h3VwLL4DA=; b=whRu/LPAeX7VMMNVIm6tQE3MiogSC7piX0w0LMjQBe1VDkCFBm1kN9XjGXIuQEAoAU a4JeZKLUjTfz2cv3PCk/+zVGCzVBb8hj4YFo6TIYgW/v673J9KiRwSRfcjbbio903otk 2CA7I23FqqLKBF9+HySamo81nuqVPIa3/Og6SGEP98s3/Fxhn32Yc1pSnyoFhcLXTs3/ FixdbQnHzyKJ10RhJaRQb4H2kgu1Uukc+eR67Kmq+61nHXoKeBDkALkSX6nj6pPUSVco UGSfecKS7B41WWmC/39KIHJ+AemamQsiS3+0bxrBhbLfSUoOJcxhoJu7iRC3ztU6kPB7 ZycA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ICV1qcL6iLNvdDHRzN8jqQKcyPdaE30SP+h3VwLL4DA=; b=WDstifoxdg7bKO/pvmjFhNW/AuyWb13tEODz0LCl2XUEbM6Uq/fzKG7gu9UevAkCRc 9W3w2Rr6q4zJVvQ6VFrzWf7VDSUh32Gp5CTcg+RapF3UBWr0O5+MZp0NMBxEuwC2iJPL dSBehwxHd+tm+wvkGLoJY/hjUmGHOlZ1Alb4jHw1NAQ0J6GqL0blZ4ZXCU/x0AKOgDQj 4df63Sq2xPXjZj0VHeU86HYn5UaWf9wxBAY9qsL+6KaHrOsu44IFhuwgPzM0p8UjBqjf JSR9LwD3EYTulNWPsjOGx0iA4sBeYiXsWlixUiOJPECIQW80DQJJHYbh8vFuO6uebVm5 L4pg== X-Gm-Message-State: APjAAAViyglETtRU8+l1ZHmwmeTFyL77pSkS34be9RbnmZCdanNZNt1N YzJYw46lliWdgf6csq3AkWuNrtnP7v8= X-Google-Smtp-Source: APXvYqyw1zLqqq2flGswCQ1N1/JuhPCoEvcqDF66m/CNXj3wpSZUFkZdFIe4+iPvS8pXfpYHhO5j4Q== X-Received: by 2002:a5d:45c4:: with SMTP id b4mr18379624wrs.291.1559128418906; Wed, 29 May 2019 04:13:38 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y1sm3843139wma.14.2019.05.29.04.13.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 04:13:38 -0700 (PDT) Date: Wed, 29 May 2019 12:13:36 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, steven.shi@intel.com Cc: liming.gao@intel.com, bob.c.feng@intel.com, christian.rodriguez@intel.com, zhijux.fan@intel.com Subject: Re: [edk2-devel] [PATCH v2] BaseTools:Extend the binary cache to support library cache Message-ID: <20190529111336.5o3yfhzt73s5yohd@bivouac.eciton.net> References: <20190529014654.23276-1-steven.shi@intel.com> MIME-Version: 1.0 In-Reply-To: <20190529014654.23276-1-steven.shi@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 29, 2019 at 09:46:54AM +0800, Steven Shi wrote: > V2 change: > Simplify the library cache implementation and remove > CacheRestored flag based filter. Use the current > CanSkipbyHash() filter in AddDependency() instead. > > V1 change: Please don't put change notices in the commit message. These go below ---, or in a cover letter. / Leif > > https://bugzilla.tianocore.org/show_bug.cgi?id=1797 > > Current binary cache doesn't support to save and restore > the library module. If a driver module cache miss happen, > all its dependency library modules need rebuild which > is very time-consuming. This patch is to entend the binary > cache to support library. > > Cc: Liming Gao > Cc: Bob Feng > Cc: Christian Rodriguez > Signed-off-by: Steven Shi > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py > index a5bef4f7c6..7b35f837f5 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -3906,6 +3906,12 @@ class ModuleAutoGen(AutoGen): > ModuleFile = path.join(self.OutputDir, self.Name + '.inf') > if os.path.exists(ModuleFile): > shutil.copy2(ModuleFile, FileDir) > + else: > + OutputDir = self.OutputDir.replace('\\', '/').strip('/') > + DebugDir = self.DebugDir.replace('\\', '/').strip('/') > + for Item in self.CodaTargetList: > + File = Item.Target.Path.replace('\\', '/').strip('/').replace(DebugDir, '').replace(OutputDir, '').strip('/') > + self.OutputFile.add(File) > if not self.OutputFile: > Ma = self.BuildDatabase[self.MetaFile, self.Arch, self.BuildTarget, self.ToolChain] > self.OutputFile = Ma.Binaries > -- > 2.17.1.windows.2 > > > >