From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=vcG1NtdO; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Wed, 29 May 2019 07:43:57 -0700 Received: by mail-wm1-f68.google.com with SMTP id t5so1806366wmh.3 for ; Wed, 29 May 2019 07:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RlPND+HBE+SXC9W2xTXXXcInmtYkUADEKxr8Qztis0s=; b=vcG1NtdOqatoP/8H0fR1WWo305G8z/gSnX7mCOzdM0FGAEh/9tc5QyApezqZjcfOCX yDzr+wSpHaKRU2HlecWLDReVi0laCYwX3tyPNdTcRpJ5UQMJTjTwJ9wtUa0VVL9bXH1s agJp2xtS6c39VPvWk61pXu1exikA9oIV37/pDKOOuPbAFYaxYv8Bwuwybn68doPLRn7w MIQgiryALUkwi6ZElSdlK6bY2R9NxXUaWRM7eziV74/kJ2aLBzrOSzO8UEAbnRXGkkYF XbeQueupybWNQpd5wYZUWRy+wEty+a8IcBgGkwb2M6PAe/jbijaVQWdGBXEiQLNyVrZw n5sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RlPND+HBE+SXC9W2xTXXXcInmtYkUADEKxr8Qztis0s=; b=iqHwosN5Ulk+sj0GA6s1i7emrACuh1KMYBjH0HkZxGXVRZX4JDITHGIzphTqJZo3lh FZTN8lkBBZZRarsylh95Q6L6jp+VhBMvtwVNmgg1h5HlyXLuusfJ6zQ/l/+rQhs0VlD9 JBNC70LbylyfgCK4KlMxEJ8e72wV7v3z7gpxPsEJdsiTBnPhLbDSYqeZM4f/cyh6x8ch ExjGzuUYTyKSvHIyOPres+JJWUINOOclCxIxShuzTGs44V+++yQfIo4rF82LDqTXWxNG 3QQKrS3SlWzV9m0PZ/HThoZqQHNQzT/sQkGmdQOFafguTCNvxf+gG8V9ZhfiHbl92wOB no6g== X-Gm-Message-State: APjAAAVN4GHLrJlAAobgB+eUxfvR05MDy+JG/Vwzqjo1EJUTOPfBFzqU m+QxaDh9oTI6QLfWE11g3L1uNrGf6nw= X-Google-Smtp-Source: APXvYqxkQGhDtt5YnFmQ5tQ4PxWpb9spuCEmc7rBg8YnMYac6zHBkqV7t09pZ5OYBQZWBVOZUTRI0g== X-Received: by 2002:a05:600c:506:: with SMTP id i6mr7167349wmc.57.1559141035670; Wed, 29 May 2019 07:43:55 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l6sm4413530wmi.24.2019.05.29.07.43.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 07:43:54 -0700 (PDT) Date: Wed, 29 May 2019 15:43:53 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, ard.biesheuvel@linaro.org Cc: Masahisa Kojima Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/Secure96Dxe: redefine LS connector CS as platform property Message-ID: <20190529144353.lcg3f6ygnalkuatn@bivouac.eciton.net> References: <20190529125021.28308-1-ard.biesheuvel@linaro.org> <20190529125021.28308-4-ard.biesheuvel@linaro.org> <20190529130652.pkfzeo5xbcotypaf@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 29, 2019 at 03:14:48PM +0200, Ard Biesheuvel wrote: > On Wed, 29 May 2019 at 15:06, Leif Lindholm wrote: > > > > On Wed, May 29, 2019 at 02:50:19PM +0200, Ard Biesheuvel wrote: > > > As opposed to the Secure96's I2C peripherals, whose bus addresses are > > > properties of the peripherals themselves, the SPI CS address of the > > > TPM is a property of the platform that incorporates the LS connector. > > > > > > So tweak the macros that emit the CS values and related properties > > > to put it under the control of the platform that incorporates the > > > driver. > > > > > > Signed-off-by: Ard Biesheuvel > > > --- > > > Platform/96Boards/Secure96Dxe/Secure96.dts | 2 +- > > > Platform/96Boards/Secure96Dxe/Secure96.h | 11 ++++++++--- > > > 2 files changed, 9 insertions(+), 4 deletions(-) > > > > > > diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts > > > index d066fcb1933c..0d7d9b3900a4 100644 > > > --- a/Platform/96Boards/Secure96Dxe/Secure96.dts > > > +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts > > > @@ -39,7 +39,7 @@ > > > __overlay__ { > > > INFINEON_SLB9670_DT_NODENAME { > > > compatible = "infineon,slb9670"; > > > - reg = ; > > > + reg = ; > > > spi-max-frequency = <22500000>; > > > }; > > > }; > > > diff --git a/Platform/96Boards/Secure96Dxe/Secure96.h b/Platform/96Boards/Secure96Dxe/Secure96.h > > > index c34fc5eea046..1d8bf4159209 100644 > > > --- a/Platform/96Boards/Secure96Dxe/Secure96.h > > > +++ b/Platform/96Boards/Secure96Dxe/Secure96.h > > > @@ -1,6 +1,6 @@ > > > /** @file > > > > > > - Copyright (c) 2018, Linaro, Ltd. All rights reserved.
> > > + Copyright (c) 2018-2019, Linaro, Ltd. All rights reserved.
> > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > **/ > > > @@ -8,14 +8,19 @@ > > > #ifndef _SECURE96_H_ > > > #define _SECURE96_H_ > > > > > > +#define __CONCAT(a,b) a ## b > > > + > > > > Urgh. We badly need to properly add some official macros for this. > > You could possibly use __CONCATENATE from Base.h. > > > > OK, I'll use that instead. With that, for 1-4/5: Reviewed-by: Leif Lindholm > > For new macros, we really should avoid leading _. > > > > True. > > >