From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=D6ykr7/t; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Wed, 29 May 2019 08:09:15 -0700 Received: by mail-wr1-f67.google.com with SMTP id c2so2042701wrm.8 for ; Wed, 29 May 2019 08:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZF7D1wwhmRgthmPHjfuedDmmc20IyHB6QZGYGZ0mGsU=; b=D6ykr7/tnOHjkHDdatZAxbPHsOB7WM2nedrC9WiPawDlkxiWX18Pgjvb83dbt5ADCP LJ8g6uFfkMyErfjAcKfs8+rwWxeuPJ9ibsvD6wo/6Du1ttQ1adICXydJwM5oH7oETYlC S1u71eoHHVA2Mc+NAJHesCi1RovwfkTzC0Pqo+sODWaRk+ZlV2f4sD3roeP5xRH/kUhP nZgv5l9FCaUCaWwpRmIw0e+t5wwvBVy34QP4t/5b74rRUAC14tOgODCcf8+SNxofo9gU Dq5/s0Su78UHNh4d9P7av1V9DCxjmYKS4GeQty4+gkLfV88POQjQT+7CbNXe4aLIls+N NiSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZF7D1wwhmRgthmPHjfuedDmmc20IyHB6QZGYGZ0mGsU=; b=ObDiuVMmytpYMfGZuAmUbi1HRtuLpgqKURg1KuIZb93bfi4ONkGe2TtIlSNPHoemFn z2C4rbOoZpeolZ/kZ+eTyfan3Bt6EuBGWimAm9aE1BSiKb79/Yb1CJxHWoV2x8Tk9ZwK /61RWNvFSL0ywxO6HHWUXGeNc3Z7/wKKpx6fz0X/RVpP8yNiPaWczMoaWrh9iq9v/lLh mRrZE6sR/7f7KuhX1bnBdKVfiTBl7TkKv1fckmGO16VpD48bB/oxufMLLXYtzMl7ETR1 cCAvi2xzigqxl0EpX07UVTUzsH9HkuKDqeyQu05SxdPjT3Kt8LskPiL0jxJ9BgnEWANz IT/A== X-Gm-Message-State: APjAAAWdGkmC3Pl+mt2EtCofFAiI9KRb+RDmC9KTHbLlKUmpuBHjYcyI b0OB5xhN/oObJmJUOABm9rGQNuD4//g= X-Google-Smtp-Source: APXvYqwOy40kYj04/Gl2SwZW4Q/Fo9c20DxGDEAGkQPtGp+HFIGHaFNz2+s9TriGFi/5c4+CwNRrOg== X-Received: by 2002:adf:f8ce:: with SMTP id f14mr33158086wrq.110.1559142552841; Wed, 29 May 2019 08:09:12 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z25sm6736037wmi.5.2019.05.29.08.09.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 08:09:11 -0700 (PDT) Date: Wed, 29 May 2019 16:09:10 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Bret Barkelew , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei Message-ID: <20190529150910.bxrhcbu4j7pezuc2@bivouac.eciton.net> References: <20190529004555.45364-1-zhichao.gao@intel.com> <20190529111143.whfxiphgc3y6jap4@bivouac.eciton.net> <3CE959C139B4C44DBEA1810E3AA6F9000B7DB95D@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7DB95D@SHSMSX101.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 29, 2019 at 03:01:12PM +0000, Gao, Zhichao wrote: > I just update the date of copyright. And the code in Mu project didn't add its own copyright. > If it is required, I would add it for them. Well, hopefully Microsoft will add their own copyright to the original :) Although it would certainly be better to add it here as well anyway. So what modifications were made to the code on the way from the project Mu repository? That would be useful to mention in the commit message. Regards, Leif > And I also make some minor changes on it. > > Thanks, > Zhichao > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Wednesday, May 29, 2019 7:12 PM > > To: devel@edk2.groups.io; Gao, Zhichao > > Cc: Bret Barkelew ; Wang, Jian J > > ; Wu, Hao A ; Ni, Ray > > ; Zeng, Star ; Gao, Liming > > ; Sean Brogan ; > > Michael Turner > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the > > CapsulePei > > > > On Wed, May 29, 2019 at 08:45:55AM +0800, Gao, Zhichao wrote: > > > From: Bret Barkelew > > > > If this code is from Microsoft... > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 > > > > > > Sperate the capsule check function from GetCapsuleDescriptors and name > > > it to AreCapsulesStaged. > > > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > > > And optimize its to remove the duplicated code. > > > > > > Cc: Jian J Wang > > > Cc: Hao A Wu > > > Cc: Ray Ni > > > Cc: Star Zeng > > > Cc: Liming Gao > > > Cc: Sean Brogan > > > Cc: Michael Turner > > > Cc: Bret Barkelew > > > Signed-off-by: Zhichao gao > > > --- > > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 3 +- > > > .../Universal/CapsulePei/CapsulePei.inf | 3 +- > > > .../Universal/CapsulePei/UefiCapsule.c | 357 ++++++++++-------- > > > 3 files changed, 194 insertions(+), 169 deletions(-) > > > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > index baf40423af..fc20dd8b92 100644 > > > --- a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > +++ b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > @@ -1,6 +1,6 @@ > > > /** @file > > > > > > -Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > reserved.
> > > +Copyright (c) 2006 - 2019, Intel Corporation. All rights > > > +reserved.
> > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > @@ -30,6 +30,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > #include #include > > > #include > > > +#include > > > #include #include > > > "Common/CommonHeader.h" > > > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > index 5d43df3075..9c88b3986f 100644 > > > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > @@ -6,7 +6,7 @@ > > > # This external input must be validated carefully to avoid security > > > issue like # buffer overflow, integer overflow. > > > # > > > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > reserved.
> > > +# Copyright (c) 2006 - 2019, Intel Corporation. All rights > > > +reserved.
> > > > ...why does Intel get the copyright? > > > > / > > Leif > > >