public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Christian Rodriguez" <christian.rodriguez@intel.com>
To: devel@edk2.groups.io
Subject: [Patch V4 0/2] BaseTools: Add a checking for Sources section and update hashing feature
Date: Wed, 29 May 2019 09:26:47 -0700	[thread overview]
Message-ID: <20190529162649.3236-1-christian.rodriguez@intel.com> (raw)

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804

In V4: Update commit messages.
In V3: Seperate checker and hashing into individual patches
In V2: Enable check for all builds, move conditional to hash invalidation
In the Edk2 INF spec 3.9, it states, All HII Unicode format files
must be listed in [Sources] section. Add a check to see if [Sources]
section lists all the "source" type files of a module. Performance
impact should be minimal with this patch since information is already
being fetched for Makefile purposes. All other information is already
cached in memory. No extra IO time is needed.

Christian Rodriguez (2):
  BaseTools: Add a checking for Sources section in INF file
  BaseTools: Refactor hash tracking after checking for Sources section

 BaseTools/Source/Python/AutoGen/AutoGen.py   |  6 +-
 BaseTools/Source/Python/AutoGen/GenMake.py   | 44 +++++++++++++
 BaseTools/Source/Python/Common/GlobalData.py |  3 +-
 BaseTools/Source/Python/build/build.py       | 65 ++++++++++++--------
 4 files changed, 91 insertions(+), 27 deletions(-)

-- 
2.21.0.windows.1


             reply	other threads:[~2019-05-29 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 16:26 Christian Rodriguez [this message]
2019-05-29 16:26 ` [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file Christian Rodriguez
2019-05-30  6:17   ` Bob Feng
2019-05-29 16:26 ` [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section Christian Rodriguez
2019-05-30  6:18   ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529162649.3236-1-christian.rodriguez@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox