From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: christian.rodriguez@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Wed, 29 May 2019 09:26:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 09:26:55 -0700 X-ExtLoop1: 1 Received: from rodrigu3-desk.amr.corp.intel.com ([10.7.163.75]) by orsmga001.jf.intel.com with ESMTP; 29 May 2019 09:26:54 -0700 From: "Christian Rodriguez" To: devel@edk2.groups.io Subject: [Patch V4 0/2] BaseTools: Add a checking for Sources section and update hashing feature Date: Wed, 29 May 2019 09:26:47 -0700 Message-Id: <20190529162649.3236-1-christian.rodriguez@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804 In V4: Update commit messages. In V3: Seperate checker and hashing into individual patches In V2: Enable check for all builds, move conditional to hash invalidation In the Edk2 INF spec 3.9, it states, All HII Unicode format files must be listed in [Sources] section. Add a check to see if [Sources] section lists all the "source" type files of a module. Performance impact should be minimal with this patch since information is already being fetched for Makefile purposes. All other information is already cached in memory. No extra IO time is needed. Christian Rodriguez (2): BaseTools: Add a checking for Sources section in INF file BaseTools: Refactor hash tracking after checking for Sources section BaseTools/Source/Python/AutoGen/AutoGen.py | 6 +- BaseTools/Source/Python/AutoGen/GenMake.py | 44 +++++++++++++ BaseTools/Source/Python/Common/GlobalData.py | 3 +- BaseTools/Source/Python/build/build.py | 65 ++++++++++++-------- 4 files changed, 91 insertions(+), 27 deletions(-) -- 2.21.0.windows.1