From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Q1+EF4fn; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Thu, 30 May 2019 11:06:39 -0700 Received: by mail-wm1-f65.google.com with SMTP id z23so4351623wma.4 for ; Thu, 30 May 2019 11:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yyZI5lEfRLluQ8htR+WS+G2s2SxoVzWENsye8Q06ZmM=; b=Q1+EF4fnnHMh+4evgXapdhhjdwJycsPojS+hFaBCD09k8T42/xza8Y2l5+v/S1Bnii 18nl0OcrApW8DyCXYwoXfoUwMszGtJVMbocCGxADt0wIRJeIKqsFIKs86kSBQbcU46/e VAD2IQAGvCknFbUqaeA8z95HV766l15M83p6KZ222nIKh5pu0kunxEvP3so4iBCjVpgf iCYFoNCO+RvGp8pNsXjo1cdpzHj4UnsYn76Q2G50SlK9IwYrt3xV7b87SyDsizDrOsv/ jsWpvnrq0xyRQm6mQG52vQRwU1/T/regbdaFwuxzxnEd3A8M4o6Djabm6U1k7TXEe3O9 JDVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yyZI5lEfRLluQ8htR+WS+G2s2SxoVzWENsye8Q06ZmM=; b=f+kj0+3leaf1bcEoctjkI/Yxt+MnN2slL8rnTnHcp3HVynupvgFVMW+sgNQlE/mA1H G72EKpFNsB6QWsVmpZD6KCk/vFBn0GtVZ4m70ikG1CY/7CYdnc6jd5iK33zfDSY1Wj8D NSkgWRumkSNA+XvQQPlm0Ii//pTLJW//jp2PSpRBIZYUd3erJ8dN2O/hasUHRnz96wWH lgUrFSdyMZ5maWBcPnvs44H85ObZP4F0MnsbyJAMT3Ma6wGQaow2ywe7hAktza9OtEkg f5fZJGpVNeFGxzuvitundGdti2Uie0tnIVdeOfVWBaYNV+ciOMz0OxJqoQiM5A9V70nb 7sJA== X-Gm-Message-State: APjAAAUcsgXB7521FXrtIAA1BV/AuRrEawgBoQfDqB95pGvXl1CuHG0w VR3LRej8M01JDfFfIvTPlC2KQw== X-Google-Smtp-Source: APXvYqx/qTrZ2Fxsx2zWbvRuvZIWJr9PX/cIf+sl6JmbwESMtmSMC2gXUgKltJ8kf+V23ETqY1A3Wg== X-Received: by 2002:a1c:3942:: with SMTP id g63mr2802968wma.61.1559239597246; Thu, 30 May 2019 11:06:37 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o12sm3867893wmh.12.2019.05.30.11.06.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 May 2019 11:06:36 -0700 (PDT) Date: Thu, 30 May 2019 19:06:34 +0100 From: "Leif Lindholm" To: Jeremy Linton Cc: devel@edk2.groups.io, mw@semihalf.com, ard.biesheuvel@linaro.org Subject: Re: [PATCH v2] Marvell/Armada80x0McBin: Enable USB keyboard, NVMe boot Message-ID: <20190530180634.qzfqk6qg2znu4shy@bivouac.eciton.net> References: <20190530173913.6674-1-jeremy.linton@arm.com> MIME-Version: 1.0 In-Reply-To: <20190530173913.6674-1-jeremy.linton@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 30, 2019 at 12:39:13PM -0500, Jeremy Linton wrote: > Add the USB keyboard driver, which is needed when a graphical > console is used. Also add a NVMe boot option for users that > choose that instead of SATA or MMC. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jeremy Linton > Reviewed-by: Marcin Wojtas That one worked much better: Reviewed-by: Leif Lindholm Pushed as 6784b55292. (Also, *giggle* @ mammon.) / Leif > --- > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++ > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > index 27e52f5af5..89d617fde4 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > @@ -90,6 +90,7 @@ > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > + UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > > @@ -505,6 +506,7 @@ > MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > # SD/MMC > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf > @@ -516,6 +518,7 @@ > ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > > # Console packages > MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > index 47e3bc4f82..f59cc1f263 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf > @@ -151,6 +151,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > # SD/MMC > INF MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf > @@ -162,6 +163,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > INF ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf > INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > > # Multiple Console IO support > INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf > -- > 2.21.0 >