From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Laszlo Ersek <lersek@redhat.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library
Date: Fri, 31 May 2019 14:26:07 +0100 [thread overview]
Message-ID: <20190531132607.icin5xymyu7v3jme@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu95S4YM_pgdQkYoLTEE2B6mBe4gytcJ5LvdFmgKk3VDpQ@mail.gmail.com>
On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote:
> > > + GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label
> >
> > Hmm. You add -ffreestanding here, but you also add it to the CLANG
> > profiles in 4/7. Could we do one of:
> > - dropping this one, adding -ffreestanding to GCC profiles too in 4/7
> > - keeping this one, dropping the -ffreestanding from 4/7?
> >
>
> In my opinion, we should be using -ffreestanding for all GCC family
> toolchains for all architectures.
I agree. Could you update 4/7 to do that, and add RVCT droppage to
commit message for this one?
If so, for series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
/
Leif
next prev parent reply other threads:[~2019-05-31 13:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 12:49 [PATCH v3 0/7] update ArmSoftFloatLib to latest upstream version Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 1/7] ArmPkg: import Berkeley Softfloat library as git submodule Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library Ard Biesheuvel
2019-05-31 13:20 ` Leif Lindholm
2019-05-31 13:22 ` Ard Biesheuvel
2019-05-31 13:26 ` Leif Lindholm [this message]
2019-05-31 13:39 ` Ard Biesheuvel
2019-05-31 13:49 ` Leif Lindholm
2019-05-31 14:32 ` Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 3/7] ArmPkg/ArmSoftFloatLib: remove source files that are no longer used Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 4/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 5/7] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S Ard Biesheuvel
2019-05-31 12:49 ` [PATCH v3 6/7] MdeModulePkg/PeCoffImageEmulator: avoid redeclaration of typedef Ard Biesheuvel
2019-06-03 0:33 ` Liming Gao
2019-05-31 12:49 ` [PATCH v3 7/7] MdePkg: avoid redeclaration of typedefs Ard Biesheuvel
2019-06-03 0:33 ` Liming Gao
2019-05-31 13:09 ` [PATCH v3 0/7] update ArmSoftFloatLib to latest upstream version Leif Lindholm
2019-05-31 16:00 ` [edk2-devel] " Ard Biesheuvel
2019-05-31 16:21 ` Michael D Kinney
2019-05-31 19:28 ` Leif Lindholm
2019-05-31 19:31 ` Michael D Kinney
2019-06-03 0:59 ` Liming Gao
2019-06-03 6:04 ` Ard Biesheuvel
2019-06-03 0:32 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531132607.icin5xymyu7v3jme@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox