From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=JfXuZKnn; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Fri, 31 May 2019 06:26:11 -0700 Received: by mail-wm1-f65.google.com with SMTP id e19so7613815wme.1 for ; Fri, 31 May 2019 06:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6S1YMXF5eAoS6JcXQh63naOq5IEd57tsKpAR3RU/4f4=; b=JfXuZKnn1OoaoK0DgY5YycYDdnmdlf1FWkezTVdzdq92ZFqFeTehgyLoSFsMCSjKcb B9qZ4BKpXYG4F/MTZjVS/iM+fUa4v1UR3pUslCOx2WmM4E4hhF0Qo85w44lXtvFg+Yce L99otbjWNfwrjnhCaxq45IkELKI0eGQGmX+j8K5PmXIcmflWRilQJdFFcQEhkuVRFYkl VFMd9JUjz4XZ8J4SJ7nU7+FgyxnEzHPiSukhX8yWd9zDCtoktIe+BicWhCbHssuVvOpw 1boO5LbfTHLxXHvl+vb3giupsfOVIzepWbYTK7qFjgUdzERcQOVmZ4xFeqfGsuvk/Y8G Szzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6S1YMXF5eAoS6JcXQh63naOq5IEd57tsKpAR3RU/4f4=; b=jf1m91vLea6oVIbIqLg/Cxtd8TotNG/NUUhte9dAKt4JtUp62ofzeKX7EI1KwCHumj WUHXmEU6dAqnwWL0lwKcN8fyavyHNv7gvQFQotzeXwMYYCRSH6k9trrmQ9gxBqN+yUAl jBg7JToShp4OWRJTK8lya4cu0QScnbntnRsYvTT6MjmZfnLSwH4E4aDAmqo9flQXqDNb cPqSH1tQQWmExt/7RHNF0R0dzPlKO0vBnbPN8RByB9DkrhJOR2QPpui1QPuCXIBhwbg2 SrdGtpmtEPtvQaA6hoYSKw2h83uzk2jmAQbvUciPz8I9PdoaXSgmcP28ymmYFtmXcw05 U7+Q== X-Gm-Message-State: APjAAAUlCRVJHKXFScOmvvpuggrtSdyiudSnNrYpu28iPiMwF6Ksz4OS hmKLruyDcPNt9wpSdiAFX/OYUQ== X-Google-Smtp-Source: APXvYqz30qMU7aC/TbTc4vsWseV1+LiWHWhLsE1UO/uq7zAPgKNoI5RkEysC8MSfsvgU8xqShiphGA== X-Received: by 2002:a1c:238e:: with SMTP id j136mr5429227wmj.4.1559309169879; Fri, 31 May 2019 06:26:09 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h12sm5244316wre.14.2019.05.31.06.26.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 May 2019 06:26:08 -0700 (PDT) Date: Fri, 31 May 2019 14:26:07 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io , Laszlo Ersek , "Gao, Liming" , "Wang, Jian J" , Michael D Kinney Subject: Re: [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library Message-ID: <20190531132607.icin5xymyu7v3jme@bivouac.eciton.net> References: <20190531124958.8421-1-ard.biesheuvel@linaro.org> <20190531124958.8421-3-ard.biesheuvel@linaro.org> <20190531132055.zsbratmpugwaqxd2@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote: > > > + GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label > > > > Hmm. You add -ffreestanding here, but you also add it to the CLANG > > profiles in 4/7. Could we do one of: > > - dropping this one, adding -ffreestanding to GCC profiles too in 4/7 > > - keeping this one, dropping the -ffreestanding from 4/7? > > > > In my opinion, we should be using -ffreestanding for all GCC family > toolchains for all architectures. I agree. Could you update 4/7 to do that, and add RVCT droppage to commit message for this one? If so, for series: Reviewed-by: Leif Lindholm / Leif