From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=UHvamqDE; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Fri, 31 May 2019 06:49:52 -0700 Received: by mail-wr1-f68.google.com with SMTP id d18so6590578wrs.5 for ; Fri, 31 May 2019 06:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=o98dXUwYHZK1QXxCVldMgPJnrCWW5P3rcKWLBR2xX4w=; b=UHvamqDEmW8cCDthDcZy/uDXH+XBT5bmMYZHKkuC2uYzvGVlpDAHljNOLpA4OVAUqe 4078vH5yvp92N9zhho3i0ALQazabw+8/8GQalg9qRfQF0BsNT3djSGO8Frdb6PIEBqto +gSRzVVtF+tLeVUMR59pTO75eEDyVeYpZThJ4BQs/TFMmFKWjdmcNwI3ghJTHIZ/04+K DOFVryeA2Q1Qc4Mtzdg3LsqYpNsj0Gqv6ygvDG3N/cBes3PPhA4iaY/UCPMMZVca8pvV PURtn/upjhjFP7bFPHZ/0VGXwQ6+fPjVJxUXQGLpn0eI4vQmkhbfGZ/Y2lFkZQqeJZi7 uSoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=o98dXUwYHZK1QXxCVldMgPJnrCWW5P3rcKWLBR2xX4w=; b=CT7u+6onkffYCbx+6EuE5qg3BD2OHeZ7wYFGjdcoabSpg0LBc0uyn6Qp/7kqZJsbf8 9zMWSUTaJZq2h+6l56xMHCx84mcz2ewsHKhgrwhRGxiEtY7hTqU+6HU4ZWwy9437eU5/ kttd3Cbd9akaWvu7De41umDHu+85X/2De2pLfFdv+hAfPRubJ/EtJ6fVxrT7rlvswRJt 2yOwNsRDulnL6oC0Dy93qZazHvseHTw8Q657aufOleFUv9yy/ueThm10UTqO13XnpGgH lsV1WMcZNZyA+0XJkOXyHJZd203xvGb5+qczM2UargyhYDnksCyl6RH0Q6B8ac86KOkL s9LQ== X-Gm-Message-State: APjAAAVHPHe51GhVULH0pr33u3yIUEiN//XJSFL7ZReR0J9NFpNjlD/V xt+v5T7ioJFZQbyztWsluRAK4g== X-Google-Smtp-Source: APXvYqxTQxf9AkfZfVucipIWCpjJeZt7UDVOKctuWyVXp8nov+N0yg8l2rWGCmX5jRZfA1uPMOgJYQ== X-Received: by 2002:a5d:6b12:: with SMTP id v18mr6807049wrw.306.1559310590846; Fri, 31 May 2019 06:49:50 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 95sm11641558wrk.70.2019.05.31.06.49.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 May 2019 06:49:50 -0700 (PDT) Date: Fri, 31 May 2019 14:49:48 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io , Laszlo Ersek , "Gao, Liming" , "Wang, Jian J" , Michael D Kinney Subject: Re: [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library Message-ID: <20190531134948.ffcifmhevf7fej76@bivouac.eciton.net> References: <20190531124958.8421-1-ard.biesheuvel@linaro.org> <20190531124958.8421-3-ard.biesheuvel@linaro.org> <20190531132055.zsbratmpugwaqxd2@bivouac.eciton.net> <20190531132607.icin5xymyu7v3jme@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 31, 2019 at 03:39:33PM +0200, Ard Biesheuvel wrote: > On Fri, 31 May 2019 at 15:26, Leif Lindholm wrote: > > > > On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote: > > > > > + GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label > > > > > > > > Hmm. You add -ffreestanding here, but you also add it to the CLANG > > > > profiles in 4/7. Could we do one of: > > > > - dropping this one, adding -ffreestanding to GCC profiles too in 4/7 > > > > - keeping this one, dropping the -ffreestanding from 4/7? > > > > > > > > > > In my opinion, we should be using -ffreestanding for all GCC family > > > toolchains for all architectures. > > > > I agree. Could you update 4/7 to do that, and add RVCT droppage to > > commit message for this one? > > Jian was looking into making OpenSSL 1.1.1b compile with CLANG for x86 > as well, so I'd rather not interfere with that. Raise a BZ and drop the -ffreestanding from one of these patches? / Leif