From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=io5I9BiR; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Fri, 31 May 2019 09:43:43 -0700 Received: by mail-wr1-f65.google.com with SMTP id m3so6966290wrv.2 for ; Fri, 31 May 2019 09:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZKvTvj16GBib3dI09g1h2DyuVIG60rxaeStHlfRgTzs=; b=io5I9BiR2aNPljPgJE2dmac5eE6BH2kr8/mD0Z9don+OBH1nEHjRx+a8NcQIiRz2n/ pkAc/i7KDod1HFM0friRxr8r/8rebILL1StuIpeYy5GMZ0brM3UVtIuLiUuoN8Aj6687 Oz/6/QKEDUtGj5vPWqYljISETd3Gtf7PLxBJvAlTsWoYdjM6tB60mpxKxdO7WPS//YEn nG+1eLOodbKLJotBTyVLlYRefzUUbMfj6JiZNC0Jcmu4N2ilD9ClVP7l9IafCnRj2hDA xSIAup69QzaINCvo6u5q22M7cxYr4d/cIJTE+b4LyA6/3Eeuf5yG/J/i9ZICigUfqgzc 1C2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZKvTvj16GBib3dI09g1h2DyuVIG60rxaeStHlfRgTzs=; b=ZAqxt/gd2HpGvVvUuxIZl74inHdipXf2rTHdPicE1zvpfeZ19IHVaM9ODvbKjwQw+2 /XeDCKFjFRrCuYxdeyFhN5P2SfhGqwVY/KaXaA9o8N/9OpKkAS9SBqfJ5Te+D3CJjNgF EADVNm0W4AJdvexvyjCzprhyUeFnUF2aQPcAHTVD9q9ELuytHYRAjmi0UK9IzKlG5zgZ 04x80d73iEvzN+ew7DkKqdRMAjjguRDgtwM/PwExfNtXZIEkynkKMG119dGFUpgTtwm7 ukWvHejQneRHlJmOE3Gr502YjoOdCEkqNNAo4T1thL4mw0bePUY5Qyra4OJ4GVATnl71 mZ8w== X-Gm-Message-State: APjAAAUorQYM3OHzS1WF4KpHp43Or4KFEunYWnEzZ8ZFlU3r1TJgD9cK JFyWAoNzwnfx5pL0q6fuxCNPGsIGVow= X-Google-Smtp-Source: APXvYqzlxSndTjSo8nQt4VbQprtcE7qYUOL+kvCxSp0StUkzj9UeKY1UcAGltrHOUYoYptWwY4R6CQ== X-Received: by 2002:adf:ea51:: with SMTP id j17mr7042369wrn.159.1559321021778; Fri, 31 May 2019 09:43:41 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x68sm6448732wmf.13.2019.05.31.09.43.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 May 2019 09:43:41 -0700 (PDT) Date: Fri, 31 May 2019 17:43:39 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Bret Barkelew , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei Message-ID: <20190531164339.bytd5w5sfiub75ic@bivouac.eciton.net> References: <20190529004555.45364-1-zhichao.gao@intel.com> <20190529111143.whfxiphgc3y6jap4@bivouac.eciton.net> <3CE959C139B4C44DBEA1810E3AA6F9000B7DB95D@SHSMSX101.ccr.corp.intel.com> <20190529150910.bxrhcbu4j7pezuc2@bivouac.eciton.net> <3CE959C139B4C44DBEA1810E3AA6F9000B7E1D64@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7E1D64@SHSMSX101.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 31, 2019 at 01:46:14AM +0000, Gao, Zhichao wrote: > > So what modifications were made to the code on the way from the project > > Mu repository? That would be useful to mention in the commit message. > > I would add this info blow commit message(not in commit message). It > is helpful for review. But it may not be useful to add them in the > commit message. > On my opinion, the commit message should contain the summary and impact of the changes. You are importing a file from a different repository, produced by a different company. As part of that import, you are claiming Intel copyright for 2019 for the code provided in the patch. This means that you are making a legal claim to the intellectual property provided by the patch on behalf of Intel. Either: - you have modified the code compared to the original, at which point the commit mesage *must* reflect this - it is no longer the contribution that the original message describes. For an example, see how Laszlo reflected his changes to 94e0dd1afe53. - the Intel copyright addition is a mistake (and must be dropped). Regards, Leif > > Thanks, > Zhichao > > > > > Regards, > > > > Leif > > > > > And I also make some minor changes on it. > > > > > > Thanks, > > > Zhichao > > > > > > > -----Original Message----- > > > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > > > Sent: Wednesday, May 29, 2019 7:12 PM > > > > To: devel@edk2.groups.io; Gao, Zhichao > > > > Cc: Bret Barkelew ; Wang, Jian J > > > > ; Wu, Hao A ; Ni, Ray > > > > ; Zeng, Star ; Gao, Liming > > > > ; Sean Brogan ; > > > > Michael Turner > > > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize > > > > the CapsulePei > > > > > > > > On Wed, May 29, 2019 at 08:45:55AM +0800, Gao, Zhichao wrote: > > > > > From: Bret Barkelew > > > > > > > > If this code is from Microsoft... > > > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 > > > > > > > > > > Sperate the capsule check function from GetCapsuleDescriptors and > > > > > name it to AreCapsulesStaged. > > > > > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > > > > > And optimize its to remove the duplicated code. > > > > > > > > > > Cc: Jian J Wang > > > > > Cc: Hao A Wu > > > > > Cc: Ray Ni > > > > > Cc: Star Zeng > > > > > Cc: Liming Gao > > > > > Cc: Sean Brogan > > > > > Cc: Michael Turner > > > > > Cc: Bret Barkelew > > > > > Signed-off-by: Zhichao gao > > > > > --- > > > > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 3 +- > > > > > .../Universal/CapsulePei/CapsulePei.inf | 3 +- > > > > > .../Universal/CapsulePei/UefiCapsule.c | 357 ++++++++++-------- > > > > > 3 files changed, 194 insertions(+), 169 deletions(-) > > > > > > > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > > > b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > > > index baf40423af..fc20dd8b92 100644 > > > > > --- a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > > > +++ b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > > > @@ -1,6 +1,6 @@ > > > > > /** @file > > > > > > > > > > -Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > > > reserved.
> > > > > +Copyright (c) 2006 - 2019, Intel Corporation. All rights > > > > > +reserved.
> > > > > > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > > > @@ -30,6 +30,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > #include #include > > > > > #include > > > > > +#include > > > > > #include #include > > > > > "Common/CommonHeader.h" > > > > > > > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > > > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > > > index 5d43df3075..9c88b3986f 100644 > > > > > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > > > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > > > @@ -6,7 +6,7 @@ > > > > > # This external input must be validated carefully to avoid > > > > > security issue like # buffer overflow, integer overflow. > > > > > # > > > > > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > > > reserved.
> > > > > +# Copyright (c) 2006 - 2019, Intel Corporation. All rights > > > > > +reserved.
> > > > > > > > ...why does Intel get the copyright? > > > > > > > > / > > > > Leif > > > > > > > > > > > >