public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org,
	jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com,
	Jici.Gao@arm.com, Jeremy Linton <jeremy.linton@arm.com>
Subject: Re: [edk2-platforms: PATCH v2] Marvell/Armada7k8k: Introduce SMBIOS/DMI support
Date: Fri, 31 May 2019 20:21:04 +0100	[thread overview]
Message-ID: <20190531192104.5nuiyoc5ahiddjdu@bivouac.eciton.net> (raw)
In-Reply-To: <1559319619-12833-1-git-send-email-mw@semihalf.com>

On Fri, May 31, 2019 at 06:20:19PM +0200, Marcin Wojtas wrote:
> Fill in the basic requirements of the SMBIOS specification by specifying
> the minimum required structures. The basic fixup is performed.
> CPU/DRAM frequency is obtained via SampleAtResetlib and the DRAM size
> is calculated from the information stored in the HOB list.
> 
> Add new Armada SmbiosPlatformDxe and MdeModulePkg/SmbiosDxe to the
> build and firmware image. With these changes, the EFI BDS, EFI shell,
> and Linux dmidecode command return useful information.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> Hi,
> 
> This is the second version of the SmBios support for
> Armada platforms, addressing all remarks from the initial
> patch. Please check the changelog below.
> 
> In order to ease review, the patch is available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/smbios-upstream-r20190531
> 
> Looking forward to your comments.
> 
> Best regards,
> Marcin

Thanks Marcin,

I can confirm you have addressed all of my feedback on v1.
However, I'll hold back for you and Jeremy to figure out what's up
with the output he is seeing from dmidecode.

Regards,

Leif

      parent reply	other threads:[~2019-05-31 19:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 16:20 [edk2-platforms: PATCH v2] Marvell/Armada7k8k: Introduce SMBIOS/DMI support Marcin Wojtas
2019-05-31 17:05 ` [edk2-devel] " Jeremy Linton
2019-05-31 18:04   ` Marcin Wojtas
2019-05-31 19:20     ` Jeremy Linton
2019-05-31 20:08     ` Jeremy Linton
2019-05-31 23:09       ` Marcin Wojtas
2019-05-31 19:21 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190531192104.5nuiyoc5ahiddjdu@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox