From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=MChRNGny;
 spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68])
 by groups.io with SMTP; Fri, 31 May 2019 12:21:08 -0700
Received: by mail-wm1-f68.google.com with SMTP id 7so6566838wmo.2
        for <devel@edk2.groups.io>; Fri, 31 May 2019 12:21:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=EQlnvt4kmiYl80ti9U4iP+47HVrIGoylzPlg4SuUo6k=;
        b=MChRNGnyIWOWXZwbZhpW+lXP7sJWhjuB4JsyYw78pSDGJPHztbA5c/Shir4uORdaSi
         zpLgDGn2AHlRuc2r1htlrarL+527Ryzy+k1HGwA6O5F4YlF6irW9sluI04kBzEF8Fr/N
         8zHlXGLPpK4UyOp9aCKqTqGrcOT86Jw7+xGdkuvJhFuAukbv7u3ffkvlUiT/x80E3c+o
         cALRQbRNVivY7c6gfKKMEaxjlxQgtsK6b5O5/Qz0MfVnjOWy6XtkrmUVPdz9EfFTapCs
         GGoRiivMd3jLZofzZRvL0Als+adVXsmSnzpnRVQaOjPBA5J+/rdE++JjvtOr88QL7m+0
         2J+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=EQlnvt4kmiYl80ti9U4iP+47HVrIGoylzPlg4SuUo6k=;
        b=QL/4bjsNSk8DwE1wrb6v7MMaun/Twd9qQhAya/0V8k0aEEu3BVnnQPzreBFJquyJvu
         87pwESJMTB6PliwBz99kZU7+Z3vdD9ysf9NPdlvED5aIdewFqYBGD10ahNTl9Q++sWE/
         Zwb1TrCNr6pplXc+vGys2Xw23pEyNwsmVfrzuURg2MeCMtn4yLtDrZTFV0Of6kA/9p5c
         es+NaUqBvNDm76neKa1qG/T8yU/kvz12DP2G4Lc1ELm1mCbqHjhb/C9u0msUXjELkgVX
         n/8O4r2aH+VbBwW5RG2vkzu6L7Uv/jKKgoQpRbeqS2wTA1fuQRHz5IuQpa/JTTlUj6B5
         w0Dw==
X-Gm-Message-State: APjAAAVdcHw/xpOCiqNCL6bVgNI3bTBu83tMflod9+fdu06FPXEVnopJ
	brh7oYwINTCygEJc7p05GtnTBQ==
X-Google-Smtp-Source: APXvYqx6h4c+h8zSfm9mkmFXgiR2VCflxrsDOOzWbDjO1Wjnb5jFt6dNk25tm4pv/4GgfV9u2cd5Cw==
X-Received: by 2002:a1c:480a:: with SMTP id v10mr6669347wma.120.1559330466945;
        Fri, 31 May 2019 12:21:06 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id b136sm9520752wme.30.2019.05.31.12.21.06
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Fri, 31 May 2019 12:21:06 -0700 (PDT)
Date: Fri, 31 May 2019 20:21:04 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, jsd@semihalf.com,
	jaz@semihalf.com, kostap@marvell.com, Jici.Gao@arm.com,
	Jeremy Linton <jeremy.linton@arm.com>
Subject: Re: [edk2-platforms: PATCH v2] Marvell/Armada7k8k: Introduce SMBIOS/DMI support
Message-ID: <20190531192104.5nuiyoc5ahiddjdu@bivouac.eciton.net>
References: <1559319619-12833-1-git-send-email-mw@semihalf.com>
MIME-Version: 1.0
In-Reply-To: <1559319619-12833-1-git-send-email-mw@semihalf.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 31, 2019 at 06:20:19PM +0200, Marcin Wojtas wrote:
> Fill in the basic requirements of the SMBIOS specification by specifying
> the minimum required structures. The basic fixup is performed.
> CPU/DRAM frequency is obtained via SampleAtResetlib and the DRAM size
> is calculated from the information stored in the HOB list.
> 
> Add new Armada SmbiosPlatformDxe and MdeModulePkg/SmbiosDxe to the
> build and firmware image. With these changes, the EFI BDS, EFI shell,
> and Linux dmidecode command return useful information.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> Hi,
> 
> This is the second version of the SmBios support for
> Armada platforms, addressing all remarks from the initial
> patch. Please check the changelog below.
> 
> In order to ease review, the patch is available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/smbios-upstream-r20190531
> 
> Looking forward to your comments.
> 
> Best regards,
> Marcin

Thanks Marcin,

I can confirm you have addressed all of my feedback on v1.
However, I'll hold back for you and Jeremy to figure out what's up
with the output he is seeing from dmidecode.

Regards,

Leif