Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

["Anthony PERARD" <anthony.perard@citrix.com>]

On Sat, Jun 01, 2019 at 05:00:37PM +0000, Kinney, Michael D wrote:
> I am curious.  I agree that a GUID can be defined in DEC file and
> in an include file that is used as a Vendor GUID in a device path.
> 
> Is there any reason that the FILE_GUID for the module needs to be
> the same GUID value?  Is there any code that looks for an FFS file
> with that GUID value as the FFS file name?

Sorry, I think you lost me here. The way I see it is that the GUID is
"produced" only by "MdeModulePkg/Universal/SerialDxe/SerialDxe.inf",
and then all the "PlatformBootManagerLib" are looking for exactly that
driver (SerialDxe), so the FILE_GUID is used.

There is probably a reason why this is already done three times in the
edk2.git repo.

Maybe you could have a closer look at
"ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c" to see how
SERIAL_DXE_FILE_GUID is used.

BTW, I've added "gSerialDxeFileGuid" as it seems there's often both a
"#define" and a variable for the GUID, but only the "#define" is used so
far. So maybe I should remove the variable?

> If not, then it would be better to not over use that GUID value.
> The FILE_GUID of the SerialDxe can be different.

Thanks for the review,

-- 
Anthony PERARD