From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.145.142, mailfrom: anthony.perard@citrix.com) Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by groups.io with SMTP; Mon, 03 Jun 2019 03:25:01 -0700 Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@MIAPEX02MSOL02.citrite.net Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=23.29.105.83; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 23.29.105.83 as permitted sender) identity=mailfrom; client-ip=23.29.105.83; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:23.29.105.83 ip4:162.221.156.50 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@MIAPEX02MSOL02.citrite.net) identity=helo; client-ip=23.29.105.83; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@MIAPEX02MSOL02.citrite.net"; x-conformance=sidf_compatible IronPort-SDR: z5uEV4IwAj2oezwx0/CrzYbxqh9HUcTAhKWStVDB6Y0n7Z40B280Vg6JkQ+wgGuaQgSZ4/oyHn Puks3WLpH1V8wiKit5/5Ctv13YcsVRIr5qp8Qtv4YvVRZ3JeEpef3sxdg0QuirjVfXVZ7ljmUO 78pxMsb+xOQo6wGSL+n0ze90X5l9mGBiNWAyROeqEfWU25Rp/EwqOha2Ejd5mS0BsZAzr0XgFe G0Qvy3D4voWqp3nOHrryPgqcYSdRmUl5yWsJEc8sp/4l1iKirBSOs1jSnR2fOTtv+tBVLg0lWw ISQ= X-SBRS: 2.7 X-MesageID: 1234999 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 23.29.105.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.60,546,1549947600"; d="scan'208";a="1234999" Date: Mon, 3 Jun 2019 11:24:57 +0100 From: "Anthony PERARD" To: "Kinney, Michael D" CC: "devel@edk2.groups.io" , "Wang, Jian J" , "Ni, Ray" , Ard Biesheuvel , "Zeng, Star" , "Wu, Hao A" , Julien Grall , Leif Lindholm , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once Message-ID: <20190603102457.GE2126@perard.uk.xensource.com> References: <20190529113723.23186-1-anthony.perard@citrix.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Sat, Jun 01, 2019 at 05:00:37PM +0000, Kinney, Michael D wrote: > I am curious. I agree that a GUID can be defined in DEC file and > in an include file that is used as a Vendor GUID in a device path. > > Is there any reason that the FILE_GUID for the module needs to be > the same GUID value? Is there any code that looks for an FFS file > with that GUID value as the FFS file name? Sorry, I think you lost me here. The way I see it is that the GUID is "produced" only by "MdeModulePkg/Universal/SerialDxe/SerialDxe.inf", and then all the "PlatformBootManagerLib" are looking for exactly that driver (SerialDxe), so the FILE_GUID is used. There is probably a reason why this is already done three times in the edk2.git repo. Maybe you could have a closer look at "ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c" to see how SERIAL_DXE_FILE_GUID is used. BTW, I've added "gSerialDxeFileGuid" as it seems there's often both a "#define" and a variable for the GUID, but only the "#define" is used so far. So maybe I should remove the variable? > If not, then it would be better to not over use that GUID value. > The FILE_GUID of the SerialDxe can be different. Thanks for the review, -- Anthony PERARD