[PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

[PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

[PierreGondois]

From: Pierre Gondois <pierre.gondois@arm.com>

The ACPI 6.3 specification introduces support to describe
the ARMv8.1 virtual EL2 timers. This patch updates the GTDT parser
of acpiview to decode the EL2 virtual timer fields.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---

The changes can be seen at: https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_update_v1

Notes:
    v1:
    - GTDT updates for ACPI 6.3 [Pierre]

 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
index 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab057c32369a456267 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
@@ -5,7 +5,7 @@
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Reference(s):
-    - ACPI 6.2 Specification - Errata A, September 2017
+    - ACPI 6.3 Specification - January 2019
   **/
 
 #include <IndustryStandard/Acpi.h>
@@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = {
   {L"Platform Timer Count", 4, 88, L"%d", NULL,
    (VOID**)&GtdtPlatformTimerCount, NULL, NULL},
   {L"Platform Timer Offset", 4, 92, L"0x%x", NULL,
-   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}
+   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL},
+  {L"Virtual EL2 Timer GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL},
+  {L"Virtual EL2 Timer Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL}
 };
 
 /**
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

[Alexei.Fedorov]

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

[-- Attachment #2: Type: text/html, Size: 60 bytes --]

Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

[Sami Mujawar]

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: PierreGondois <pierre.gondois@arm.com> 
Sent: 06 June 2019 01:29 PM
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; Pierre Gondois <Pierre.Gondois@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

From: Pierre Gondois <pierre.gondois@arm.com>

The ACPI 6.3 specification introduces support to describe the ARMv8.1 virtual EL2 timers. This patch updates the GTDT parser of acpiview to decode the EL2 virtual timer fields.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---

The changes can be seen at: https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_update_v1

Notes:
    v1:
    - GTDT updates for ACPI 6.3 [Pierre]

 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
index 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab057c32369a456267 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars
+++ er.c
@@ -5,7 +5,7 @@
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Reference(s):
-    - ACPI 6.2 Specification - Errata A, September 2017
+    - ACPI 6.3 Specification - January 2019
   **/
 
 #include <IndustryStandard/Acpi.h>
@@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = {
   {L"Platform Timer Count", 4, 88, L"%d", NULL,
    (VOID**)&GtdtPlatformTimerCount, NULL, NULL},
   {L"Platform Timer Offset", 4, 92, L"0x%x", NULL,
-   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}
+   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL},  {L"Virtual EL2 Timer 
+ GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL},  {L"Virtual EL2 Timer 
+ Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL}
 };
 
 /**
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

[Gao, Zhichao]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

I would collect the R-B and send to the maintainer to push.

Thanks,
Zhichao

> -----Original Message-----
> From: PierreGondois [mailto:pierre.gondois@arm.com]
> Sent: Thursday, June 6, 2019 8:29 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; sami.mujawar@arm.com;
> Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com;
> pierre.gondois@arm.com; nd@arm.com
> Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
> 
> From: Pierre Gondois <pierre.gondois@arm.com>
> 
> The ACPI 6.3 specification introduces support to describe the ARMv8.1 virtual
> EL2 timers. This patch updates the GTDT parser of acpiview to decode the EL2
> virtual timer fields.
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> 
> The changes can be seen at:
> https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd
> ate_v1
> 
> Notes:
>     v1:
>     - GTDT updates for ACPI 6.3 [Pierre]
> 
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
> | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> .c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> .c
> index
> 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05
> 7c32369a456267 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> .c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars
> +++ er.c
> @@ -5,7 +5,7 @@
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>    @par Reference(s):
> -    - ACPI 6.2 Specification - Errata A, September 2017
> +    - ACPI 6.3 Specification - January 2019
>    **/
> 
>  #include <IndustryStandard/Acpi.h>
> @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = {
>    {L"Platform Timer Count", 4, 88, L"%d", NULL,
>     (VOID**)&GtdtPlatformTimerCount, NULL, NULL},
>    {L"Platform Timer Offset", 4, 92, L"0x%x", NULL,
> -   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}
> +   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL},  {L"Virtual EL2 Timer
> + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL},  {L"Virtual EL2 Timer
> + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL}
>  };
> 
>  /**
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

[Carsey, Jaben]

Pushed as sufficient RB's were received.

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Sunday, June 09, 2019 8:09 PM
> To: PierreGondois <pierre.gondois@arm.com>; devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> sami.mujawar@arm.com; Matteo.Carlini@arm.com; Stephanie.Hughes-
> Fitt@arm.com; nd@arm.com
> Subject: RE: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
> Importance: High
> 
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> I would collect the R-B and send to the maintainer to push.
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: PierreGondois [mailto:pierre.gondois@arm.com]
> > Sent: Thursday, June 6, 2019 8:29 PM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Gao, Zhichao <zhichao.gao@intel.com>; sami.mujawar@arm.com;
> > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com;
> > pierre.gondois@arm.com; nd@arm.com
> > Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
> >
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > The ACPI 6.3 specification introduces support to describe the ARMv8.1
> virtual
> > EL2 timers. This patch updates the GTDT parser of acpiview to decode the
> EL2
> > virtual timer fields.
> >
> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > ---
> >
> > The changes can be seen at:
> >
> https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd
> > ate_v1
> >
> > Notes:
> >     v1:
> >     - GTDT updates for ACPI 6.3 [Pierre]
> >
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
> > | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> > index
> >
> 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05
> > 7c32369a456267 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> > .c
> > +++
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars
> > +++ er.c
> > @@ -5,7 +5,7 @@
> >    SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >    @par Reference(s):
> > -    - ACPI 6.2 Specification - Errata A, September 2017
> > +    - ACPI 6.3 Specification - January 2019
> >    **/
> >
> >  #include <IndustryStandard/Acpi.h>
> > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = {
> >    {L"Platform Timer Count", 4, 88, L"%d", NULL,
> >     (VOID**)&GtdtPlatformTimerCount, NULL, NULL},
> >    {L"Platform Timer Offset", 4, 92, L"0x%x", NULL,
> > -   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}
> > +   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL},  {L"Virtual EL2 Timer
> > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL},  {L"Virtual EL2 Timer
> > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL}
> >  };
> >
> >  /**
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH V1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

[PierreGondois]

From: Pierre Gondois <pierre.gondois@arm.com>

The ACPI 6.3 specification introduces support to describe
the ARMv8.1 virtual EL2 timers. This patch updates the GTDT parser
of acpiview to decode the EL2 virtual timer fields.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---

The changes can be seen at: https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_update_v1

Notes:
    v1:
    - GTDT updates for ACPI 6.3 [Pierre]

 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
index 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab057c32369a456267 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
@@ -5,7 +5,7 @@
   SPDX-License-Identifier: BSD-2-Clause-Patent

   @par Reference(s):
-    - ACPI 6.2 Specification - Errata A, September 2017
+    - ACPI 6.3 Specification - January 2019
   **/

 #include <IndustryStandard/Acpi.h>
@@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = {
   {L"Platform Timer Count", 4, 88, L"%d", NULL,
    (VOID**)&GtdtPlatformTimerCount, NULL, NULL},
   {L"Platform Timer Offset", 4, 92, L"0x%x", NULL,
-   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}
+   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL},
+  {L"Virtual EL2 Timer GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL},
+  {L"Virtual EL2 Timer Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL}
 };

 /**
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [PATCH V1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3

[Gao, Zhichao]

The code change looks good for me. 
But when I try to apply your patch to my local edk2 code, I would encounter an error "error: corrupt patch at line 23".
Making sure the patch that can apply to the edk2 trunk is important. Otherwise, the testers and maintainers may take time to write the whole change to their own repo.
Most time, it is impossible for them to write the code again  because the patches are too many.

Thanks,
Zhichao

> -----Original Message-----
> From: PierreGondois [mailto:pierre.gondois@arm.com]
> Sent: Monday, May 20, 2019 9:33 PM
> To: devel@edk2.groups.io
> Cc: sami.mujawar@arm.com; Carsey, Jaben <jaben.carsey@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; nd@arm.com
> Subject: [PATCH V1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3
> 
> From: Pierre Gondois <pierre.gondois@arm.com>
> 
> The ACPI 6.3 specification introduces support to describe the ARMv8.1 virtual
> EL2 timers. This patch updates the GTDT parser of acpiview to decode the EL2
> virtual timer fields.
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> 
> The changes can be seen at:
> https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd
> ate_v1
> 
> Notes:
>     v1:
>     - GTDT updates for ACPI 6.3 [Pierre]
> 
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
> | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> .c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> .c
> index
> 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05
> 7c32369a456267 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser
> .c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars
> +++ er.c
> @@ -5,7 +5,7 @@
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>    @par Reference(s):
> -    - ACPI 6.2 Specification - Errata A, September 2017
> +    - ACPI 6.3 Specification - January 2019
>    **/
> 
>  #include <IndustryStandard/Acpi.h>
> @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] = {
>    {L"Platform Timer Count", 4, 88, L"%d", NULL,
>     (VOID**)&GtdtPlatformTimerCount, NULL, NULL},
>    {L"Platform Timer Offset", 4, 92, L"0x%x", NULL,
> -   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}
> +   (VOID**)&GtdtPlatformTimerOffset, NULL, NULL},  {L"Virtual EL2 Timer
> + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL},  {L"Virtual EL2 Timer
> + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL}
>  };
> 
>  /**
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'