Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

["Anthony PERARD" <anthony.perard@citrix.com>]

> > So, ultimately, we are asking Anthony to:
> > 
> > (1) please introduce the new GUID as
> > EDKII_SERIAL_VENDOR_GUID and gEdkiiSerialVendorGuid,
> 
> Yes.
> 
> > 
> > (2) please append another patch to this series,
> > replacing EFI_CALLER_ID_GUID -- and the comment! -- with
> > EDKII_SERIAL_VENDOR_GUID, in the "mSerialDevicePath"
> > initializer (in
> > "MdeModulePkg/Universal/SerialDxe/SerialIo.c").
> > 
> > Correct?
> 
> Yes.
> 
> > 
> > Can we suggest an include file name too, in place of
> > "MdeModulePkg/Include/Guid/SerialDxe.h"?
> 
> The SerialDxe module uses the services of the SeriaPortLib to
> produce the Serial I/O Protocol.  Instead of a physical register
> interface such as UART in HW, the SW APIs of the SerialPortLib are
> used.  The GUIDed Vendor HW node in the device path for the HW
> register case would be a GUID value and name(s) that represents
> the HW device used to perform the Serial I/O actions.  Applying
> this to the SerialPortLib  access would imply GUID and Include
> file names that are associated with the SerialPortLib. Perhaps:
> 
>   MdeModulePkg/Include/Guid/SerialPortLibVendor.h
> 
>   EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> 
>   gEdkiiSerialPortLibVendorGuid

Thank you all, I'll update the patches.

-- 
Anthony PERARD