From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.155.144, mailfrom: anthony.perard@citrix.com)
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144])
 by groups.io with SMTP; Thu, 06 Jun 2019 05:33:17 -0700
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=SoftFail smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com
Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender
  authenticity information available from domain of
  anthony.perard@citrix.com) identity=pra;
  client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="anthony.perard@citrix.com";
  x-conformance=sidf_compatible
Received-SPF: SoftFail (esa4.hc3370-68.iphmx.com: domain of
  anthony.perard@citrix.com is inclined to not designate
  162.221.158.21 as permitted sender) identity=mailfrom;
  client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="anthony.perard@citrix.com";
  x-conformance=sidf_compatible; x-record-type="v=spf1";
  x-record-text="v=spf1 include:spf.citrix.com
  include:spf2.citrix.com include:ironport.citrix.com
  exists:%{i}._spf.mta.salesforce.com ~all"
Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@mail.citrix.com) identity=helo;
  client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="postmaster@mail.citrix.com";
  x-conformance=sidf_compatible
IronPort-SDR: PQHfwOtiYxo21gQ1haMtNPU1dgVpCaT5ERoWqorJo8crHQXjOcuBu7QAqYf7guI/JL/kaua5Y5
 Nxu6jccfnZO3KYYi1HCs3PfjPHSqbwVcQvIBDwoAmrbHd7yjlgmDKLXxTVJ8vXnL9aP/IKbSZS
 R3bqFCiTJQXXM0+I1lIMCq7CWVC1653fDZGgomhsod/pb9ErNiza+dM/V4W9NF0kaoGQp108Kn
 T1H6bbXYJORWw/RwZehkxuwTqYAfAJz4TrOS/lRglUAiew97Od0hKvAiX4wA08OgLbLKkERRfc
 euA=
X-SBRS: -0.9
X-MesageID: 1393518
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.158.21
X-Policy: $RELAYED
X-IronPort-AV: E=Sophos;i="5.63,559,1557201600"; 
   d="scan'208";a="1393518"
Date: Thu, 6 Jun 2019 13:33:13 +0100
From: "Anthony PERARD" <anthony.perard@citrix.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
CC: "devel@edk2.groups.io" <devel@edk2.groups.io>, "lersek@redhat.com"
	<lersek@redhat.com>, "Wang, Jian J" <jian.j.wang@intel.com>, "Ni, Ray"
	<ray.ni@intel.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, "Zeng, Star"
	<star.zeng@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>, Julien Grall
	<julien.grall@arm.com>, Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once
Message-ID: <20190606123313.GL2126@perard.uk.xensource.com>
References: <20190529113723.23186-1-anthony.perard@citrix.com>
 <E92EE9817A31E24EB0585FDF735412F5B9D2254E@ORSMSX113.amr.corp.intel.com>
 <972a37a8-196b-55de-41e6-13d4be044a50@redhat.com>
 <E92EE9817A31E24EB0585FDF735412F5B9D22F67@ORSMSX113.amr.corp.intel.com>
 <2017a358-560a-0c32-00a0-e4dc041e22ac@redhat.com>
 <E92EE9817A31E24EB0585FDF735412F5B9D230E9@ORSMSX113.amr.corp.intel.com>
MIME-Version: 1.0
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9D230E9@ORSMSX113.amr.corp.intel.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Return-Path: anthony.perard@citrix.com
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

> > So, ultimately, we are asking Anthony to:
> > 
> > (1) please introduce the new GUID as
> > EDKII_SERIAL_VENDOR_GUID and gEdkiiSerialVendorGuid,
> 
> Yes.
> 
> > 
> > (2) please append another patch to this series,
> > replacing EFI_CALLER_ID_GUID -- and the comment! -- with
> > EDKII_SERIAL_VENDOR_GUID, in the "mSerialDevicePath"
> > initializer (in
> > "MdeModulePkg/Universal/SerialDxe/SerialIo.c").
> > 
> > Correct?
> 
> Yes.
> 
> > 
> > Can we suggest an include file name too, in place of
> > "MdeModulePkg/Include/Guid/SerialDxe.h"?
> 
> The SerialDxe module uses the services of the SeriaPortLib to
> produce the Serial I/O Protocol.  Instead of a physical register
> interface such as UART in HW, the SW APIs of the SerialPortLib are
> used.  The GUIDed Vendor HW node in the device path for the HW
> register case would be a GUID value and name(s) that represents
> the HW device used to perform the Serial I/O actions.  Applying
> this to the SerialPortLib  access would imply GUID and Include
> file names that are associated with the SerialPortLib. Perhaps:
> 
>   MdeModulePkg/Include/Guid/SerialPortLibVendor.h
> 
>   EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> 
>   gEdkiiSerialPortLibVendorGuid

Thank you all, I'll update the patches.

-- 
Anthony PERARD