public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Anthony PERARD" <anthony.perard@citrix.com>
To: <devel@edk2.groups.io>
Cc: Ray Ni <ray.ni@intel.com>, Julien Grall <julien.grall@arm.com>,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Laszlo Ersek <lersek@redhat.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>, Star Zeng <star.zeng@intel.com>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2 1/4] MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
Date: Thu, 6 Jun 2019 14:14:56 +0100	[thread overview]
Message-ID: <20190606131459.1464-2-anthony.perard@citrix.com> (raw)
In-Reply-To: <20190606131459.1464-1-anthony.perard@citrix.com>

SERIAL_DXE_FILE_GUID is used in different places, create a single
define that other can use. Also fix SerialDxe to actually use
EDKII_SERIAL_PORT_LIB_VENDOR_GUID in the device path instead of the
FILE_GUID.

Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    Suggested in: Message-ID: <7d6adf5d-baca-7e9c-68ef-2f8479bbd902@redhat.com>

 MdeModulePkg/MdeModulePkg.dec                 |  3 +++
 .../Universal/SerialDxe/SerialDxe.inf         |  1 +
 .../Include/Guid/SerialPortLibVendor.h        | 19 +++++++++++++++++++
 MdeModulePkg/Universal/SerialDxe/SerialIo.c   |  3 ++-
 4 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 6cba729982..2dee139ba3 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -396,6 +396,9 @@ [Guids]
   ## Include/Guid/S3StorageDeviceInitList.h
   gS3StorageDeviceInitListGuid = { 0x310e9b8c, 0xcf90, 0x421e, { 0x8e, 0x9b, 0x9e, 0xef, 0xb6, 0x17, 0xc8, 0xef } }
 
+  ## Include/Guid/SerialPortLibVendor.h
+  gEdkiiSerialPortLibVendorGuid = { 0xD3987D4B, 0x971A, 0x435F, { 0x8C, 0xAF, 0x49, 0x67, 0xEB, 0x62, 0x72, 0x41 } }
+
 [Ppis]
   ## Include/Ppi/AtaController.h
   gPeiAtaControllerPpiGuid       = { 0xa45e60d1, 0xc719, 0x44aa, { 0xb0, 0x7a, 0xaa, 0x77, 0x7f, 0x85, 0x90, 0x6d }}
diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
index 81066a26a2..b6c85b3f84 100644
--- a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
+++ b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
@@ -22,6 +22,7 @@ [Sources.common]
 
 [Packages]
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
 
 [LibraryClasses]
   UefiDriverEntryPoint
diff --git a/MdeModulePkg/Include/Guid/SerialPortLibVendor.h b/MdeModulePkg/Include/Guid/SerialPortLibVendor.h
new file mode 100644
index 0000000000..887f96c30a
--- /dev/null
+++ b/MdeModulePkg/Include/Guid/SerialPortLibVendor.h
@@ -0,0 +1,19 @@
+/** @file
+  Define the SerialDxe GUID.
+
+  Copyright (c) 2019, Citrix Systems, Inc.
+
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+**/
+
+#ifndef __SERIAL_PORT_LIB_VENDOR_H__
+#define __SERIAL_PORT_LIB_VENDOR_H__
+
+#define EDKII_SERIAL_PORT_LIB_VENDOR_GUID { \
+          0xD3987D4B, 0x971A, 0x435F, \
+          { 0x8C, 0xAF, 0x49, 0x67, 0xEB, 0x62, 0x72, 0x41 } \
+          }
+
+extern EFI_GUID gEdkiiSerialPortLibVendorGuid;
+
+#endif // __SERIAL_PORT_LIB_VENDOR_H__
diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Universal/SerialDxe/SerialIo.c
index 720a3f264a..fb816a1611 100644
--- a/MdeModulePkg/Universal/SerialDxe/SerialIo.c
+++ b/MdeModulePkg/Universal/SerialDxe/SerialIo.c
@@ -16,6 +16,7 @@
 
 #include <Protocol/SerialIo.h>
 #include <Protocol/DevicePath.h>
+#include <Guid/SerialPortLibVendor.h>
 
 typedef struct {
   VENDOR_DEVICE_PATH        Guid;
@@ -159,7 +160,7 @@ EFI_HANDLE mSerialHandle = NULL;
 SERIAL_DEVICE_PATH mSerialDevicePath = {
   {
     { HARDWARE_DEVICE_PATH, HW_VENDOR_DP, { sizeof (VENDOR_DEVICE_PATH), 0} },
-    EFI_CALLER_ID_GUID  // Use the driver's GUID
+    EDKII_SERIAL_PORT_LIB_VENDOR_GUID
   },
   {
     { MESSAGING_DEVICE_PATH, MSG_UART_DP, { sizeof (UART_DEVICE_PATH), 0} },
-- 
Anthony PERARD


  reply	other threads:[~2019-06-06 13:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06 13:14 [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID Anthony PERARD
2019-06-06 13:14 ` Anthony PERARD [this message]
2019-06-06 17:13   ` [PATCH v2 1/4] MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID Laszlo Ersek
2019-06-13  6:49     ` [edk2-devel] " Wu, Hao A
2019-06-06 13:14 ` [PATCH v2 2/4] ArmVirtPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg Anthony PERARD
2019-06-06 17:09   ` Laszlo Ersek
2019-06-06 13:14 ` [PATCH v2 3/4] ArmPkg/PlatformBootManagerLib: " Anthony PERARD
2019-06-06 13:14 ` [PATCH v2 4/4] UefiPayloadPkg/PlatformBootManagerLib: " Anthony PERARD
2019-06-13 16:06   ` [edk2-devel] " Ma, Maurice
2019-06-06 17:15 ` [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID Laszlo Ersek
2019-06-06 17:17   ` Ard Biesheuvel
2019-06-13 15:32 ` [edk2-devel] " Laszlo Ersek
2019-06-13 15:33   ` Laszlo Ersek
2019-06-13 16:09   ` Ma, Maurice
2019-06-14 19:35 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606131459.1464-2-anthony.perard@citrix.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox