From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=RmnSAM/S; spf=pass (domain: linaro.org, ip: 209.85.221.48, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by groups.io with SMTP; Mon, 10 Jun 2019 08:12:40 -0700 Received: by mail-wr1-f48.google.com with SMTP id b17so9564004wrq.11 for ; Mon, 10 Jun 2019 08:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=F64T7uFnhaY86cdmQQcoGPutUeGWWlUxCd/KPEc9P40=; b=RmnSAM/SMY5IzSnVjhKqI6hrl9keBTmwlFIYtHW7wFP4nCPmgZtPrrEerf3NL5hQlF oriRs05/ZSUzRxgAbcR0pSDOcGNM059SM/IOYLQ/W7mqa1Rpmj63CeVWU2E3mQBeqx7+ w+QFEPdNPPFguP9sHUiPI5wNd2GFo8K33U0qkxTT0rh3CvtyTWPck3Y6437h2WkSati3 f0mUUV8DgeDAhSUXRcOEWlr5S0bx7kgEfv6J4KCOB567zuVMOWN3X18Ewl+p27mcTlrw 8Ip0kqC2jeBdyyrPmrf26tHONM6H0vK26nh4YSSIPY2DtVh1g+/+meRKJf7tjo21dKXE XWrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F64T7uFnhaY86cdmQQcoGPutUeGWWlUxCd/KPEc9P40=; b=J/kPabbr4cKGWasDzbt/BhjLLur0h4Ijv4DR9okYQpCFaYvvRZDFI8+6jnN2oAoxjd 4Dt2rvSMwIYt5m1eBpffUdzI2qDyozLUNWjMXI+38JsleHl7uHuCmvUsDr2xiEjV1YVf g4enCtvnRocIMjHhaUlk8w4y3ycRtN9ZIYXCfLsyNdBYG9DcvjEVVnDfcJ4VTaraO7zc 6/9djPFkj/zNxVzNpRUMFrbKNwcmhGbHPlioQyEHGddSAWYSw7haxwKb2Uqx8oDuJhJ6 wfOv2Q6T5hw5wQn8MupXSk7eDEUQFdWkiCvfiiKFJz+789dsnGG/8G3q3xZdTltLR6ir 39+Q== X-Gm-Message-State: APjAAAWYK3lz1tQVnzWqrKKO9mCTi5MW1sZ1Df21LLVv2oNm807GtOD2 tN61pCKG/rEbnpllIVkW5uVAhg== X-Google-Smtp-Source: APXvYqwakJ8NVx5RxXgzRntRXLPtHM2wYod7ZOQOrdTN+Y0G53McBW3okt5zE66rNGEpzS0x2uMrbw== X-Received: by 2002:adf:ef09:: with SMTP id e9mr31489220wro.79.1560179558017; Mon, 10 Jun 2019 08:12:38 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j189sm8153760wmb.48.2019.06.10.08.12.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Jun 2019 08:12:37 -0700 (PDT) Date: Mon, 10 Jun 2019 16:12:35 +0100 From: "Leif Lindholm" To: "Wu, Hao A" Cc: "'devel@edk2.groups.io'" , 'Ard Biesheuvel' , "ming.huang@linaro.org" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Message-ID: <20190610151235.u73xywjsjqfo4fev@bivouac.eciton.net> References: <20190520084105.9028-1-hao.a.wu@intel.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Hao Wu, Given Ming's confirmation regarding d06, I'm happy for this set to go ahead. Also, we're just past the edk2 stable tag, so people should be expecting some volatility :) Acked-by: Leif Lindholm On Mon, Jun 10, 2019 at 05:13:42AM +0000, Wu, Hao A wrote: > Hello Ard and Leif, > > I saw Ming Huang validated the patch (OS boot): > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg > > https://edk2.groups.io/g/devel/message/41419 > (Thanks a lot for the validation effort.) > > Do you have remaining concerns for review this series? > Thanks in advance. > > Best Regards, > Hao Wu > > > > -----Original Message----- > > From: Wu, Hao A > > Sent: Monday, May 27, 2019 10:43 AM > > To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm > > Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray; > > guoheyi@huawei.com > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > > IntelFramework[Module]Pkg dependency > > > > Hello Ard and Leif, > > > > Do you have comments on this series? > > > > Also, for the below patch to Hisilicon platforms: > > [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in > > MdeModulePkg > > > > it is suggested to be verified on actual hardware: > > https://edk2.groups.io/g/devel/topic/31614327#41188 > > > > However, it seems that there is no accessible hardware for such verification > > at this moment. Do you think it is fine to push this change anyway? > > > > (Also CCed the stewards here for comments.) > > > > Best Regards, > > Hao Wu > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > > Wu, Hao A > > > Sent: Monday, May 20, 2019 4:41 PM > > > To: devel@edk2.groups.io > > > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D > > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > > > IntelFramework[Module]Pkg dependency > > > > > > The series is also available at: > > > https://github.com/hwu25/edk2- > > > platforms/commits/drop_intelframework_v2 > > > > > > V2 changes: > > > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board, update > > > their DSC file to consume the null ReportStatusCodeLib in MdePkg. The > > > change is done since these platforms do not have a StatusCode Router > > > module; > > > B. Add the change for platform RaspberryPi/RPi3 to drop its dependency > > on > > > the framework packages; > > > C. Update the commit log message for patch > > > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg' > > > to better reflect the commit impact. > > > > > > > > > This series will drop the IntelFramework[Module]Pkg dependency for > > > platforms within the edk2-platforms repo. > > > packages. > > > > > > Tests done for the series: > > > Platforms build verified with GCC5 toolchain: > > > * Platform/AMD/OverdriveBoard > > > * Platform/ARM/JunoPkg > > > * Platform/ARM/SgiPkg > > > * Platform/ARM/VExpressPkg > > > * Platform/BeagleBoard > > > * Platform/Hisilicon/D0x > > > * Platform/Hisilicon/HiKey > > > * Platform/Hisilicon/HiKey960 > > > * Platform/LeMaker/CelloBoard > > > * Platform/Marvell/Armada70x0Db (only AARCH64) > > > * Platform/Marvell/Armada80x0Db (only AARCH64) > > > * Platform/RaspberryPi/RPi3 > > > * Platform/Socionext/DeveloperBox > > > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64) > > > * Platform/SoftIron/Overdrive1000Board > > > * Platform/SolidRun/Armada80x0McBin (only AARCH64) > > > > > > Platforms originally cannot be built via GCC5 toolchain (thus, not > > > verified): > > > * Platform/Comcast/RDKQemu (ARM, AARCH64) > > > * Platform/Marvell/Armada70x0Db (ARM) > > > * Platform/Marvell/Armada80x0Db (ARM) > > > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64) > > > * Platform/SolidRun/Armada80x0McBin (ARM) > > > > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > > > > Hao A Wu (18): > > > Platform/AMD: Use Lzma decompress lib in MdeModulePkg > > > Platform/BeagleBoard: Use ReportStatusCodeLib null instance > > > Platform/BeagleBoard: Drop the consume of PcdShellFile > > > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg > > > Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib > > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg > > > Hisilicon/D06: Drop the consume of PcdShellFile > > > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg > > > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg > > > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in > > MdeModulePkg > > > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency > > > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib > > > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg > > > Platform/LeMaker: Use ReportStatusCodeLib null instance > > > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg > > > Platform/SoftIron: Use ReportStatusCodeLib null instance > > > Platform/RPi3: Use ReportStatusCodeLib null instance > > > Platform/RaspberryPi: Drop the consume of PcdShellFile > > > > > > Silicon/Hisilicon/Hisilicon.dsc.inc | 10 +- > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > | > > > 2 +- > > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > > | 12 +- > > > Platform/Hisilicon/D03/D03.dsc | 10 +- > > > Platform/Hisilicon/D05/D05.dsc | 10 +- > > > Platform/Hisilicon/D06/D06.dsc | 8 +- > > > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 10 > > > +- > > > Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +- > > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > > | 10 +- > > > Platform/Hisilicon/D03/D03.fdf | 6 +- > > > Platform/Hisilicon/D05/D05.fdf | 6 +- > > > Platform/Hisilicon/D06/D06.fdf | 6 +- > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe. > > > inf | 2 - > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDx > > > e.inf | 1 - > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > > > | 2 - > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > > > | 77 -- > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h > > > | 1 - > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > > > | 55 -- > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h > > > | 21 - > > > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > > > | 4 +- > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFu > > > nction.c | 4 +- > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManuf > > > acturerFunction.c | 4 +- > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardMa > > > nufacturerFunction.c | 4 +- > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufa > > > cturerFunction.c | 2 +- > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDes > > > ignationFunction.c | 4 +- > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > > | 957 -------------------- > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c > > > | 112 --- > > > 27 files changed, 48 insertions(+), 1299 deletions(-) > > > delete mode 100644 > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > > > delete mode 100644 > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > > > delete mode 100644 > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h > > > delete mode 100644 > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > > delete mode 100644 > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c > > > > > > -- > > > 2.12.0.windows.1 > > > > > > > > > >