Re: [PATCH edk2-platforms 0/5] fix broken platforms

["Leif Lindholm" <leif.lindholm@linaro.org>]

If you fold in the additions from the follow-up into 1/5, for 1-4/5:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

I have some comments on 5/5.

/
    Leif

On Mon, Jun 10, 2019 at 04:20:01PM +0200, Ard Biesheuvel wrote:
> Fix the broken beagleboard and rdkqemu platforms, which were broken after
> recent changes that were applied to edk2, e.g., to move network modules into
> networkpkg. Also, bring rdkqemu up to date with some changes to ArmVirtQemu
> on which it is based.
> 
> Ard Biesheuvel (5):
>   Silicon/TexasInstruments/Omap35xxPkg: fix path references
>   Platform/BeagleBoard: fix path references in .inf files
>   Platform/BeagleBoard: fix platform build
>   Platform/RDKQemu: fix platform build
>   Platform/RDKQemu: stop using deprecated string conversion routines
> 
>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                                 | 54 ++++++++++----------
>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf                                 | 22 ++++----
>  Platform/BeagleBoard/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf          | 12 ++---
>  Platform/BeagleBoard/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.inf          |  2 +-
>  Platform/Comcast/Library/RdkBootManagerLib/DiskIo.c                                    | 12 ++++-
>  Platform/Comcast/Library/RdkBootManagerLib/RdkFile.c                                   | 28 +++++-----
>  Platform/Comcast/RDKQemu/RDKQemu.dsc                                                   | 23 ++++-----
>  Silicon/TexasInstruments/Omap35xxPkg/Flash/Flash.inf                                   |  2 +-
>  Silicon/TexasInstruments/Omap35xxPkg/Gpio/Gpio.inf                                     |  4 +-
>  Silicon/TexasInstruments/Omap35xxPkg/InterruptDxe/InterruptDxe.inf                     |  4 +-
>  Silicon/TexasInstruments/Omap35xxPkg/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf     |  8 +--
>  Silicon/TexasInstruments/Omap35xxPkg/Library/DebugAgentTimerLib/DebugAgentTimerLib.inf |  7 ++-
>  Silicon/TexasInstruments/Omap35xxPkg/Library/GdbSerialLib/GdbSerialLib.inf             |  4 +-
>  Silicon/TexasInstruments/Omap35xxPkg/Library/Omap35xxTimerLib/Omap35xxTimerLib.inf     |  4 +-
>  Silicon/TexasInstruments/Omap35xxPkg/Library/OmapDmaLib/OmapDmaLib.inf                 |  6 +--
>  Silicon/TexasInstruments/Omap35xxPkg/Library/OmapLib/OmapLib.inf                       |  4 +-
>  Silicon/TexasInstruments/Omap35xxPkg/Library/RealTimeClockLib/RealTimeClockLib.inf     |  4 +-
>  Silicon/TexasInstruments/Omap35xxPkg/Library/SerialPortLib/SerialPortLib.inf           |  2 +-
>  Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf                         |  4 +-
>  Silicon/TexasInstruments/Omap35xxPkg/PciEmulation/PciEmulation.inf                     |  6 +--
>  Silicon/TexasInstruments/Omap35xxPkg/SmbusDxe/Smbus.inf                                |  2 +-
>  Silicon/TexasInstruments/Omap35xxPkg/TPS65950Dxe/TPS65950.inf                          |  4 +-
>  Silicon/TexasInstruments/Omap35xxPkg/TimerDxe/TimerDxe.inf                             |  6 +--
>  23 files changed, 118 insertions(+), 106 deletions(-)
> 
> -- 
> 2.20.1
>