From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=gxPe86MR; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Mon, 10 Jun 2019 10:36:30 -0700 Received: by mail-wr1-f65.google.com with SMTP id r18so10043053wrm.10 for ; Mon, 10 Jun 2019 10:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x7R78Lg8XSmXfPgRTw4SvfXTjxDi2rZqQQuv4hAFjlA=; b=gxPe86MRqq9q0McxVZQGyR484WmJHG2kd78S8SHrWbSP9zJYUKdqu4iQllgOTQaV// bQbFITtr/0I98VUQSl5fVW3UqUJ3+ZtbEUbwRCANf5562iE7bHw+W1+m6YLTRnMYXaAD OJuaZdoWtvGbPAEj+lENJbcBlXOMIBuT2I44q1MUlTFk3TEWONj2zqeWS/TS9Wam5Fci SaV2HCgO6sulE+uVZ32G5UBEBA3HLN9oUia8MvfOVV9vgImqWDVaAv39fCKdylelPde2 AZQSkv/SzXFWAGXLgkZOB7gBRMxHExlm6DIORJbrrYlBSnizADm3bvBa8T3ILUMvDIja x8SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x7R78Lg8XSmXfPgRTw4SvfXTjxDi2rZqQQuv4hAFjlA=; b=E9rKSPPh8i0i1Rpeyh4uRgyrjsvEAdJl6SFggaqPc5uZRMgfvbw1jqpNulp61pato5 rDEovmgyVqP5IG869cEFE0BCA4vYJ1u6tqy8b6vx/P61YsOdVVZtbRuSb3eF0lm/E6Db HwQgX+ynp86pBzyy+ujX4LCQ78aPyaVHNcicJoqrLwInuACD+lfRxb/XKI0IJ82+Tfmb JX4LaBrlAdUdZUeSnTMBJ4ai1rsQM4+edSQZPoDE3zfMZ45mu3umkub9RDkweRuUwBJO 6D0+URUv8JLW02ZCujPCb/smai3bu3etnDI+k9Z1FMZK/f0q1lUTIlHj/KQrkFbnptcF WX0g== X-Gm-Message-State: APjAAAXI0F1A3NKXj2ESfsvGszuBkbjsqt2OCEqnQZGXyZJVwdEMKBWl 7nRnx6IZmbVlxnmlMcxV4LhBKazq0zA= X-Google-Smtp-Source: APXvYqxONppuDme5KRM1i3BfPKdy9BwEwsv/dozX9lEewlQY19CSwtwiepXqPES4TLjDCeLGVyNKYg== X-Received: by 2002:a05:6000:1206:: with SMTP id e6mr6605907wrx.182.1560188188172; Mon, 10 Jun 2019 10:36:28 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o4sm84907wmh.35.2019.06.10.10.36.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Jun 2019 10:36:27 -0700 (PDT) Date: Mon, 10 Jun 2019 18:36:25 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 0/5] fix broken platforms Message-ID: <20190610173625.7zh6epvdazzer4zu@bivouac.eciton.net> References: <20190610142006.30007-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190610142006.30007-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline If you fold in the additions from the follow-up into 1/5, for 1-4/5: Reviewed-by: Leif Lindholm I have some comments on 5/5. / Leif On Mon, Jun 10, 2019 at 04:20:01PM +0200, Ard Biesheuvel wrote: > Fix the broken beagleboard and rdkqemu platforms, which were broken after > recent changes that were applied to edk2, e.g., to move network modules into > networkpkg. Also, bring rdkqemu up to date with some changes to ArmVirtQemu > on which it is based. > > Ard Biesheuvel (5): > Silicon/TexasInstruments/Omap35xxPkg: fix path references > Platform/BeagleBoard: fix path references in .inf files > Platform/BeagleBoard: fix platform build > Platform/RDKQemu: fix platform build > Platform/RDKQemu: stop using deprecated string conversion routines > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 54 ++++++++++---------- > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf | 22 ++++---- > Platform/BeagleBoard/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 12 ++--- > Platform/BeagleBoard/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.inf | 2 +- > Platform/Comcast/Library/RdkBootManagerLib/DiskIo.c | 12 ++++- > Platform/Comcast/Library/RdkBootManagerLib/RdkFile.c | 28 +++++----- > Platform/Comcast/RDKQemu/RDKQemu.dsc | 23 ++++----- > Silicon/TexasInstruments/Omap35xxPkg/Flash/Flash.inf | 2 +- > Silicon/TexasInstruments/Omap35xxPkg/Gpio/Gpio.inf | 4 +- > Silicon/TexasInstruments/Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 4 +- > Silicon/TexasInstruments/Omap35xxPkg/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 8 +-- > Silicon/TexasInstruments/Omap35xxPkg/Library/DebugAgentTimerLib/DebugAgentTimerLib.inf | 7 ++- > Silicon/TexasInstruments/Omap35xxPkg/Library/GdbSerialLib/GdbSerialLib.inf | 4 +- > Silicon/TexasInstruments/Omap35xxPkg/Library/Omap35xxTimerLib/Omap35xxTimerLib.inf | 4 +- > Silicon/TexasInstruments/Omap35xxPkg/Library/OmapDmaLib/OmapDmaLib.inf | 6 +-- > Silicon/TexasInstruments/Omap35xxPkg/Library/OmapLib/OmapLib.inf | 4 +- > Silicon/TexasInstruments/Omap35xxPkg/Library/RealTimeClockLib/RealTimeClockLib.inf | 4 +- > Silicon/TexasInstruments/Omap35xxPkg/Library/SerialPortLib/SerialPortLib.inf | 2 +- > Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf | 4 +- > Silicon/TexasInstruments/Omap35xxPkg/PciEmulation/PciEmulation.inf | 6 +-- > Silicon/TexasInstruments/Omap35xxPkg/SmbusDxe/Smbus.inf | 2 +- > Silicon/TexasInstruments/Omap35xxPkg/TPS65950Dxe/TPS65950.inf | 4 +- > Silicon/TexasInstruments/Omap35xxPkg/TimerDxe/TimerDxe.inf | 6 +-- > 23 files changed, 118 insertions(+), 106 deletions(-) > > -- > 2.20.1 >