From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Feng, Bob C" <bob.c.feng@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Gao, Liming" <liming.gao@intel.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>,
Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 1/2] BaseTools: add centralized location for git config files
Date: Tue, 11 Jun 2019 10:35:28 +0100 [thread overview]
Message-ID: <20190611093528.55qrapessgyocmbc@bivouac.eciton.net> (raw)
In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D160135675@SHSMSX101.ccr.corp.intel.com>
Right, I tend to think of configuration files as
not-really-copyrightable.
Would you like me to send a v2, or would you be OK with me adding
#
# Copyright (c) 2019, Linaro Ltd. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
to both files and pushing the series?
Regards
Leif
On Tue, Jun 11, 2019 at 05:25:58AM +0000, Feng, Bob C wrote:
> Hi Leif,
>
> These 2 new file have no license header, need to add?
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, June 10, 2019 7:54 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH 1/2] BaseTools: add centralized location for git config files
>
> Before adding the git environment initialization script, add the following files that will be pointed to after running said script:
>
> - BaseTools/Conf/diff.order
> - BaseTools/Conf/gitattributes
>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> BaseTools/Conf/diff.order | 8 ++++++++
> BaseTools/Conf/gitattributes | 14 ++++++++++++++
> 2 files changed, 22 insertions(+)
> create mode 100644 BaseTools/Conf/diff.order create mode 100644 BaseTools/Conf/gitattributes
>
> diff --git a/BaseTools/Conf/diff.order b/BaseTools/Conf/diff.order new file mode 100644 index 0000000000..1d578ac28c
> --- /dev/null
> +++ b/BaseTools/Conf/diff.order
> @@ -0,0 +1,8 @@
> +*.dec
> +*.dsc.inc
> +*.dsc
> +*.fdf
> +*.inf
> +*.h
> +*.vfr
> +*.c
> diff --git a/BaseTools/Conf/gitattributes b/BaseTools/Conf/gitattributes new file mode 100644 index 0000000000..a8f923fd8a
> --- /dev/null
> +++ b/BaseTools/Conf/gitattributes
> @@ -0,0 +1,14 @@
> +*.efi -diff
> +*.EFI -diff
> +*.bin -diff
> +*.BIN -diff
> +*.raw -diff
> +*.RAW -diff
> +*.bmp -diff
> +*.BMP -diff
> +*.dec diff=ini
> +*.dsc diff=ini
> +*.dsc.inc diff=ini
> +*.fdf diff=ini
> +*.fdf.inc diff=ini
> +*.inf diff=ini
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-06-11 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 11:54 [PATCH 1/2] BaseTools: add centralized location for git config files Leif Lindholm
2019-06-11 5:25 ` Bob Feng
2019-06-11 9:35 ` Leif Lindholm [this message]
2019-06-12 1:07 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611093528.55qrapessgyocmbc@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox