From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=DaDSBWwm; spf=pass (domain: linaro.org, ip: 209.85.221.52, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by groups.io with SMTP; Tue, 11 Jun 2019 02:39:04 -0700 Received: by mail-wr1-f52.google.com with SMTP id m3so12233324wrv.2 for ; Tue, 11 Jun 2019 02:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QphPAnRtOAwf4EmR0c9ZFNuU2vorIjXdpkTFoRPPw0A=; b=DaDSBWwmg5Xs+FnL51o3mTOehoxJaPYSXy9TQMNPeF66MM6Bzzg3DLyjRXju2oMiDt 4tNMFr2oLMHsdLqZYaM11Wmj4qcjDDnyVBuMZT3Ls2OP1mOmaYhbhGGoJhCp3GjNrzyA qbdeHKbHxsdAHPh1dqz4QxOREigtslALbxKvlOKUhlGVIHoZQe1neAyXsZlnn9Ar5jIR m1swLSm5UKmm4zNXb7PC050JCAYml5mnxiZG8t6I0m0XvgPH8+S5mgUc36l2UjGpOjIm PpRBly0Xwc55koGQhYd0MbLU35lF5vglomiiBi4w5hIlovO/UnBiuxPdjXxOhpe1aCzj HgCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QphPAnRtOAwf4EmR0c9ZFNuU2vorIjXdpkTFoRPPw0A=; b=kN7QVoEKJYfQ1cHEDsipgAO4GOMjcp1+jgLMPnfD8XC1mRwLiTyjHBOQN/yIU1Wm5t dVtnBLcuBSzGZTbt3bvIllu0nsVHBg27Ig+rOKaG7mnMg6XMc2813Dxcj1nZku3bcN0S i2c/ecr9UVCeI5PE2iun+jVEeBE45N/D7eSR9wYE9HETl554NHawgy0oqC83/hw9CnQ/ fV1QYHsZ/nwugoMK8I866mk7tXCdMomj1AwEBHEAC0ZhBckpFqrfU2Pj+ySSFIOfkGNX E3bxiotV4ch1QkF/5hS/l49bZpWkkC2rpqtuQZOoU9opwLrVIpLkPIjPQ0+yAQacp8kJ Lelg== X-Gm-Message-State: APjAAAULKom4SY+pzWmIQNmXVqjGs2CFteo1ZSM1RaQ30MNLyb0Zf5H8 +WK32QKq1bNzDa7B0K8hdjAHgCFVqxc= X-Google-Smtp-Source: APXvYqzi9DVf5OR6xfFBQSgCKycLw7t1EIpTwkMbnX0SLYGhxRt6ix2WOXq59u7MdnCKsCLMl5Q1aw== X-Received: by 2002:adf:90c3:: with SMTP id i61mr32750218wri.48.1560245942007; Tue, 11 Jun 2019 02:39:02 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v3sm1459063wmh.31.2019.06.11.02.39.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2019 02:39:01 -0700 (PDT) Date: Tue, 11 Jun 2019 10:38:59 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: 'Ard Biesheuvel' , "ming.huang@linaro.org" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Message-ID: <20190611093859.rby64z5g54tchqav@bivouac.eciton.net> References: <20190520084105.9028-1-hao.a.wu@intel.com> <20190610151235.u73xywjsjqfo4fev@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 11, 2019 at 06:19:50AM +0000, Wu, Hao A wrote: > Can I go ahead to push this series? > Or should I wait someone for additional review? Go for it. My ACK applies to the series. Best Regards, Leif > Best Regards, > Hao Wu > > > > > On Mon, Jun 10, 2019 at 05:13:42AM +0000, Wu, Hao A wrote: > > > Hello Ard and Leif, > > > > > > I saw Ming Huang validated the patch (OS boot): > > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg > > > > > > https://edk2.groups.io/g/devel/message/41419 > > > (Thanks a lot for the validation effort.) > > > > > > Do you have remaining concerns for review this series? > > > Thanks in advance. > > > > > > Best Regards, > > > Hao Wu > > > > > > > > > > -----Original Message----- > > > > From: Wu, Hao A > > > > Sent: Monday, May 27, 2019 10:43 AM > > > > To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm > > > > Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray; > > > > guoheyi@huawei.com > > > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > > > > IntelFramework[Module]Pkg dependency > > > > > > > > Hello Ard and Leif, > > > > > > > > Do you have comments on this series? > > > > > > > > Also, for the below patch to Hisilicon platforms: > > > > [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in > > > > MdeModulePkg > > > > > > > > it is suggested to be verified on actual hardware: > > > > https://edk2.groups.io/g/devel/topic/31614327#41188 > > > > > > > > However, it seems that there is no accessible hardware for such > > verification > > > > at this moment. Do you think it is fine to push this change anyway? > > > > > > > > (Also CCed the stewards here for comments.) > > > > > > > > Best Regards, > > > > Hao Wu > > > > > > > > > > > > > -----Original Message----- > > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > Of > > > > > Wu, Hao A > > > > > Sent: Monday, May 20, 2019 4:41 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D > > > > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > > > > > IntelFramework[Module]Pkg dependency > > > > > > > > > > The series is also available at: > > > > > https://github.com/hwu25/edk2- > > > > > platforms/commits/drop_intelframework_v2 > > > > > > > > > > V2 changes: > > > > > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board, > > update > > > > > their DSC file to consume the null ReportStatusCodeLib in MdePkg. > > The > > > > > change is done since these platforms do not have a StatusCode > > Router > > > > > module; > > > > > B. Add the change for platform RaspberryPi/RPi3 to drop its > > dependency > > > > on > > > > > the framework packages; > > > > > C. Update the commit log message for patch > > > > > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg' > > > > > to better reflect the commit impact. > > > > > > > > > > > > > > > This series will drop the IntelFramework[Module]Pkg dependency for > > > > > platforms within the edk2-platforms repo. > > > > > packages. > > > > > > > > > > Tests done for the series: > > > > > Platforms build verified with GCC5 toolchain: > > > > > * Platform/AMD/OverdriveBoard > > > > > * Platform/ARM/JunoPkg > > > > > * Platform/ARM/SgiPkg > > > > > * Platform/ARM/VExpressPkg > > > > > * Platform/BeagleBoard > > > > > * Platform/Hisilicon/D0x > > > > > * Platform/Hisilicon/HiKey > > > > > * Platform/Hisilicon/HiKey960 > > > > > * Platform/LeMaker/CelloBoard > > > > > * Platform/Marvell/Armada70x0Db (only AARCH64) > > > > > * Platform/Marvell/Armada80x0Db (only AARCH64) > > > > > * Platform/RaspberryPi/RPi3 > > > > > * Platform/Socionext/DeveloperBox > > > > > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64) > > > > > * Platform/SoftIron/Overdrive1000Board > > > > > * Platform/SolidRun/Armada80x0McBin (only AARCH64) > > > > > > > > > > Platforms originally cannot be built via GCC5 toolchain (thus, not > > > > > verified): > > > > > * Platform/Comcast/RDKQemu (ARM, AARCH64) > > > > > * Platform/Marvell/Armada70x0Db (ARM) > > > > > * Platform/Marvell/Armada80x0Db (ARM) > > > > > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64) > > > > > * Platform/SolidRun/Armada80x0McBin (ARM) > > > > > > > > > > Cc: Ard Biesheuvel > > > > > Cc: Leif Lindholm > > > > > Cc: Michael D Kinney > > > > > > > > > > Hao A Wu (18): > > > > > Platform/AMD: Use Lzma decompress lib in MdeModulePkg > > > > > Platform/BeagleBoard: Use ReportStatusCodeLib null instance > > > > > Platform/BeagleBoard: Drop the consume of PcdShellFile > > > > > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg > > > > > Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib > > > > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg > > > > > Hisilicon/D06: Drop the consume of PcdShellFile > > > > > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg > > > > > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg > > > > > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in > > > > MdeModulePkg > > > > > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg > > dependency > > > > > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon > > PlatformBdsLib > > > > > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg > > > > > Platform/LeMaker: Use ReportStatusCodeLib null instance > > > > > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg > > > > > Platform/SoftIron: Use ReportStatusCodeLib null instance > > > > > Platform/RPi3: Use ReportStatusCodeLib null instance > > > > > Platform/RaspberryPi: Drop the consume of PcdShellFile > > > > > > > > > > Silicon/Hisilicon/Hisilicon.dsc.inc | 10 +- > > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > > > | > > > > > 2 +- > > > > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > > > > | 12 +- > > > > > Platform/Hisilicon/D03/D03.dsc | 10 +- > > > > > Platform/Hisilicon/D05/D05.dsc | 10 +- > > > > > Platform/Hisilicon/D06/D06.dsc | 8 +- > > > > > Platform/LeMaker/CelloBoard/CelloBoard.dsc | > > 10 > > > > > +- > > > > > Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +- > > > > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > > > > | 10 +- > > > > > Platform/Hisilicon/D03/D03.fdf | 6 +- > > > > > Platform/Hisilicon/D05/D05.fdf | 6 +- > > > > > Platform/Hisilicon/D06/D06.fdf | 6 +- > > > > > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDx > > e. > > > > > inf | 2 - > > > > > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass > > Dx > > > > > e.inf | 1 - > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > > > > > | 2 - > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > > > > > | 77 -- > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h > > > > > | 1 - > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > > > > > | 55 -- > > > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h > > > > > | 21 - > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass. > > c > > > > > | 4 +- > > > > > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorF > > u > > > > > nction.c | 4 +- > > > > > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManu > > f > > > > > acturerFunction.c | 4 +- > > > > > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardM > > a > > > > > nufacturerFunction.c | 4 +- > > > > > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManu > > fa > > > > > cturerFunction.c | 2 +- > > > > > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotD > > es > > > > > ignationFunction.c | 4 +- > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > > > > | 957 -------------------- > > > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c > > > > > | 112 --- > > > > > 27 files changed, 48 insertions(+), 1299 deletions(-) > > > > > delete mode 100644 > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > > > > > delete mode 100644 > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > > > > > delete mode 100644 > > > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h > > > > > delete mode 100644 > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > > > > delete mode 100644 > > > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c > > > > > > > > > > -- > > > > > 2.12.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > >