From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ljWbqB0U; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Tue, 11 Jun 2019 03:30:11 -0700 Received: by mail-wr1-f66.google.com with SMTP id n4so12352359wrw.13 for ; Tue, 11 Jun 2019 03:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9anBOtxftFFRD95E7KSuD+9HdezU+qE2OeNHtrLpNtU=; b=ljWbqB0UN1ubW2iIaBJQzWPkL7ZwgGV+cKkFvtk405D/Q42H6DtU/sa7EqOe7m+CYH Sh/PfJ3R/qX+HSTtOMk4fJ31jNYrCEnAnR0r/nvy7smYPEVwokKnCg4gFxhKXKLFwMAp 7OH1QGY5Jm+Regiv6RVS+TaT5b2Kv69L/GKof7UDcue9szFiPBXUH2EJhb8/c+w6kUGT YXhYFGRh1kZEEiTAy/Pri841SMlngVH8yNa8DsrtQlSyUAQHPT2UKXOxvx+l6ZtMk50o OSMJtKWrIv/KTef00u92iSsOWo+EyENKQb73PoKur8rJLZqeF+GIAFWUA+j6IAWUivQk d61A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9anBOtxftFFRD95E7KSuD+9HdezU+qE2OeNHtrLpNtU=; b=HugG8x4+pVmbR/jlJvhn3DR+9eP9JkQxNQbKRGgKHdWPai5RnMFzBt4Vvg8oaTscFU aNueUaBRZbFVgO5380icVpgGssx1h1Zm+/lBzf5JMHftGxUD+KwtzVDS8fyRkNbNadHE ZdYdMJPvPx4m0dpsji5DoLiaehNQaK/Wo9+iSNYP0cjGyn7PPIyhJs0H8mucxgrzyceH QQYqAK/98oyR9IlanUZC86waqGkTzFQhovAq05gkGARDOfPnEVMr7Y7VGCPsOML74zUl 5a+aRXllScs9OT+OdpLvIIbfhSgfFy4jVLUsqrmLUNuyraVyryhnVZjaFFTgwjSMceYM q22A== X-Gm-Message-State: APjAAAVpaa0VvMDXf+qXnSmGpzMRdMu/iPCnWPpVfPv8vYaKPNIi0Hvz aES5D1cAdVcoPdly5aFFTfZz4JKv9U4= X-Google-Smtp-Source: APXvYqyzw39SeYEKexWlGDJjJrfpMNdjzfKITNVXz8WCITrjENsuJ6jF0bW8z7xMB0lmZkea4AzVcg== X-Received: by 2002:a5d:6709:: with SMTP id o9mr35952592wru.301.1560249009479; Tue, 11 Jun 2019 03:30:09 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l8sm9060908wrg.40.2019.06.11.03.30.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2019 03:30:08 -0700 (PDT) Date: Tue, 11 Jun 2019 11:30:07 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, lersek@redhat.com Cc: "Gao, Liming" , "sssky307@163.com" , "'announce@edk2.groups.io'" , "Kinney, Michael D" , "afish@apple.com" Subject: Re: [edk2-devel] EDK II Stable Tag release edk2-stable201905 completed Message-ID: <20190611103007.fwnbpiympnofpy4x@bivouac.eciton.net> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46CD3D@SHSMSX104.ccr.corp.intel.com> <7606aa6e.d162.16b40a3cb45.Coremail.sssky307@163.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E46DF7E@SHSMSX104.ccr.corp.intel.com> <20190610140014.botd5fxrrrrus4a5@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 11, 2019 at 12:08:34PM +0200, Laszlo Ersek wrote: > > Argh, no. OpenSSL has boringssl as a git submodule. > > > > edk2/CryptoPkg/Library/OpensslLib/openssl$ cat .gitmodules > > [submodule "boringssl"] > > path = boringssl > > url = https://boringssl.googlesource.com/boringssl > > ... > > > > That's right, but it shouldn't matter. In edk2, I always use > > $ git submodule update --init --force > > and I never pass the "--recursive" flag. This is also how I tested the > upgrade to OpenSSL-1.1.1b, before edk2-stable201905 was tagged. The > boringssl sub-sub-module is not needed for edk2's purposes. > > We might want to drop "--recursive" from "OpenSSL-HOWTO.txt", instead. The instructions have spread to many other places (build instructions in wiki and edk2-platforms Readme.md being two of them). That's not to say we shouldn't change it, but that we need to go through and update those places too. And frankly, if we've accepted the need to support submodules, we need to document how edk2 interacts with submodules, not how each individual submodule interacts with edk2 - so the git instructions in OpenSSL-HOWTO.txt should probably be deleted. This might be a good topic to bring to the next design meeting. Presumably the above will be a useful workaround for the original reporter in the meantime. Regards, Leif