public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io, "Gao, Liming" <liming.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"afish@apple.com" <afish@apple.com>
Subject: Re: [edk2-devel] EDK II Stable Tag release edk2-stable201905 completed
Date: Wed, 12 Jun 2019 10:21:05 +0100	[thread overview]
Message-ID: <20190612092105.y6ig6rsaybqadunw@bivouac.eciton.net> (raw)
In-Reply-To: <625afe99-fcd0-7a08-eb63-7b9e8a64b44e@redhat.com>

On Wed, Jun 12, 2019 at 10:18:24AM +0200, Laszlo Ersek wrote:
> > In this instance, we explicitly don't care about the submodule for
> > that other project (and I really hope this is the norm) - so we
> > shouldn't be documenting steps that rely on that additional
> > submodule existing.
> 
> Yes; this is why I suggested dropping "--recursive" from the
> instructions. As far as I remember, it was meant as a convenience for
> users cloning the edk2 repo from zero.

But we've never actually relied on that behaviour, so it's not so much
convenience as cargo culting.

> > This is why I am referring to anything other than a central definition
> > of the relationship between edk2 and its submodules as a workaround. I
> > am not suggesting any shortcomings in the technical aspect.
> 
> Can you provide an example definition then? I'm having trouble imagining
> one.

Laszlo, I think you've misunderstood me somewhere.

What I am saying is:
- We should have a policy (i.e., a section in toplevel Readme.md)
  regarding submodules.
  - That policy *should* include the requirement to not permit
    submodules requiring submodules for our purposes.
  - That policy should include the steps required to get the edk2
    repository to a buildable state.
  - Nothing related to submodules should be documented anywhere else
    in the tree. Sure, OpenSSL-HOWTO.txt can still be there, but
    the section "HOW to Install OpenSSL for UEFI Building" should go.

Regards,

Leif

  reply	other threads:[~2019-06-12  9:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  9:54 EDK II Stable Tag release edk2-stable201905 completed Liming Gao
2019-06-10  9:06 ` [edk2-devel] " krishnaLee
2019-06-10 13:50   ` Liming Gao
2019-06-10 14:00     ` Leif Lindholm
2019-06-10 14:16       ` Liming Gao
2019-06-12  5:24         ` krishnaLee
2019-06-11 10:08       ` Laszlo Ersek
2019-06-11 10:30         ` Leif Lindholm
2019-06-11 15:46           ` Laszlo Ersek
2019-06-11 16:08             ` Leif Lindholm
2019-06-12  8:18               ` Laszlo Ersek
2019-06-12  9:21                 ` Leif Lindholm [this message]
2019-06-12  9:37                   ` Laszlo Ersek
2019-06-12 13:30                     ` Liming Gao
2019-06-12 17:00                       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612092105.y6ig6rsaybqadunw@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox