public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Subject: Re: [edk2-devel] [PATCH edk2-platforms] Platforms/Hisilicon: update OptionRomPkg path for HiKey
Date: Thu, 13 Jun 2019 12:52:31 +0100	[thread overview]
Message-ID: <20190613115231.vhvn2yt5ix36vezh@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu8gSfXEwNK9-DdyFySYb5EXpsu2qhTNxC=Mg0AmjwQjsg@mail.gmail.com>

On Thu, Jun 13, 2019 at 01:42:29PM +0200, Ard Biesheuvel wrote:
> On Thu, 13 Jun 2019 at 13:41, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > The migration of OptionRomPkg to edk2-platforms broke the HiKey build.
> > Update the paths in .dsc/.fdf to restore.
> >
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks!
Pushed as 06910756b8.

> > ---
> >  Platform/Hisilicon/HiKey/HiKey.dsc | 2 +-
> >  Platform/Hisilicon/HiKey/HiKey.fdf | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> > index c785af6e69..bcbe4fafce 100644
> > --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> > @@ -246,7 +246,7 @@ [Components.common]
> >    #
> >    # AX88772 Ethernet Driver
> >    #
> > -  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> > +  Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> >
> >    #
> >    # FAT filesystem + GPT/MBR partitioning
> > diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf b/Platform/Hisilicon/HiKey/HiKey.fdf
> > index 2b2e3ad053..33fa0da208 100644
> > --- a/Platform/Hisilicon/HiKey/HiKey.fdf
> > +++ b/Platform/Hisilicon/HiKey/HiKey.fdf
> > @@ -158,7 +158,7 @@ [FV.FvMain]
> >    #
> >    # AX88772 Ethernet Driver for Apple Ethernet Adapter
> >    #
> > -  INF OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> > +  INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> >
> >    #
> >    # FAT filesystem + GPT/MBR partitioning
> > --
> > 2.11.0
> >
> 
> 
> 

      reply	other threads:[~2019-06-13 11:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 11:41 [PATCH edk2-platforms] Platforms/Hisilicon: update OptionRomPkg path for HiKey Leif Lindholm
2019-06-13 11:42 ` Ard Biesheuvel
2019-06-13 11:52   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613115231.vhvn2yt5ix36vezh@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox