From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=PTzzLBJI;
 spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67])
 by groups.io with SMTP; Thu, 13 Jun 2019 04:52:35 -0700
Received: by mail-wm1-f67.google.com with SMTP id u8so9810970wmm.1
        for <devel@edk2.groups.io>; Thu, 13 Jun 2019 04:52:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=MkqUYh/4AWVs3UYEVvbeY1fEt1xghH/NEtPfBtAjPA8=;
        b=PTzzLBJILxG4NMw+X2F5XQwX5DAPIPHX4NFqiPmUEm2VQ2fiVbiXnhz6qfbajNcZOV
         SFR+B3MmlljKBoj5wLjyS7GmMHfJVi5pbUv4tR05Ix01NkgENw5tSUNXE7f42RNfx447
         3J7H+7iie6xAWHMR2YBCMJD8cGJtcLQaed/vl6Q3j4fxHW/TEJG1oBKEjPDnUVs5smRi
         OLqatQKjk7YRsWc3jnAZqajUAskoa4lVaV1pdl7JY3gFgc6q/86bfhJSuHUQYRpoJFX1
         xq2kq/ifypKBI4/1kB/jF3rtZtzw+L8mIxhx4Ti5bg/Oltyw3gF7k6QgJ+Hppu9KskmH
         lHNg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=MkqUYh/4AWVs3UYEVvbeY1fEt1xghH/NEtPfBtAjPA8=;
        b=sIHlBGsAV80iXKzr+owz9E8VksmdkDVCd7KYW1UEy/9VbmJpevVxBlzchyVlrMaXyD
         9aU79hce4v1fGZHZXSim/EJ5CHGOUil99+aSFn8qHEkio+aseKdmSzxI6SiM1uBrcG4h
         uQbUnB1vcPO6EUeyWpiMp381/O/dad6PNaKOqyt0lKXvNoasWPYurztI7de3X9ibkZOf
         YT6zkO7ix79hbbX6h38n890aXHGkXrYEIF9SkY78jbzXi43mzgvdbpjdh+tbkoTM/LdU
         AAzKvjrhI4j2XiieViropAdeloXqNn7NbTg5RdyAOxr6eeQ8QtCzi56IULpvOlcyPj3M
         WMYw==
X-Gm-Message-State: APjAAAWYGsmgagFbpzWySmTwQIMyzOBUU/yXCHo3mvDPgClRihivT/1u
	TqoFxMaV77Xx9aABiAQSbpeqwDa0wpU=
X-Google-Smtp-Source: APXvYqyl6+qCQ5FXMVy5PBBuuPkplBdhUO4hsGPUCzqTDT1fbGunyfntEx6W9KlLmSvGqs8eqvSRug==
X-Received: by 2002:a1c:4987:: with SMTP id w129mr3384421wma.41.1560426753392;
        Thu, 13 Jun 2019 04:52:33 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id l4sm2136201wmh.18.2019.06.13.04.52.32
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Thu, 13 Jun 2019 04:52:32 -0700 (PDT)
Date: Thu, 13 Jun 2019 12:52:31 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Subject: Re: [edk2-devel] [PATCH edk2-platforms] Platforms/Hisilicon: update OptionRomPkg path for HiKey
Message-ID: <20190613115231.vhvn2yt5ix36vezh@bivouac.eciton.net>
References: <20190613114152.32671-1-leif.lindholm@linaro.org>
 <CAKv+Gu8gSfXEwNK9-DdyFySYb5EXpsu2qhTNxC=Mg0AmjwQjsg@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu8gSfXEwNK9-DdyFySYb5EXpsu2qhTNxC=Mg0AmjwQjsg@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jun 13, 2019 at 01:42:29PM +0200, Ard Biesheuvel wrote:
> On Thu, 13 Jun 2019 at 13:41, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > The migration of OptionRomPkg to edk2-platforms broke the HiKey build.
> > Update the paths in .dsc/.fdf to restore.
> >
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks!
Pushed as 06910756b8.

> > ---
> >  Platform/Hisilicon/HiKey/HiKey.dsc | 2 +-
> >  Platform/Hisilicon/HiKey/HiKey.fdf | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> > index c785af6e69..bcbe4fafce 100644
> > --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> > @@ -246,7 +246,7 @@ [Components.common]
> >    #
> >    # AX88772 Ethernet Driver
> >    #
> > -  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> > +  Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> >
> >    #
> >    # FAT filesystem + GPT/MBR partitioning
> > diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf b/Platform/Hisilicon/HiKey/HiKey.fdf
> > index 2b2e3ad053..33fa0da208 100644
> > --- a/Platform/Hisilicon/HiKey/HiKey.fdf
> > +++ b/Platform/Hisilicon/HiKey/HiKey.fdf
> > @@ -158,7 +158,7 @@ [FV.FvMain]
> >    #
> >    # AX88772 Ethernet Driver for Apple Ethernet Adapter
> >    #
> > -  INF OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> > +  INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> >
> >    #
> >    # FAT filesystem + GPT/MBR partitioning
> > --
> > 2.11.0
> >
> 
> 
>